8043 Commits

• Integrate spectate button implementation
  Dan Balasescu · 2022-03-17 18:36:33 +09:00
  461d41529b
• Change PerformancePointsCounter resolution requirements to be required

  All other similar UI components have required dependencies, so this is
  mainly to bring things in line with expectations. I am using this fact
  in the skin editor to only show components which can be used in the
  current editor context (by `try-catch`ing their
  `Activator.CreateInstance`).

  Dean Herbert · 2022-03-17 14:56:35 +09:00
  ac739c9dae
• Make opening chat overlay opt-in to add coverage for unloaded chat overlays

  Causes `TestHighlightWhileChatNeverOpen` to fail as expected.

  Salman Ahmed · 2022-03-17 08:19:40 +03:00
  46e66e66e4
• Implement mod settings area component
  Bartłomiej Dach · 2022-03-16 23:13:11 +01:00
  624f9fc774
• Simplify fade-out transform
  Bartłomiej Dach · 2022-03-16 21:49:04 +01:00
  a8cefca685
• Remove unnecessary OsuColour cache

  One is already cached at `OsuGameBase` level.

  Bartłomiej Dach · 2022-03-16 21:46:02 +01:00
  03d3969b38
• Add missing OverlayColourProvider to SkinEditor test
  Dean Herbert · 2022-03-16 22:23:19 +09:00
  3f61b0d968
• Merge branch 'master' into skin-editor-sidebars
  Dan Balasescu · 2022-03-16 21:12:18 +09:00
  7f65f6adcc
• Remove redundant spacing in ControlItem test scene
  Jai Sharma · 2022-03-16 11:57:11 +00:00
  c2e4779c2e
• Merge branch 'master' into skin-editor-scene-library
  Dan Balasescu · 2022-03-16 20:42:30 +09:00
  b9387c7ff1
• Update skin editor to use EditorSidebar
  Dean Herbert · 2022-03-16 19:30:51 +09:00
  4525ed645c
• Add basic scene selector
  Dean Herbert · 2022-03-16 19:12:06 +09:00
  d062810ff2
• Add missing Schedule call to allow individual tests from TestSceneMessageNotifier to pass
  Dean Herbert · 2022-03-16 18:44:30 +09:00
  2452d84e98
• Merge pull request #17260 from peppy/editor-sidebar

  Add `EditorSidebar` component

  Dan Balasescu · 2022-03-16 18:20:18 +09:00
  7e8aa77b2b
• Allow section headers to wrap
  Dean Herbert · 2022-03-16 17:19:08 +09:00
  ba1642a680
• Move all PlaylistResultScreen test state initialisation into SetUpSteps
  Jai Sharma · 2022-03-15 22:15:35 +00:00
  1c79083f96
• Fix PlaylistResultsScreen test failures

  As seen: https://github.com/ppy/osu/pull/17252/checks?check_run_id=5545717506
  
  The `PlaylistsResultsScreen` takes a lease on the `Beatmap` bindable
  when entered. During `SetUp`, the `Beatmap` bindable is reassigned but
  fails in cases where an existing test instance of the screen hasn't been
  exited yet. This fix moves the assignment into the `SetUpSteps` function
  after `base.SetUpSteps` is called which will exit the existing screens
  first.

  Jai Sharma · 2022-03-15 20:38:04 +00:00
  c56df80106
• Add EditorSidebar component
  Dean Herbert · 2022-03-15 16:38:00 +09:00
  9e476ced63
• Merge branch 'master' into pp-counter-alloc-reduction
  Dean Herbert · 2022-03-15 13:31:57 +09:00
  6fb06d69cc
• Merge pull request #17242 from smoogipoo/performance-calculator-cleanup

  Restructure PerformanceCalculator to not require ScoreInfo argument

  Dean Herbert · 2022-03-15 13:31:34 +09:00
  deb4aeb4b2
• Remove unnecessary ctor arguments
  Dan Balasescu · 2022-03-15 12:34:58 +09:00
  daac933498
• Prevent incorrect usages by hard-typing ctor type
  Dan Balasescu · 2022-03-15 09:11:59 +09:00
  59d57a44d4
• Ensure existing items are expired and cleared in ChannelControlItem test setup
  Jai Sharma · 2022-03-14 22:21:18 +00:00
  6628b7c654
• Refactor ControlItemText to use bindable flow for unread state
  Jai Sharma · 2022-03-14 21:32:30 +00:00
  75958bf270
• Refactor ControlItemMention to use bindable flow
  Jai Sharma · 2022-03-14 21:26:33 +00:00
  b01a809d55
• Use OsuColour.Red1 for ControlItemClose hover colour
  Jai Sharma · 2022-03-14 21:10:39 +00:00
  9621ef9437
• Use autosizing for ChannelControlItem test scene
  Jai Sharma · 2022-03-14 20:06:31 +00:00
  e9f0ad33ef
• Code quality fixes
  Jai Sharma · 2022-03-14 19:42:55 +00:00
  c0d82dfb41
• Implement ChannelControlItem for new chat design

  Adds new component `ChannelControlItem` and it's child components to be
  used as the clickable control in the new chat sidebar for joined
  channels.
  
  Has public properties `HasUnread` and `MentionCount` to control the
  display of the channel having unread messages or mentions of the user.
  
  Channel select/join requests are exposed via `OnRequestSelect` and
  `OnRequestLeave` events respectively which should be handled by a parent
  component.
  
  Requires a cached `Bindable<Channel>` instance to be managed by a parent
  component.
  
  Requires a cached `OveralayColourScheme` instance to be provided by a
  parent component.

  Jai Sharma · 2022-03-14 18:55:27 +00:00
  39c30516d0
• Provide correct HitResult type for random judgements in TestSceneHitErrorMeter
  Dean Herbert · 2022-03-14 19:16:19 +09:00
  b31ff679fb
• Require ScoreProcessor to receive ruleset
  Dan Balasescu · 2022-03-14 15:51:10 +09:00
  3fff7f4b7e
• Restructure PerformanceCalculator to not require ScoreInfo argument
  Dan Balasescu · 2022-03-14 14:25:28 +09:00
  4a3e3aba65
• Add failing test cases
  Salman Ahmed · 2022-03-14 03:47:18 +03:00
  720e1cd206
• Add failing test assertion
  Salman Ahmed · 2022-03-14 03:46:11 +03:00
  dbc26c3534
• Merge branch 'master' into chat-mention-highlight
  Salman Ahmed · 2022-03-11 17:51:22 +03:00
  cc87563d57
• Improve channel switching flow in HighlightMessage
  Salman Ahmed · 2022-03-10 23:07:15 +03:00
  a31611bdec
• Add test coverage for highlighting message on left channel
  Salman Ahmed · 2022-03-10 21:30:02 +03:00
  e419370830
• Merge pull request #17180 from jai-x/new-chat-channel-listing

  Implement `ChannelListing` for new chat design

  Dean Herbert · 2022-03-10 19:27:58 +09:00
  d1f8fd01df
• Fix potential test failures due to slow realm refresh in TestSceneScreenNavigation

  As seen at https://github.com/ppy/osu/runs/5492345983?check_suite_focus=true.

  Dean Herbert · 2022-03-10 18:10:08 +09:00
  d5eca16b69
• Merge pull request #17164 from smoogipoo/scoreprocessor-rework

  Rework ScoreProcessor score calculation methods to fix various issues

  Dean Herbert · 2022-03-10 16:48:58 +09:00
  db5c2c15dc
• Merge branch 'master' into new-chat-channel-listing
  Dean Herbert · 2022-03-10 15:49:06 +09:00
  0155519343
• Merge branch 'master' into chat-mention-highlight
  Dean Herbert · 2022-03-10 14:23:23 +09:00
  022dd88aef
• Add too many messages to better test long scrolls
  Salman Ahmed · 2022-03-10 04:01:07 +03:00
  f229447453
• Add test case for highlighting while chat overlay is hidden
  Salman Ahmed · 2022-03-10 02:50:27 +03:00
  d4de435eb2
• Scroll chat line to channel center

  We may eventually want that encapsulated within `ScrollIntoView`, as it
  would also come in handy for `GameplayLeaderboard`.

  Salman Ahmed · 2022-03-10 02:50:15 +03:00
  80c0df6af5
• Remove NewChat namespace
  Jai Sharma · 2022-03-09 18:13:56 +00:00
  b67f9269f9
• Merge branch 'master' into scoreprocessor-rework
  Dean Herbert · 2022-03-09 23:04:18 +09:00
  94ff6a338f
• Fix non-matching filename
  Dean Herbert · 2022-03-09 18:07:43 +09:00
  2e350a91cc
• Fix regressing issues when attempting to exit Player after an unsuccessful beatmap load
  Dean Herbert · 2022-03-09 17:57:58 +09:00
  2eb3365f46
• Ensure gameplay can't start when an UnknownMod is present
  Dean Herbert · 2022-03-09 17:57:58 +09:00
  1ee0be5e39