Joseph Madamba
b40d114e76
Remove context menu from news card for now
2022-12-28 15:00:57 -08:00
Bartłomiej Dach
74bc5d4666
Disable naming rule inspection on struct stat definition
2022-12-28 22:38:42 +01:00
Bartłomiej Dach
10c11e974d
Fix broken spacing
2022-12-28 22:24:21 +01:00
Bartłomiej Dach
49b0ec9ddb
Fix broken condition
2022-12-28 22:24:18 +01:00
Bartłomiej Dach
8d79fa93ac
Implement GetFileLinkCount() for Linux
2022-12-28 22:14:56 +01:00
Bartłomiej Dach
d4b3965967
Change warning message about file duplication
...
- It was being glued in an ugly way that would have prevented sanely
localising it.
- Even on Linux, the filesystem (whichever one the user has chosen out
of the multitude available) still needs to support hard links for them
to have a chance of working.
2022-12-28 22:04:08 +01:00
Bartłomiej Dach
04d4b4a6ce
Rename and xmldoc hard link creation method
2022-12-28 22:04:05 +01:00
Bartłomiej Dach
cadd487c75
Use switch statement in AttemptHardLink()
2022-12-28 21:20:49 +01:00
Bartłomiej Dach
2c346eae0d
Revert inlining of hard link creation into condition
...
Just feels bad. Mixing data access with actual underlying logic.
2022-12-28 21:19:28 +01:00
BlauFx
d63be3ff17
Change name of variable
2022-12-28 15:02:44 +01:00
BlauFx
c6da7248ba
Remove unnecessary directive
2022-12-28 14:40:32 +01:00
BlauFx
53bca947d1
Move duplicated code into its own method
2022-12-28 14:34:27 +01:00
BlauFx
f32564652b
Mention the filesystem should be NTFS on Windows
2022-12-28 14:33:38 +01:00
BlauFx
5c5e84f931
Fix formatiing
2022-12-28 14:06:50 +01:00
Dean Herbert
ea8beffa61
Merge pull request #21871 from bdach/solo-statistics-watcher-reliability
...
Improve reliability of solo statistics watcher
2022-12-28 21:05:38 +08:00
BlauFx
16165b1f67
Remove blank line
2022-12-28 13:58:52 +01:00
Feodor0090
930cd15649
Merge branch 'master' into comment-editor-1
2022-12-28 17:46:01 +05:00
Bartłomiej Dach
e4c060fc3a
Merge pull request #21854 from peppy/fix-website-root
...
Fix `osu.ppy.sh` links no longer opening in-game
2022-12-28 13:43:24 +01:00
BlauFx
b2aa2e1602
Add hardlink support for Linux
2022-12-28 13:32:49 +01:00
Bartłomiej Dach
4b71ccf315
Merge pull request #21879 from frenzibyte/first-object-visbility-keywords
...
Add keywords to ease search of "first object visibility" setting
2022-12-28 12:15:34 +01:00
Salman Ahmed
b4c5e18da0
Add keywords to ease search of "first object visibility" setting
2022-12-28 13:23:50 +03:00
Bartłomiej Dach
3c0b8af8f1
Allow unsubscribing from solo statistics updates
...
This is more of a safety item. To avoid potential duplicate key in
dictionary errors (and also avoid being slightly memory-leaky), allow
`SoloStatisticsWatcher` consumers to dispose of the subscriptions they
take out.
2022-12-28 08:07:48 +01:00
Bartłomiej Dach
04f9a354c3
Convert SoloResultsScreen to NRT
2022-12-28 07:54:36 +01:00
Bartłomiej Dach
a0a26b1e8c
Ignore statistics update subscriptions with invalid score ID
...
If score submission fails, the score will not receive a correct online
ID from web, but will still be passed on to the solo statistics watcher
on the results screen. This could lead to the watcher subscribing to
changes with score ID equal to the default of -1. If this happened more
than once, that would cause a crash due to duplicate keys in the
`callbacks` dictionary.
Closes #21837 .
2022-12-28 07:54:01 +01:00
Bartłomiej Dach
e9d32fca18
Fix various failures in initial statistics fetch
...
- If the local user is restricted, then attempting to fetch their data
from the `/users` endpoint would result in an empty response.
- Even if the user was successfully fetched, their `RulesetsStatistics`
may not be populated (and instead be `null`). Curiously this was not
picked up by static analysis until the first issue was fixed.
Closes #21839 .
2022-12-28 07:31:36 +01:00
Dean Herbert
0d78bc2248
Fix osu.ppy.sh links no longer opening in-game
...
Addresses https://github.com/ppy/osu/discussions/21838 .
2022-12-28 06:42:35 +08:00
Bartłomiej Dach
e90619244d
Fix incorrect accuracy display on overall ranking view
2022-12-27 19:51:51 +01:00
Bartłomiej Dach
ae2058b55e
Merge branch 'master' into split_trimentries
2022-12-27 18:07:36 +01:00
Salman Ahmed
1a4489edb2
Move version pinning of system packages to osu.Game
2022-12-27 14:58:18 +03:00
Dean Herbert
61029b126d
Add link to hard link explanation wiki page
2022-12-27 17:56:23 +08:00
Dean Herbert
b3e44f20bc
Use new lazer API endpoint
...
This is a temporary change to target the new experimental/next deploy.
The main change that should result from this is having the user profile
show the pp^next values from the new domain.
2022-12-27 17:20:40 +08:00
Berkan Diler
182f36c434
Use StringSplitOptions.TrimEntries for string.Split() when possible
2022-12-27 09:41:58 +01:00
Dean Herbert
df6f2ad0a1
Merge pull request #21804 from bdach/hide-global-rankings-when-presenting-scores
...
Only show global rankings on solo results screen when progressing from gameplay
2022-12-27 16:39:26 +08:00
Joseph Madamba
777ffcf805
Highlight "open" option on external link button context menu
2022-12-26 20:47:24 -08:00
Joseph Madamba
bb58976838
Merge remote-tracking branch 'upstream/master' into overlay-panels-context-menu
2022-12-26 17:54:15 -08:00
Joseph Madamba
8bc8b0d0af
Remove redundant context menu container
2022-12-26 15:38:07 -08:00
Joseph Madamba
84e3858a86
Move context menu / popover container one level to account for header
2022-12-26 15:37:46 -08:00
Bartłomiej Dach
01cf96e240
Only show global rankings on results screen when progressing from gameplay
2022-12-26 23:35:45 +01:00
Bartłomiej Dach
cb2b0d4178
Remove redundant type specs
2022-12-26 23:12:53 +01:00
Berkan Diler
fcbb21c75e
Fix typo
2022-12-26 20:38:35 +01:00
Berkan Diler
c7ca4bbba5
Use generic Enum methods
2022-12-26 20:36:39 +01:00
Bartłomiej Dach
e416bdd06b
Merge branch 'master' into remove_obsolete_star_colours
2022-12-26 16:35:47 +01:00
mk56-spn
fbff5d8d69
Remove obsoleted "ForDifficultyRating" method
2022-12-26 16:16:52 +01:00
Dean Herbert
5dd03c6c60
Update framework
2022-12-26 21:53:52 +08:00
Dan Balasescu
786d94c149
Merge pull request #21792 from Joehuu/fix-parameters-inspection
...
Fix parameters with the same default value inspection
2022-12-26 15:41:54 +09:00
Joseph Madamba
0dba25e0ab
Refactor to just exit sub screens until lounge sub screen
...
Co-Authored-By: Salman Ahmed <frenzibyte@gmail.com>
2022-12-25 21:56:22 -08:00
Dean Herbert
09cc41604f
Merge branch 'master' into score-stats-on-results
2022-12-26 13:37:36 +08:00
Joseph Madamba
144144c40c
Revert removing redundant font parameter
2022-12-25 20:47:05 -08:00
Salman Ahmed
ee77b8cad3
Merge branch 'master' into fix-parameters-inspection
2022-12-26 05:17:40 +03:00
Salman Ahmed
2d57ea6f15
Merge branch 'master' into link-title-and-artist
2022-12-26 03:23:05 +03:00
