75266 Commits

This Branch

This Branch

All Branches

• add verify check for video usage
  Hivie · 2025-08-13 20:26:46 +01:00
  e52a4638fe
• add util for getting storyboard video of a difficulty
  Hivie · 2025-08-13 20:26:26 +01:00
  79fcd045b3
• Merge pull request #34644 from smoogipoo/fix-status-icon-colour

  Fix incorrect status colour for DnD users

  Dean Herbert · 2025-08-14 02:44:28 +09:00
  5469357b23
• Merge pull request #34584 from Hiviexd/verify/refactor-verifier-context

  Refactor `BeatmapVerifierContext`

  Dean Herbert · 2025-08-14 02:28:57 +09:00
  75c72b150e
• Fix incorrect status colour for DnD users
  Dan Balasescu · 2025-08-13 19:50:30 +09:00
  47022d23f1
• Clean up ctors

  There were too many of them, and they were a bit twisty for my liking.

  Bartłomiej Dach · 2025-08-13 12:32:17 +02:00
  19f28813a0
• Expand xmldoc
  Bartłomiej Dach · 2025-08-13 12:24:40 +02:00
  076d6df78e
• Simplify multi-valued not-equal enum filter implementation (and cover with tests)
  Bartłomiej Dach · 2025-08-13 11:54:52 +02:00
  0475fe3215
• Limit leaderboard size to sane minimum values
  Salman Alshamrani · 2025-08-13 12:52:08 +03:00
  a3443f76be
• Fix leaderboard not resizing correctly
  Salman Alshamrani · 2025-08-13 12:51:51 +03:00
  d998847271
• Add ability to resize leaderboard in tests
  Salman Alshamrani · 2025-08-13 12:51:09 +03:00
  62803af1de
• Improve xmldoc
  Bartłomiej Dach · 2025-08-13 11:50:35 +02:00
  844704212d
• Remove redundant test
  Bartłomiej Dach · 2025-08-13 11:47:12 +02:00
  bab696f744
• Refactor string filter not-equal implementation to not make my eyes bleed
  Bartłomiej Dach · 2025-08-13 11:45:56 +02:00
  da69cdfa2a
• Fix code quality
  Bartłomiej Dach · 2025-08-13 11:45:24 +02:00
  8be6b1ad20
• Reduce code duplication
  Bartłomiej Dach · 2025-08-13 11:42:26 +02:00
  b356e3bee3
• Fix date range filter being inexplicably implemented a little different than the equality filter

  Why???

  Bartłomiej Dach · 2025-08-13 11:35:38 +02:00
  7a2b032b00
• Fix tests

  - Move them to the correct class. They were exercising filter matching,
    not parsing.
  - Remove a bunch of unreadable tuple stuff that was mostly obfuscating
    the readability without actually improving test coverage.
  - Make tests fail everywhere rather than on CI only. They were failing
    because they were written in a way that was implicitly dependent on
    the local computer's timezone.

  Bartłomiej Dach · 2025-08-13 11:35:05 +02:00
  e31b2c08fd
• Fix FilterCriteria only being able to support one tag filter at once

  Other textual keyword filters also worked like that, wherein if you did
  `artist=a artist=b` the second filter would overwrite the second, but in
  those cases the query is against a single field, so attempting to put
  multiple search criteria in conjunction on a single field is kind of
  nonsensical, so it was sort of fine to do that.
  
  Which is not the case for user tags, which are multi-valued.

  Bartłomiej Dach · 2025-08-13 10:24:54 +02:00
  3fb1880466
• Add failing test coverage for applying multiple concurrent tag filters
  Bartłomiej Dach · 2025-08-13 10:21:23 +02:00
  a8b827782e
• Fix keyword filters potentially being wrongly merged together due to regex wildcard greedy matching

  Because of greedy matching, a filter of
  
      tag="style/clean"! tag="song representation/simple"!
  
  would not parse into 2 separate filters like
  
      (tag, =, "style/clean"!)
      (tag, =, "song representation/simple"!)
  
  but rather a single one like
  
      (tag, =, "style/clean"! tag="song representation/simple"!)
  
  This sort of matches what web did in
  https://github.com/ppy/osu-web/pull/12044, except web does some stuff
  with quote escaping that I'd rather not, and also the search syntax
  seems to slightly deviate because web seems to be using single quotes
  and double quotes to open the value part of the filter. I'm not sure
  what the difference is and I'd rather not go into all that right now.

  Bartłomiej Dach · 2025-08-13 10:21:10 +02:00
  08a0025e31
• Add failing test coverage for parsing multiple concurrent tag filters
  Bartłomiej Dach · 2025-08-13 10:07:50 +02:00
  6ddb2d3305
• Calculate multiplayer room difficulty range based only on non-expired items

  Previously (https://github.com/ppy/osu/pull/34464) this was based on
  room status, but in review of the web-side change it was pointed out
  that even an open room could have no active items
  (https://github.com/ppy/osu-web/pull/12325#pullrequestreview-3082894354).

  Bartłomiej Dach · 2025-08-13 09:32:50 +02:00
  aa88d90eb2
• Adjust test to match expected behaviour
  Bartłomiej Dach · 2025-08-13 09:27:01 +02:00
  447858ee5e
• Fix code quality

  Fix code quality 2
  
  code quality fix 3
  
  Fix code quality 4
  
  Add empty line

  Valerus9 · 2025-08-13 14:59:29 +09:00
  bd90ef1bf4
• Add tests coverage for filters with not equal
  Valerus9 · 2025-08-13 14:59:20 +09:00
  997b8a0bba
• Added FilterMatchTest for InvertRange
  Valerus9 · 2025-08-13 14:59:20 +09:00
  02f835dbc3
• Simplify logic of IsInRange()
  Valerus9 · 2025-08-13 14:59:20 +09:00
  cc970ffd80
• Rename ExludeIfInRange to InvertRange, add xmldox to InvertRange
  Valerus9 · 2025-08-13 14:59:19 +09:00
  3a78cfc627
• Add test coverage
  Valerus9 · 2025-08-13 14:59:19 +09:00
  1a18aac515
• Implement not equal operator

  Added blank lines

  Valerus9 · 2025-08-13 14:59:19 +09:00
  3162478172
• Merge pull request #34625 from peppy/fix-song-select-event-feedback

  Fix selection being finalised immediately on beatmap updates arriving

  Bartłomiej Dach · 2025-08-12 14:57:01 +02:00
  2025.813.0-tachyon 734dea1be4
• Fix failing test
  Bartłomiej Dach · 2025-08-12 14:26:00 +02:00
  0cd4fbb416
• Add rudimentary support of rewinding failed state to health processor

  As indicated in the inline comment this is very best effort, just to
  make the HP bar not very obviously stuck in a very obviously incorrect
  state after the replay is rewound from a failure. There's likely to be a
  bunch of replay accuracy issues related to this, but I'm just making the
  minimum effort to get this to work semi-acceptably for now.

  Bartłomiej Dach · 2025-08-12 14:26:00 +02:00
  30857de55e
• Show indicator in replay player once replay fails

  This indicator allows the player to either rewind to an earlier part of
  the replay, or to proceed to results. It also plays a shortened variant
  of the failure animation SFX.

  Bartłomiej Dach · 2025-08-12 14:25:58 +02:00
  35a472ae39
• Refactor fail management to be more centralised

  Before this commit, there was `AllowFailAnimation` (used by multiplayer)
  and `OnFail()` (used by score submitting implementations of player to
  ensure a failed play submits).
  
  The former is replaced by `PerformFail()` which allows for arbitrary
  operations on failure, which replay player shall leverage in subsequent
  commits. The latter would ideally be replaced by nothing, but it's
  placed in a very awkward place behind a schedule, so by force of
  necessity to avoid code duplication it's replaced by
  `ConcludeFailedScore()` which is overridden to submit the score in all
  submitting players --- except for multiplayer, which is never supposed
  to be calling it, so in that case it just throws an exception.

  Bartłomiej Dach · 2025-08-12 14:18:48 +02:00
  85d48f5df6
• Merge pull request #34592 from Hiviexd/feature/argon-unstable-rate-counter

  Add "Argon" unstable rate counter

  Bartłomiej Dach · 2025-08-12 14:06:39 +02:00
  4bed784a20
• Fix selection being finalised immediately on beatmap updates arriving
  Dean Herbert · 2025-08-12 20:22:37 +09:00
  4c734c2a0e
• Add test coverage of debounce being bypassed when beatmaps are updated
  Dean Herbert · 2025-08-12 20:22:36 +09:00
  bc5ec22dee
• Fix test scene doing very weird things for (seemingly) no reason
  Bartłomiej Dach · 2025-08-12 13:21:16 +02:00
  e3f2ffe19c
• Fix initial alpha not applying correctly

  Also fixes value change callbacks in BDL (very bad) and potential
  lingering initial transforms.

  Bartłomiej Dach · 2025-08-12 13:19:35 +02:00
  6a9064cf44
• Merge pull request #34624 from peppy/song-select-more-reveal-fix

  Fix "reveal background" triggering in one more case it shouldn't

  Bartłomiej Dach · 2025-08-12 13:04:04 +02:00
  9e6d253374
• Merge pull request #34620 from bdach/reduce-redundant-subscription-triggers

  Reduce number of realm subscription triggers from song select online lookups

  Dean Herbert · 2025-08-12 17:40:10 +09:00
  d6a5b964a8
• Fix "reveal background" triggering in one more case it shouldn't

  Closes https://github.com/ppy/osu/issues/34393 again. Hopefully for the
  last time.

  Dean Herbert · 2025-08-12 17:20:35 +09:00
  086cdce94d
• Merge pull request #34619 from peppy/fix-song-select-jumping

  Fix keyboard selection being reset/invalidated more often than required

  Bartłomiej Dach · 2025-08-12 10:20:15 +02:00
  d30c758e69
• Update test coverage
  Salman Alshamrani · 2025-08-12 11:05:53 +03:00
  cd416214f2
• Display calibration button when offset is manually adjusted
  Salman Alshamrani · 2025-08-12 11:05:36 +03:00
  43d10608b4
• Adjust offset text and fix incorrect display in certain scenarios
  Salman Alshamrani · 2025-08-12 11:05:13 +03:00
  9b360e5ea9
• Reduce number of realm subscription triggers from backpopulation of user tags

  Probably partially alleviates https://github.com/ppy/osu/issues/34580.

  Bartłomiej Dach · 2025-08-12 09:53:17 +02:00
  4439bff822
• Reduce number of realm subscription triggers from song select online lookups
  Bartłomiej Dach · 2025-08-12 09:21:00 +02:00
  29b93ca0d7