75266 Commits

This Branch

This Branch

All Branches

• Merge pull request #29163 from Joehuu/copy-lb-mods-daily

  Add ability to copy leaderboard mods in daily challenge

  Bartłomiej Dach · 2024-07-29 12:09:27 +02:00
  cebd38c6eb
• Force exit to main menu when presenting scores from within playlists / multiplayer

  - Closes https://github.com/ppy/osu/issues/29152
  - Partially reverts https://github.com/ppy/osu/pull/29097
  - Reopens https://github.com/ppy/osu/issues/26666
  
  When testing I failed to predict that in multiplayer there can be a
  different beatmap in the playlist queue. If this is the case,
  `PresentScore()` will exit out to `Multiplayer`, whose `RoomSubScreen`
  will update the selected item - and thus, the global beatmap - to the
  next item in queue, at which point trying to play games with "not
  touching the global beatmap bindable if we don't need to" fail to work,
  because the bindable *must* be touched for correct operation, yet it
  cannot (because `OnlinePlayScreen`s disable it).
  
  I'm not sure what the fix is here:
  
  - making replay player somehow independent of the global beatmap?
  - not exiting out to multiplayer, but instead doing the present from the
    results screen itself? if so, then how to ensure the screen stack
    can't overflow to infinity?
  
  so I'm just reverting the broken part. The daily challenge part is left
  in because as is it should not cause issues.

  Bartłomiej Dach · 2024-07-29 12:07:45 +02:00
  9b96bd1d73
• Only create a new drawable object when the background is needed
  jkh675 · 2024-07-29 17:50:23 +08:00
  5ec46a79b4
• Convert into auto-property even more
  Bartłomiej Dach · 2024-07-29 10:59:21 +02:00
  2ff0a89b4f
• Add vague test coverage
  Bartłomiej Dach · 2024-07-29 10:58:05 +02:00
  861b546562
• Convert into auto-property
  Bartłomiej Dach · 2024-07-29 10:40:29 +02:00
  54c904d439
• Merge pull request #29127 from Joehuu/add-negative-horizontal-padding-daily

  Fix daily challenge background clipping when settings/notifications is opened

  Bartłomiej Dach · 2024-07-29 10:28:48 +02:00
  aa7f6f81ef
• Merge pull request #29159 from frenzibyte/fix-daily-challenge-hover

  Fix score breakdown tooltips appearing in other feeds

  Bartłomiej Dach · 2024-07-29 10:14:32 +02:00
  efd1919bfe
• Extract update background method
  jkh675 · 2024-07-29 13:39:08 +08:00
  63757a77a5
• Add back accidentally removed test
  Shreyas Kadambi · 2024-07-28 11:47:00 -04:00
  ae61df0abe
• Add optional 'suffix' to timestamp
  Shreyas Kadambi · 2024-07-28 11:31:36 -04:00
  dec6b190f2
• Add tests for expected timestamp format
  Shreyas Kadambi · 2024-07-28 11:30:42 -04:00
  1c9c3c92fd
• Make the tooltips width be dyanmic with the content, so the long text wont occurs wierd line break
  normalid · 2024-07-28 16:26:18 +08:00
  4e65944609
• Use the TruncatingSpriteText in ModPresetTooltip
  normalid · 2024-07-28 16:18:43 +08:00
  5db0e36404
• Improve unit test
  normalid · 2024-07-28 15:08:36 +08:00
  e58bdbb8a9
• Add ability to copy leaderboard mods in daily challenge
  Joseph Madamba · 2024-07-27 23:55:56 -07:00
  f6eb9037df
• Fix score breakdown tooltips appearing in other feeds
  Salman Ahmed · 2024-07-28 07:22:58 +03:00
  7fedfd368c
• Rename file
  Salman Ahmed · 2024-07-28 06:40:16 +03:00
  82fbd5b045
• Add shadow over tooltip
  Salman Ahmed · 2024-07-28 06:35:00 +03:00
  6bdb1107c1
• Provide colour scheme as part of tooltip data to handle reusing tooltip with different profile hues
  Salman Ahmed · 2024-07-28 06:21:23 +03:00
  31787757ef
• Integrate daily challenge streak display with user profile overlay
  Salman Ahmed · 2024-07-28 05:58:30 +03:00
  e82c54a31c
• Add daily challenge streak display and tooltip
  Salman Ahmed · 2024-07-28 05:58:27 +03:00
  17f5d58be2
• Add API models for daily challenge statistics
  Salman Ahmed · 2024-07-28 05:24:05 +03:00
  0c89210bd7
• Remove unnecessary depth and padding set
  Joseph Madamba · 2024-07-27 19:13:11 -07:00
  bc25e5d706
• Merge remote-tracking branch 'upstream/master' into pr/28991
  Joseph Madamba · 2024-07-27 19:09:02 -07:00
  850bcaef7a
• Remove direct margin set in popover that was causing positioning offset
  Joseph Madamba · 2024-07-27 19:02:57 -07:00
  334f5fda2d
• Remove unnecessary ReceivePositionalInputAt

  Results is not even using the new footer.

  Joseph Madamba · 2024-07-27 19:02:43 -07:00
  04b15d0d38
• Use same size button for everything
  Joseph Madamba · 2024-07-27 18:43:54 -07:00
  b4ca07300a
• Move some properties/bindables around
  Joseph Madamba · 2024-07-27 18:42:49 -07:00
  b5ff2dab43
• Inherit GrayButton instead

  Also fixes hover highlight.

  Joseph Madamba · 2024-07-27 18:42:49 -07:00
  aed2b3c7c6
• Clean up code
  normalid · 2024-07-27 18:55:17 +08:00
  4e44a6e7f8
• FIx code quality
  normalid · 2024-07-27 18:48:45 +08:00
  73a98b45e9
• Implement unit test
  normalid · 2024-07-27 18:24:32 +08:00
  7f4bfb25a9
• replace with ReceivePositionalInputAt
  Caiyi Shyu · 2024-07-27 17:59:38 +08:00
  77d64e0c3d
• Implement chatline background altering
  normalid · 2024-07-27 17:25:44 +08:00
  c2711d0c4e
• fix code quality
  Caiyi Shyu · 2024-07-27 16:24:20 +08:00
  fc842868a9
• Fix panel collapse when hovering dropdown menu
  Caiyi Shyu · 2024-07-27 15:15:14 +08:00
  b97d96fcb0
• Fix daily challenge background clipping when settings/notifications is opened
  Joseph Madamba · 2024-07-26 16:55:15 -07:00
  d55e861b90
• Merge pull request #29097 from bdach/dont-exit-to-menu-when-presenting-score-in-online

  Don't force exit to main menu when presenting scores from within online screens

  Dean Herbert · 2024-07-27 02:46:58 +09:00
  2024.727.0 565107205c
• Merge pull request #29115 from peppy/fix-download-tooltip-text

  Fix "Beatmap not downloaded" tooltip hint not showing in online play

  Dean Herbert · 2024-07-27 02:46:22 +09:00
  f2a38056b1
• Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge
  Dean Herbert · 2024-07-27 02:06:56 +09:00
  9323f89357
• fix TestPreexistingSelection failing
  Caiyi Shyu · 2024-07-26 23:58:52 +08:00
  bd017aea38
• Merge pull request #29112 from peppy/adjust-event-feed

  Adjust weight and text in event feed output

  Bartłomiej Dach · 2024-07-26 17:01:13 +02:00
  834ad3524a
• make code inspector happy
  Caiyi Shyu · 2024-07-26 22:56:07 +08:00
  aed81d9758
• add test for hovering ModCustomisationPanel
  Caiyi Shyu · 2024-07-26 22:45:12 +08:00
  a3576a55c2
• allow hover to expand ModCustomisationPanel
  Caiyi Shyu · 2024-07-26 22:44:50 +08:00
  0cc6818b21
• Reduce number spacing a bit more
  Dean Herbert · 2024-07-26 23:21:44 +09:00
  0421e1e9d0
• Adjust weight and text in event feed output

  Just some minor adjustments.

  Dean Herbert · 2024-07-26 23:20:32 +09:00
  96049807c4
• Merge pull request #29108 from bdach/daily-challenge/better-breakdown

  Improve score breakdown on daily challenge

  Dean Herbert · 2024-07-26 23:12:04 +09:00
  4fa6a19409
• Merge pull request #29101 from bdach/daily-challenge/fix-preview-track

  Fix preview tracks not stopping playback when suspending/exiting daily challenge screen

  Dean Herbert · 2024-07-26 21:52:26 +09:00
  47eca0eb37