48098 Commits

• Fix incorrect formating used for tooltips
  Salman Alshamrani · 2025-07-04 10:44:09 +03:00
  2029404f53
• Adjust carousel sizing to better accommodate to ultra-wide-screen displays

  Roughly matches old song select now at widescreen resolutions. Does not
  change things much at standard 16:9 / 16:10.

  Dean Herbert · 2025-07-04 16:21:57 +09:00
  0715ed5e2e
• Merge pull request #33998 from frenzibyte/adjust-score-tooltip-design

  Adjust score tooltip design slightly

  Dean Herbert · 2025-07-04 16:16:35 +09:00
  99810d4c6c
• Adjust spacing and ordering of data in tooltip
  Dean Herbert · 2025-07-04 15:32:05 +09:00
  ce42a98fd9
• Tint colours to avoid illegible text
  Dean Herbert · 2025-07-04 15:29:22 +09:00
  0c91dedfbb
• Add grouping separator to PP display in user profile overlay
  Salman Alshamrani · 2025-07-04 09:23:57 +03:00
  3263060f2c
• Remove pointless nullable
  Dean Herbert · 2025-07-04 15:21:09 +09:00
  0113961339
• Merge pull request #33997 from peppy/ssv2-background-blur

  Add back background blur support in song select v2

  Bartłomiej Dach · 2025-07-04 07:28:11 +02:00
  5706079d38
• Unblur when revealing background
  Dean Herbert · 2025-07-04 11:59:43 +09:00
  d54fdce5c7
• Merge pull request #33999 from bdach/external-skin-edit-eats-folders

  Fix skins containing subdirectories breaking on external edit on windows

  Dean Herbert · 2025-07-04 11:51:05 +09:00
  cac9844141
• Disallow Classic mod from being valid in freestyle as required mod

  Because it's not implemented for all rulesets.
  
  Closes https://github.com/ppy/osu/issues/34004.

  Bartłomiej Dach · 2025-07-03 14:29:35 +02:00
  6013d4c0de
• Fix skins containing subdirectories breaking on external edit on windows

  Closes https://github.com/ppy/osu/issues/33994.
  
  The reason for the breakage is that `Directory.EnumerateFiles()` used in
  
  	https://github.com/ppy/osu/blob/b1435d35e56eed08a57d1909fa0b16e67bd9c2a2/osu.Game/Skinning/SkinImporter.cs#L63
  
  will use the primary platform directory separator character, which is
  `\` on windows and `/` on unices. The internal realm storage structure
  is expecting paths to be normalised to the unix convention, which is
  evident in
  
  	https://github.com/ppy/osu/blob/b1435d35e56eed08a57d1909fa0b16e67bd9c2a2/osu.Game/Database/RealmArchiveModelImporter.cs#L499
  
  on the write side and in
  
  	https://github.com/ppy/osu/blob/b1435d35e56eed08a57d1909fa0b16e67bd9c2a2/osu.Game/Skinning/RealmBackedResourceStore.cs#L50
  
  on the read side.
  
  Rather than applying this locally to the skin importer I kinda think
  it's better to have this call in `ModelManager` to hopefully avoid
  future footgunnage of this kind.

  Bartłomiej Dach · 2025-07-03 08:16:51 +02:00
  71210bedeb
• Add back background blur support in song select v2

  Looks like shit, but whatever. Defaults to `false` for all new installs
  because it looks stupid.

  Dean Herbert · 2025-07-03 12:45:48 +09:00
  b06fd979fd
• Tint hit result numbers in score tooltip
  Salman Alshamrani · 2025-07-03 06:42:17 +03:00
  fe558b8660
• Add "pp" suffix to PP statistic in score tooltip
  Salman Alshamrani · 2025-07-03 06:42:10 +03:00
  86b25a0b3e
• Fix mania Hard Rock & Easy mods not matching stable

  The implementation in `master` was presuming that Hard Rock and Easy
  worked the same way across all rulesets, but actually, in stable mania,
  the two mods have special treatment as per
  
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L147-L150
  
  The open question here would be what this means for existing scores set
  on lazer using this mod.

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  8e53f47e78
• Support mania-specific hit window quirks

  The quirks in question being that lazer's hit windows in mania preceding
  this change are used in stable *if and only if* Score V2 is active. If
  Score V2 is *not* active, stable has two disparate other sets of hit
  window ranges, dependent on whether the beatmap is a convert or not.
  
  With this commit, those hit windows are used in lazer when the Classic
  mod is active.
  
  Open points for discussion would be:
  
  - What does this mean for plays already set on lazer using the Classic
    mod? Are there even enough of them to care about? Also, on `master`
    the Classic mod does precisely nothing, so maybe such scores should
    just have Classic mod stripped from them?
  
  - What does this mean for the mod multiplier of Classic in mania? (I don't
    expect an answer to this one.)

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  6afdf99df8
• Fix tablet FAQ linked incorrectly and not linked on macOS
  Salman Alshamrani · 2025-07-02 13:24:26 +03:00
  de61f8519c
• Merge pull request #33910 from bdach/dont-do-a-barrel-roll-actually

  Fix Flashlight having increased radius when Barrel Roll is active

  Dean Herbert · 2025-07-02 18:25:45 +09:00
  0e39e05d19
• Add menu tip exposing song select right click scroll behaviour

  Since this is now considered a permanent stay, let's inform users that
  it exists since it's quite useful to know.

  Dean Herbert · 2025-07-02 17:00:04 +09:00
  fe118b4e97
• Merge pull request #33970 from peppy/song-select-v2-default

  Make Song Select v2 the new default

  Bartłomiej Dach · 2025-07-02 09:10:01 +02:00
  e270be6e7a
• Remove comment referencing removed line
  Dean Herbert · 2025-07-02 14:47:22 +09:00
  08a3edcb5c
• Merge pull request #33973 from peppy/song-select-v2-quick-retry-footer-no

  Fix footer appearing at loader screen on quick retries

  Bartłomiej Dach · 2025-07-01 13:59:54 +02:00
  a71cd1339c
• Merge pull request #33972 from peppy/sheared-button-block-mouse

  Make `ShearedButton` block mouse down events

  Bartłomiej Dach · 2025-07-01 13:39:07 +02:00
  579b547a97
• Merge pull request #33971 from peppy/song-select-v2-fix-ducking-overlays

  Change audio ducking at song select v2 to be temporary to avoid conflict with overlays

  Bartłomiej Dach · 2025-07-01 13:30:50 +02:00
  6ecda9d0ed
• Fix potential test deadlock

  Disposal woes.

  Dean Herbert · 2025-07-01 20:19:46 +09:00
  01f5068535
• Fix back button appearing on second quick retry when it shouldn't
  Dean Herbert · 2025-07-01 19:56:52 +09:00
  5b584227a0
• Fix footer appearing at loader screen on quick retries
  Dean Herbert · 2025-07-01 19:56:39 +09:00
  2aca8eecb9
• Also fix leaderboard scores not eating mouse down

  Closes second portion of https://github.com/ppy/osu/issues/33748.

  Dean Herbert · 2025-07-01 19:47:33 +09:00
  5f48124a94
• Make ShearedButton block mouse down events

  Closes https://github.com/ppy/osu/issues/33748.
  
  I (and tests) can't find any regressions from this. One would hope we
  aren't relying on fall-through mouse down anywhere beneath buttons..

  Dean Herbert · 2025-07-01 19:30:47 +09:00
  ed189fecf4
• Add note about LATEST_VERSION cross-project usage
  Dean Herbert · 2025-07-01 19:19:18 +09:00
  68ab89a8f1
• Merge pull request #30226 from smallketchup82/skin-mounting

  Add skin mounting flow

  Dean Herbert · 2025-07-01 19:03:57 +09:00
  64702950e5
• Change audio ducking at song select v2 to be temporary to avoid conflict with overlays

  Closes https://github.com/ppy/osu/issues/33539.

  Dean Herbert · 2025-07-01 18:58:15 +09:00
  142984c07f
• Move external skin edit overlay out of OsuGame
  Bartłomiej Dach · 2025-07-01 11:23:55 +02:00
  2c22158dbd
• Merge pull request #33965 from minetoblend/beat-divisor-control-colors

  Change colour of BeatDivisorControl icons from black to light gray

  Dean Herbert · 2025-07-01 18:20:59 +09:00
  533d49e755
• Merge pull request #33969 from bdach/old-replays-or-something

  Fix very old lazer replays failing to decode

  Dean Herbert · 2025-07-01 18:15:07 +09:00
  c845dd04d3
• Fix footer not showing in first run overlay
  Dean Herbert · 2025-07-01 17:47:39 +09:00
  46dab76eba
• Use OverlayColourProvider for BeatDivisorControl icon colour
  Marvin Schürz · 2025-07-01 10:38:22 +02:00
  709bc9c330
• Remove incorrectly placed ensureGlobalBeatmapValid call

  This is being run in the flow where we are providing a specific beatmap
  for immediately selection. In an edge case scenario, the carousel may be
  pending on a filter operation, which would cause the whole `SelectAndRun`
  call to fail when it doesn't need to.
  
  This is reproduced by multiple test scenes. One example is
  `TestSceneOpenEditorTimestamp.TestErrorNotifications`.

  Dean Herbert · 2025-07-01 17:25:39 +09:00
  94d6260d9b
• Fix mod select not being hidden when CloseAllOverlays is called
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  7fcbda6cd0
• Update existing tests to work with Song Select v2
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  397b9b3994
• Remove Song Select v1 implementation and update auxiliary usages
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  1048bd9ede
• Default to Song Select V2
  Dean Herbert · 2025-07-01 17:25:37 +09:00
  6f10aa5d9c
• Fix very old lazer replays failing to decode

  See
  https://discord.com/channels/188630481301012481/1097318920991559880/1389240665061462047.
  
  I hope this was worth it.

  Bartłomiej Dach · 2025-07-01 10:14:27 +02:00
  654faa553a
• Leave inline comment for posterity
  Bartłomiej Dach · 2025-07-01 09:26:43 +02:00
  6084863aef
• Apply flooring directly rather than flooring and then rounding (down, anyway)

  Just a bit weird. Especially so that the function isn't even generic,
  it's called `defineGroupByStars()`, so flooring locally is 200%
  warranted.

  Bartłomiej Dach · 2025-07-01 09:25:37 +02:00
  87357f8ba4
• Use floored star rating in BeatmapCarouselFilterGrouping and AdvancedStats

  This commit changes BeatmapCarouselFilterGrouping to now use floored star
  rating when determining which group a beatmap belongs to,
  to be consistent with changes introduced here:
  https://github.com/ppy/osu/pull/33679.
  The AdvancedStats section of the original song select is also
  updated to show the floored star rating (rather than rounded).

  Chris Ehmann · 2025-06-30 19:50:11 -07:00
  32d478e19c
• Change icon colour of BeatDivisorControl to be light
  marvin · 2025-06-30 18:43:37 +02:00
  ccc1a7ae6f
• Merge pull request #33962 from bdach/exclude-extended-limits-2

  Fix Difficulty Adjust extended mod icon information not showing with extended limits active

  Bartłomiej Dach · 2025-06-30 14:24:29 +02:00
  0e2090c0bf
• Fix dodgy threading

  The fact that the stuff "just worked" previously due to one load-bearing
  detach in a random location is really scary because a lot of this was
  just not written the way it is supposed to be.

  Bartłomiej Dach · 2025-06-30 14:17:27 +02:00
  2e0e7ff3c2