48098 Commits

• Migrate other usages of GetAdjustedDisplayDifficulty() to use GetBeatmapAttributesForDisplay() instead

  This ensures parity between all beatmap attribute displays that used the
  former method.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  a952e3704e
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Use new ruleset method in song select v2
  Bartłomiej Dach · 2025-07-30 13:43:03 +02:00
  0c7dcfdba3
• Add new ruleset method responsible for displaying beatmap attributes consistently everywhere

  The intention is to use this in every place that wishes to display
  beatmap attributes (and also remove a bunch of local hack-arounds for
  mania, etc.)

  Bartłomiej Dach · 2025-07-30 13:41:19 +02:00
  e2a454ae00
• Adjust stereo shift effects for UI sounds to be less extreme
  Dean Herbert · 2025-07-30 19:35:26 +09:00
  0b11953b24
• Use RealmPopulatingOnlineLookupSource in title wedge

  This sort of guarantees that the wedge displays the latest online status
  of the map.

  Bartłomiej Dach · 2025-07-29 14:07:15 +02:00
  079bba7d3e
• Add population of online status related properties to RealmPopulatingOnlineLookupSource
  Bartłomiej Dach · 2025-07-29 14:06:35 +02:00
  9354aba1f6
• Only perform user tag backpopulation after the local metadata cache updates
  Bartłomiej Dach · 2025-07-29 11:50:41 +02:00
  8307947a10
• Fix localisation oversight
  Dean Herbert · 2025-07-29 17:58:53 +09:00
  3eb34d5de4
• Merge pull request #34418 from peppy/bbcolour

  Add divisor colour for 5,7,9 snaps

  Bartłomiej Dach · 2025-07-29 10:45:53 +02:00
  fb9acb7cd8
• Add test coverage of read-only scenario
  Dean Herbert · 2025-07-29 16:46:07 +09:00
  988f1a4e76
• Merge branch 'master' into NotStirred/master
  Dean Herbert · 2025-07-29 16:36:37 +09:00
  2dde5b1eaf
• Adjust truncation and formatting to feel better
  Dean Herbert · 2025-07-29 15:41:43 +09:00
  898e051501
• Make UserAvatarNotification abstract since it has no actual usage
  Dean Herbert · 2025-07-29 15:02:18 +09:00
  aa4afa8776
• Update design once more
  Salman Alshamrani · 2025-07-29 14:35:25 +09:00
  35a7588c3d
• Update message notification design to match web
  Salman Alshamrani · 2025-07-29 14:35:25 +09:00
  fa7ecc0d28
• Display user avatar in friend presence notifications
  Salman Alshamrani · 2025-07-29 14:35:24 +09:00
  2a7ec60cc8
• Display user avatar and content in DM / mention notifications
  Salman Alshamrani · 2025-07-29 14:35:24 +09:00
  d796dee6fc
• Apply minor refactor to notification classes to be more flexible in usages
  Salman Alshamrani · 2025-07-29 14:35:24 +09:00
  c2ace36348
• Merge branch 'master' into ssv2-localisation
  Dean Herbert · 2025-07-29 13:32:28 +09:00
  fcd966544f
• Add divisor colour for 5,7,9 snaps

  Closes https://github.com/ppy/osu/issues/34385#issuecomment-3117984457.

  Dean Herbert · 2025-07-29 13:30:04 +09:00
  de637f6434
• Fix some issues
  Dean Herbert · 2025-07-29 13:19:43 +09:00
  f8f37f53a7
• Use colour palette for common pink
  Dean Herbert · 2025-07-29 12:46:43 +09:00
  7ea9e87717
• added a space
  vatei · 2025-07-29 02:37:37 +02:00
  f9420d6f15
• change title to torus alternate
  vatei · 2025-07-29 02:28:42 +02:00
  819741ae6f
• update menu tip design
  vatei · 2025-07-29 01:55:56 +02:00
  86d1796bdf
• Localise Sort dropdown
  Denis Titovets · 2025-07-28 20:48:46 +03:00
  6fbb3294fe
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-28 19:12:34 +03:00
  6936533522
• Merge pull request #34410 from bdach/favourite-fail

  Fix song select favourite button getting stuck spinning if operation failed

  Dean Herbert · 2025-07-28 23:14:08 +09:00
  bec0b94af6
• Merge pull request #33871 from dani211e/local-score-sorting-v2

  SSv2: Add ability to sort local scores by metrics other than total score

  Dean Herbert · 2025-07-28 23:12:31 +09:00
  62cace4ab7
• Adjust dropdowns to closer match previous size and display
  Dean Herbert · 2025-07-28 22:35:52 +09:00
  ce05326fe0
• Merge pull request #34303 from Czer0xx/import-all-button

  Add ability to import all files from a directory to import files dialog

  Bartłomiej Dach · 2025-07-28 15:18:03 +02:00
  a5da221b53
• Merge pull request #34371 from Hiviexd/verify/check-almost-concurrent-objects

  Account for almost concurrent case in concurrent objects check

  Bartłomiej Dach · 2025-07-28 15:03:26 +02:00
  34dfb2f9ea
• Merge pull request #34368 from Hiviexd/verify/check-inconsistent-metadata

  Add verify check for inconsistent metadata

  Bartłomiej Dach · 2025-07-28 15:01:37 +02:00
  dfce3f45c9
• apply review
  Hivie · 2025-07-28 12:36:18 +01:00
  e781ad737b
• apply review
  Hivie · 2025-07-28 12:24:24 +01:00
  8466d64c69
• Fix broken layout & use better copy
  Bartłomiej Dach · 2025-07-28 13:03:39 +02:00
  4f1929992f
• Improve condition (and surrounding commentary)
  Bartłomiej Dach · 2025-07-28 12:54:45 +02:00
  33bb060e27
• Merge pull request #34375 from chris-ehmann/fix-beatmap-panel-status

  Change standalone beatmap panel to display status of individual difficulty

  Bartłomiej Dach · 2025-07-28 12:35:52 +02:00
  62c926928a
• Add a comment about a sneaky part of the leaderboard sorting changes
  Bartłomiej Dach · 2025-07-28 11:47:19 +02:00
  a80fecffe7
• Throw another exception better
  Bartłomiej Dach · 2025-07-28 11:38:50 +02:00
  2ffb5cbec5
• Rename {-> Max}Combo sort mode

  I have a feeling this is going to save asses in an indeterminate future.

  Bartłomiej Dach · 2025-07-28 11:38:17 +02:00
  f489ffdfd7
• Move exception in better place (and also throw it better)
  Bartłomiej Dach · 2025-07-28 11:33:59 +02:00
  99f9a3b1f4
• Merge branch 'master' into local-score-sorting-v2
  Bartłomiej Dach · 2025-07-28 11:32:59 +02:00
  c620d58bc2
• Fix song select favourite button getting stuck spinning if operation failed

  Closes https://github.com/ppy/osu/issues/34376
  
  Compare handling with
  
      https://github.com/ppy/osu/blob/0b453772da964dddd2ee73f677367293b26dbf2a/osu.Game/Overlays/BeatmapSet/Buttons/FavouriteButton.cs#L81-L85

  Bartłomiej Dach · 2025-07-28 11:04:56 +02:00
  2ff01abffa
• Merge pull request #34409 from peppy/adjust-panel-flashing

  Adjust panel flashing to feel more in time

  Bartłomiej Dach · 2025-07-28 10:33:26 +02:00
  b94e70bc0b
• Merge pull request #34381 from peppy/bpm-grouping-more-precision

  Change song select grouping to be divided into 10 BPM groups

  Bartłomiej Dach · 2025-07-28 10:32:59 +02:00
  2e8ab15267
• Clear user tags when performing metadata lookup
  Bartłomiej Dach · 2025-07-28 10:29:48 +02:00
  aae16045f6
• Account for BPM rounding in grouping setup
  Dean Herbert · 2025-07-28 16:32:04 +09:00
  996c1e0637
• Merge pull request #34407 from diquoks/add-hits-per-play

  Add `Hits Per Play` statistic to profile overlay

  Bartłomiej Dach · 2025-07-28 09:21:59 +02:00
  197382cc52