202 Commits

• Add "retro" default skin
  clayton · 2025-09-05 21:21:52 +09:00
  6af48975b0
• Write new name to skin.ini when renaming skin via settings

  Reported at https://osu.ppy.sh/comments/3681620, with appropriate levels
  of rage bait (DID ANYONE TEST THIS?!?!?!?!?!?!?!?!?!111!!)
  
  Reasoning for this is that without this, users' skin names can be
  dropped after an external edit because they're never persisted anywhere
  outside of realm.
  
  The only other choice I see is to stop re-populating skin metadata from
  the `.ini` upon completing an external edit, which is very doable but
  seems worse than this. Dunno.

  Bartłomiej Dach · 2025-07-11 15:18:20 +02:00
  db93c2ad6f
• Use better method of disallowing skin changes during external edit
  Bartłomiej Dach · 2025-06-30 14:17:27 +02:00
  b82bf228ab
• Add inline comments for iOS locals
  Dean Herbert · 2024-09-26 16:48:42 +09:00
  89e8baf1d3
• Fix Realm-related iOS crashes by removing object references
  Dan Balasescu · 2024-09-25 16:45:37 +09:00
  3ab04d98f6
• Add basic flow for mounting beatmaps for external editing
  Dean Herbert · 2024-07-10 18:29:51 +09:00
  d3c66e2404
• Fix skin editor freezing game if opened during active gameplay
  Bartłomiej Dach · 2023-10-27 14:34:30 +02:00
  5ad962070c
• Add debug output for skin configuration lookups

  We've struggle with debugging these over the years so I think this was
  worth a couple of hours of work.
  
  Example of osu! lookups:
  
  ```log
  [runtime] 2023-09-06 08:38:30 [verbose]: BeatmapSkinProvidingContainer.GetConfig(lookup: SpinnerFrequencyModulate)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacyBeatmapSkin{ Name: Vickeblanka - Lucky Ending (TV Size) (tears_) [Normal] } } }.GetConfig(lookup: SpinnerFrequencyModulate)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: SpinnerFrequencyModulate)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: SpinnerFrequencyModulate)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: SpinnerFrequencyModulate)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: SpinnerFrequencyModulate) 🟢
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: SpinnerFrequencyModulate)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: SpinnerFrequencyModulate)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: SpinnerFrequencyModulate) 🟢
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: osu.Game.Skinning.ResourceStoreBackedSkin }.GetConfig(lookup: SpinnerFrequencyModulate)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-osu.Game.Skinning.ResourceStoreBackedSkin.GetConfig(lookup: SpinnerFrequencyModulate) 🔴
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: TrianglesSkin{ Name: osu! "triangles" (2017) } }.GetConfig(lookup: SpinnerFrequencyModulate)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-TrianglesSkin{ Name: osu! "triangles" (2017) }.GetConfig(lookup: SpinnerFrequencyModulate) 🔴
  [runtime] 2023-09-06 08:38:30 [verbose]:
  [runtime] 2023-09-06 08:38:30 [verbose]: BeatmapSkinProvidingContainer.GetConfig(lookup: ScorePrefix)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacyBeatmapSkin{ Name: Vickeblanka - Lucky Ending (TV Size) (tears_) [Normal] } } }.GetConfig(lookup: ScorePrefix)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: ScorePrefix)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: ScorePrefix)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: ScorePrefix)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: ScorePrefix) 🟢
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: ScorePrefix)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: ScorePrefix)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: ScorePrefix) 🟢
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: osu.Game.Skinning.ResourceStoreBackedSkin }.GetConfig(lookup: ScorePrefix)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-osu.Game.Skinning.ResourceStoreBackedSkin.GetConfig(lookup: ScorePrefix) 🔴
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: TrianglesSkin{ Name: osu! "triangles" (2017) } }.GetConfig(lookup: ScorePrefix)
  [runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-TrianglesSkin{ Name: osu! "triangles" (2017) }.GetConfig(lookup: ScorePrefix) 🔴
  ```
  
  Example of osu!mania lookups:
  
  ```log
  [runtime] 2023-09-06 08:28:34 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnWidth col:0])
  [runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnWidth col:0])
  [runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4])
  [runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4]) 🔴
  [runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnWidth col:0])
  [runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4])
  [runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4]) 🟢
  [runtime] 2023-09-06 08:28:34 [verbose]:
  [runtime] 2023-09-06 08:28:34 [verbose]: BeatmapSkinProvidingContainer.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
  [runtime] 2023-09-06 08:28:34 [verbose]: |-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacyBeatmapSkin{ Name: antiPLUR - Runengon (Raveille) [Easy] } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
  [runtime] 2023-09-06 08:28:34 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
  [runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
  [runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4])
  [runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4]) 🔴
  [runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
  [runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4])
  [runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4]) 🟢
  [runtime] 2023-09-06 08:28:34 [verbose]:
  
  ```

  Dean Herbert · 2023-09-06 18:03:40 +09:00
  6c95b88589
• Remove usages of [ExcludeFromDynamicCompile]
  Dan Balasescu · 2023-05-08 18:12:56 +09:00
  d2380bd840
• use Live<TModel>

  Use RealmAccess only when needed

  cdwcgt · 2023-04-09 22:21:15 +09:00
  de21b4a2f7
• Merge branch 'master' into export
  cdwcgt · 2023-02-17 22:15:19 +09:00
  e84e011d5d
• Update Save method xmldoc to make more sense
  Dean Herbert · 2023-02-03 15:18:01 +09:00
  9c954a93e3
• Avoid showing skin save message when changing scenes after making no changes
  Dean Herbert · 2023-02-02 18:42:37 +09:00
  015f4f2b38
• Don't use bindables to avoid potential cross-usage contamination
  Dean Herbert · 2023-01-10 01:10:20 +09:00
  811a562608
• Pause imports during active gameplay
  Dean Herbert · 2023-01-09 18:54:11 +09:00
  62ffb4fe78
• Add argon pro skin
  Dean Herbert · 2022-12-20 21:18:51 +09:00
  2f0c772dcb
• Export instead of ExportCurrentSkin
  cdwcgt · 2022-12-15 21:41:15 +09:00
  6ef5b2733f
• Move ImportParameters to better home
  Dean Herbert · 2022-12-13 21:41:26 +09:00
  b8904fe747
• Hook up ImportParameter flow with IModelImporter caller methods
  Dean Herbert · 2022-12-13 21:29:32 +09:00
  cb16d62700
• Convert batchImport parameter to parameters class to allow further import configuration
  Dean Herbert · 2022-12-13 19:55:18 +09:00
  cf2719d4c0
• Group export methods into their respective managers
  cdwcgt · 2022-12-11 18:30:24 +09:00
  e02b8cb199
• Add "Component" prefix to lookup naming
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  1aa0e40f2f
• Rename ISkinComponent to ISkinLookup
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  c908969d9b
• Remove xmldoc on private fields
  Dean Herbert · 2022-09-19 23:16:46 +09:00
  b55aa68177
• Add new default skin "argon"
  Dean Herbert · 2022-09-19 23:16:46 +09:00
  0f7b38f4c3
• Apply more renames
  Dean Herbert · 2022-09-18 18:19:00 +09:00
  d0b8409de5
• Remove "default" prefix from naming
  Dean Herbert · 2022-09-18 00:15:26 +09:00
  41e69fbca6
• Rename references to DefaultSkin to have Triangles suffix
  Dean Herbert · 2022-09-17 23:57:25 +09:00
  51841988bf
• Simplify skin bindable flow

  Now, nothing touches the configuration apart from `OsuGame`, making
  everything else flow better and avoid weird cyclic set bugs.
  
  Closes https://github.com/ppy/osu/issues/20234.

  Dean Herbert · 2022-09-12 19:51:50 +09:00
  f31deaef7c
• Apply IRenderer changes
  Dan Balasescu · 2022-08-02 19:50:57 +09:00
  b4e55f7309
• Add ImportAsUpdate method to IModelImporter to avoid otehr changes
  Dean Herbert · 2022-07-26 15:49:04 +09:00
  8370ca9765
• PostImport -> PresentImport
  Dean Herbert · 2022-06-20 18:36:29 +09:00
  dbae4c6f5a
• Rename Import(TModel) to ImportModel to differentiate from other import methods
  Dean Herbert · 2022-06-20 15:18:07 +09:00
  92f1a2958c
• Remove Import(ArchiveReader) and redirect existing usages to Import(ImportTask)
  Dean Herbert · 2022-06-20 15:14:57 +09:00
  a6c8a832aa
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add back missing notification flow
  Dean Herbert · 2022-06-16 19:48:18 +09:00
  e66ccfd980
• Remove local realm fields in manager classes
  Dean Herbert · 2022-06-16 18:56:53 +09:00
  72c5b9009d
• Remove RealmArchiveModelManager from hierarchy
  Dean Herbert · 2022-06-16 18:53:13 +09:00
  f3984d98e6
• Rename Score/Skin ModelManager classes to Importer for now
  Dean Herbert · 2022-06-16 18:11:50 +09:00
  4d9e3d1982
• Rename lowPriority to batchImport
  Dean Herbert · 2022-06-15 00:46:00 +09:00
  88d5e074a8
• Remove unused Import method in SkinManager
  Dean Herbert · 2022-06-15 00:26:34 +09:00
  7affef75b0
• Remove unused lowPriority flag from one Import method
  Dean Herbert · 2022-06-14 19:52:30 +09:00
  9f599a5ab4
• Tidy up various delegation implementations
  Dean Herbert · 2022-06-14 19:46:59 +09:00
  ca0765a932
• Fix return condition from EnsureMutableSkin not accounting for "failed" imports
  Dean Herbert · 2022-04-29 13:46:18 +09:00
  ee99b94940
• Add return value to EnsureMutableSkin to understand whether a new skin was made
  Dean Herbert · 2022-04-28 14:09:30 +09:00
  aabe586578
• Merge pull request #17596 from peppy/skin-editor-sprites

  Allow importing sprites into a skin via drag-and-drop

  Dan Balasescu · 2022-04-05 17:38:58 +09:00
  2b59f76b2d
• Put ToArray call in correct place in brackets
  Dean Herbert · 2022-04-01 19:30:16 +09:00
  43d03f2825
• Add missing ToArray call

  Not sure where this went, was there in my original commit.

  Dean Herbert · 2022-04-01 16:19:02 +09:00
  01681ee874
• Replace invalidation logic with local realm notification subscription
  Dean Herbert · 2022-04-01 16:01:33 +09:00
  762de3cc97
• Add proof of concept flow to ensure RealmBackedResourceStore is invalidated on realm file changes

  I'm not at all happy with this, but it does work so let's go with it for
  now.

  Dean Herbert · 2022-04-01 16:01:33 +09:00
  9c3dad9fbf