28 Commits

• Write new name to skin.ini when renaming skin via settings

  Reported at https://osu.ppy.sh/comments/3681620, with appropriate levels
  of rage bait (DID ANYONE TEST THIS?!?!?!?!?!?!?!?!?!111!!)
  
  Reasoning for this is that without this, users' skin names can be
  dropped after an external edit because they're never persisted anywhere
  outside of realm.
  
  The only other choice I see is to stop re-populating skin metadata from
  the `.ini` upon completing an external edit, which is very doable but
  seems worse than this. Dunno.

  Bartłomiej Dach · 2025-07-11 15:18:20 +02:00
  db93c2ad6f
• Fix dodgy threading

  The fact that the stuff "just worked" previously due to one load-bearing
  detach in a random location is really scary because a lot of this was
  just not written the way it is supposed to be.

  Bartłomiej Dach · 2025-06-30 14:17:27 +02:00
  2e0e7ff3c2
• Merge branch 'master' into skin-mounting
  Bartłomiej Dach · 2024-12-12 12:16:22 +09:00
  09d55ed306
• Rename SkinInfo when it is changed in skin.ini

  Peppy spoke about using a shortcut and/or hashes to determine if the
  skin.ini is changed, and if so, then to rename the skin.
  
  In my opinion, hashing and doing numerous comparisons is probably less
  efficient than just syncing the SkinInfo's name during the update.
  
  This is an easy solution that does what it needs to.

  smallketchup82 · 2024-12-11 10:19:10 -05:00
  165afe357f
• Apply minor performance rules
  Huo Yaoyuan · 2024-11-28 20:41:44 +08:00
  f5a7716509
• Remove a comment
  smallketchup82 · 2024-10-12 17:15:48 -04:00
  3d16e45d79
• Revert "Add a toggle for checking overwriting"

  This reverts commit b7883f18be.

  smallketchup82 · 2024-10-11 16:15:57 -04:00
  0dc77a70e1
• Add a toggle for checking overwriting

  The GetFile method in AddFile has a huge overhead, given we're doing
  this in a loop.
  
  Since we clear the files in the skin, we already know there won't be any
  existing files, so we can skip all of that logic

  smallketchup82 · 2024-10-11 14:50:48 -04:00
  b7883f18be
• Abstract out logic to SkinImporter
  smallketchup82 · 2024-10-11 14:50:26 -04:00
  a20bd5cc3d
• Fix changes not being applied instantly, Improve import performance, lay down framework for abstracting logic
  smallketchup82 · 2024-10-11 14:50:23 -04:00
  9de248f5d7
• Fix tests failing locally due to not using invariant culture
  Susko3 · 2024-03-27 18:56:26 +01:00
  53900d5472
• Merge branch 'master' into fix-missing-skin-ini-version
  Bartłomiej Dach · 2023-09-27 19:33:43 +02:00
  0b9d01075a
• Fix nullability inspection
  Bartłomiej Dach · 2023-09-27 17:09:42 +02:00
  edf40cc091
• Don't show replay import "missing beatmap" notifications during stable import

  Closes https://github.com/ppy/osu/issues/24926.

  Dean Herbert · 2023-09-27 17:04:43 +09:00
  2481c0b64b
• Fix skin version being incorrectly set to 1.0 when skin is missing skin.ini

  Closes https://github.com/ppy/osu/issues/24939.

  Dean Herbert · 2023-09-27 16:50:03 +09:00
  c44cca2c23
• Bring realm library up-to-date
  Dean Herbert · 2023-07-06 13:37:43 +09:00
  a98a36872e
• Perform check to account for non-ASCII characters
  rozukke · 2023-03-13 22:01:26 +11:00
  1f7721786b
• Change serialisation format of skin layouts to allow more flexibility

  Also adds per-ruleset storage for each container type.

  Dean Herbert · 2023-02-17 14:19:19 +09:00
  6b3652f567
• Update Save method xmldoc to make more sense
  Dean Herbert · 2023-02-03 15:18:01 +09:00
  9c954a93e3
• Avoid showing skin save message when changing scenes after making no changes
  Dean Herbert · 2023-02-02 18:42:37 +09:00
  015f4f2b38
• Fix some more inspections
  Dean Herbert · 2022-12-16 20:21:19 +09:00
  192536643c
• Remove various simple obsoletions
  Dean Herbert · 2022-10-28 13:20:58 +09:00
  42eafe318c
• Ensure skin InstantiationInfo is updated when saving
  Dean Herbert · 2022-09-18 00:12:43 +09:00
  1b475f9360
• Migrate the majority of existing file lookups to use new extension methods
  Dean Herbert · 2022-08-10 16:01:16 +09:00
  ac99c1ad69
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Remove RealmArchiveModelManager from hierarchy
  Dean Herbert · 2022-06-16 18:53:13 +09:00
  f3984d98e6
• Rename Score/Skin ModelManager classes to Importer for now
  Dean Herbert · 2022-06-16 18:11:50 +09:00
  4d9e3d1982