osu-lazer

Merge branch 'master' into song-select-better-debounce

Bartłomiej Dach · 2025-09-03 12:42:21 +02:00

1ba403753c

Better document various debounce constants and split out processing debounce for clarity

Dean Herbert · 2025-09-03 18:55:46 +09:00

6ce76786ed

Simplify beatmap access in carousel panels

Bartłomiej Dach · 2025-09-03 09:52:37 +02:00

315eea8d9a

Introduce new model for "beatmaps under grouping" & allow beatmaps to appear in multiple groups

This bypasses the immediate first issue of not being able to display
multiple instances of a beatmap on the carousel because of model
equality being baked into the structure. It inevitably poses a bunch of
*other* problems, but it's a start.

Bartłomiej Dach · 2025-08-29 13:12:12 +02:00

a84c364e44

Apply in more places

Dean Herbert · 2025-08-27 19:59:44 +09:00

f9c1b24df4

Fix beatmap panels locally handling mod changes unnecessarily

The `BeatmapDifficultyCache` handles mod changes, so handling locally is
unnecessary. By handling locally, it creates a visual issue when
adjusting mods often. Test using Ctrl +/- at song select and observing
that without this change, the star rating will flicker back to the
default due to the local re-fetch.

Dean Herbert · 2025-08-27 18:31:50 +09:00

fda40d7fd5

Use fallback icon if ruleset is not found

Derrick Timmermans · 2025-08-17 16:11:42 +02:00

a1fb7acef3

Refactor song select panel background layout and rendering

Salman Alshamrani · 2025-07-21 05:18:15 +03:00

078b924611

Use padding instead of margin in PanelBeatmap

jyc76 · 2025-06-23 23:49:49 +09:00

96db5677ca

Fix top and bottom spacing of the local rank display

jyc76 · 2025-06-23 23:31:20 +09:00

a9347ff8c3

Increase margin in PanelBeatmap to improve legibility

jyc76 · 2025-06-23 17:24:26 +09:00

cef6445e2b

Store input padding adjustments in CarouselItem to allow more reliable inflation

Dean Herbert · 2025-06-02 19:11:47 +09:00

90b9fb0809

Adjust panel content alignment slightly

Dean Herbert · 2025-05-30 16:48:48 +09:00

9bf111c66a

Inflate padding to left of difficulty icon to make more visually even

Dean Herbert · 2025-05-30 16:33:58 +09:00

6e1a1bb562

Tidy up star difficulty transfer logic

Was going to try and fix the stuttering/glitching when changing mods /
adjusting star rating but it's for another day.

This has no functional change, just code quality.

Dean Herbert · 2025-05-30 14:29:42 +09:00

9721b0a94c

Adjust ruleset icon sizing and padding

Dean Herbert · 2025-05-30 14:29:01 +09:00

53d3817e79

Move local rank out to the left and further fine-tune metrics

Dean Herbert · 2025-05-30 14:29:01 +09:00

31e46ae0d9

Fix back-to-front ordering of elements on PanelBeatmap

Dean Herbert · 2025-05-30 14:29:00 +09:00

afd0f39cc2

Adjust panel x offsets to match user expectations better

Dean Herbert · 2025-05-30 02:20:39 +09:00

02610c5afe

Add triangles to beatmap difficulty panels and move accent layer local

Dean Herbert · 2025-05-30 00:49:29 +09:00

23f2c6d1fe

Also apply realtime colour updates to icon

Dean Herbert · 2025-05-29 20:43:04 +09:00

27ce549606

Use realtime difficulty colouring for other relevant areas

Dean Herbert · 2025-05-29 20:19:54 +09:00

035541bab2

Fix panels flashing white on first display

Dean Herbert · 2025-05-29 20:11:59 +09:00

f9a3c57f03

Standardise metrics and variable naming between PanelBeatmap and PanelBeatmapStandalone

Dean Herbert · 2025-05-29 18:30:46 +09:00

92ed964627

Add hack to avoid spacing being added to flow when local rank is not visible

Dean Herbert · 2025-05-29 18:30:16 +09:00

185f55a7e6

Hook up carousel to song select to global beatmap

Dean Herbert · 2025-05-26 19:32:31 +09:00

c1e1bfde0a

Merge pull request #33256 from peppy/beatmap-title-wedge-fixes

SongSelectV2: Change beatmap title wedge to use debounced difficulty retrieval

Dean Herbert · 2025-05-26 16:12:30 +09:00

5af3921dde

Make BeatmapDifficultyCache's returned bindable non-nullable

Dean Herbert · 2025-05-25 22:27:37 +09:00

6500be3f2d

Add context menus to new carousel panels

This changes the flow of actions (yet again.. sorry) to standardise what
is shown on the beatmap options button in the footer and the context
menus.

This is something I wanted from the start – for devices where right
click is not available, it's always preferable to have a second method
of accessing actions which isn't the context menu.

Collection actions are missing for now, as they will come in a second
pass which includes tidying things up further.

Fix formatting

Duplicate menu items between implementations

Dean Herbert · 2025-05-23 16:02:13 +09:00

891f0c469f

Add animation to star rating display in new carousel

Also matches the animation speed of `StarRatingDisplay` with
`StarCounter` as they are regularly displayed together.

Dean Herbert · 2025-05-19 16:30:58 +09:00

eb29c45513

Aggressively cancel difficulty calculation for new beatmap carousel usages

This was already being done on the old carousel (see `ApplyState`
methods) but wasn't correctly on new carousel.

Importantly, `FreeAfterUse` alone is not enough due to transitions. We
want to immediately stop calculation as soon as a panel is marked
non-visible.

There's no bindable flow for this so it's performed in `Update`. I don't
see this as an issue.

Dean Herbert · 2025-05-19 16:18:54 +09:00

3a532013ac

Add debounce to difficulty calculation operations in churn scenarios

Dean Herbert · 2025-05-19 16:16:33 +09:00

192a1642d4

Define constant for difficulty colour cutoff

Dean Herbert · 2025-04-23 16:57:41 +09:00

3f719125e6

Update song select panel metrics in line with standard specifications and apply minor adjustments

Salman Alshamrani · 2025-04-17 08:21:32 -04:00

9e2a05a1fb

Rename song select v2 classes and namespaces

This aims to bring some conformity to naming to make it easier to
understand component structure for new components.

Renames are pulled out of the song select v2 changes and are more
relevant there due to many new classes being added.

- `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace.
- Related classes have a prefix of the area they are used.
- Experimenting with using partial/nested classes in the song select v2 implementation.
  Not committing to this yet but want to see how it plays out.
- Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.

Dean Herbert · 2025-04-16 18:34:53 +09:00

0aff50fbf5

Stop using padding for panel x offsets

Dean Herbert · 2025-02-28 22:54:00 +09:00

8032b68932

Adjust x offsets to work again for keyboard selection

Dean Herbert · 2025-02-28 16:08:11 +09:00

02b950223c

Fix PanelBeatmapStandalone not handling selection state

Salman Alshamrani · 2025-02-19 10:20:04 -05:00

092d80cf1b

Tidy up remaining common code