14 Commits

• Refactor fail management to be more centralised

  Before this commit, there was `AllowFailAnimation` (used by multiplayer)
  and `OnFail()` (used by score submitting implementations of player to
  ensure a failed play submits).
  
  The former is replaced by `PerformFail()` which allows for arbitrary
  operations on failure, which replay player shall leverage in subsequent
  commits. The latter would ideally be replaced by nothing, but it's
  placed in a very awkward place behind a schedule, so by force of
  necessity to avoid code duplication it's replaced by
  `ConcludeFailedScore()` which is overridden to submit the score in all
  submitting players --- except for multiplayer, which is never supposed
  to be calling it, so in that case it just throws an exception.

  Bartłomiej Dach · 2025-08-12 14:18:48 +02:00
  85d48f5df6
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Add a gameplay configuration flag to disable fail animation
  Dean Herbert · 2024-01-04 17:13:24 +09:00
  0bbc27e380
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Ensure gameplay leaderboard hides with rest of HUD when it should
  Dean Herbert · 2022-09-13 18:45:11 +09:00
  5894d2f0bc
• Add xml docs
  BlauFx · 2022-08-07 13:31:26 +02:00
  bb344e064f
• Improve implementation
  BlauFx · 2022-08-07 13:20:29 +02:00
  09230304a4
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Rename variable to better reflect its purpose
  Dean Herbert · 2021-08-16 16:48:40 +09:00
  8d45f86bd3
• Use PlayerConfiguration to convey no-seek state
  Dean Herbert · 2021-08-16 16:16:02 +09:00
  81480ac4fc
• Move storyboard outro logic to DrawableStoryboard
  Christine Chen · 2021-04-16 00:59:10 -04:00
  b15838b220
• Allow skipping storyboard outro

  Reuses SkipOverlay by calculating the endtime of the storyboard and using that as a "start point". Upon skipping the outro the score is instantly shown.
  When the end of the storyboard is reached the score screen automatically shows up. If the player holds ESC (pause) during the outro, the score is displayed
  
  The storyboard endtime is calculated by getting the latest endtime of the storyboard's elements, or simply returning 0 if there is no storyboard.
  
  Co-Authored-By: Marlina José <marlina@umich.edu>

  Christine Chen · 2021-04-15 13:20:40 -04:00
  25b8c2f257
• Disallow skipping in multiplayer for now
  Dean Herbert · 2020-12-24 16:29:51 +09:00
  6bd6888a93
• Move player constructor configuration to dedicated class; add AllowRestart parameter
  Dean Herbert · 2020-12-23 17:47:46 +09:00
  3c8f871b28