21 Commits

• Merge pull request #32009 from bdach/fix-spectator-list-maybe

  Attempt to fix spectator list showing other users in multiplayer room even if they're not spectating better

  Dan Balasescu · 2025-03-11 13:18:26 +09:00
  e3f2e7d63e
• Actually use the proper list
  Bartłomiej Dach · 2025-03-10 09:47:44 +01:00
  25108beae3
• Use CurrentMatchPlayingUserIds instead of RoomUpdated
  Bartłomiej Dach · 2025-03-10 09:18:49 +01:00
  27ead5a383
• Disable user customisation of spectator list font / colour

  It's all a bit weird so let's just disable it for now. For instance,
  this is exposed as "text" font / colour but only affects the header.
  Also, no other headers are cusotmisable in similar components.

  Dean Herbert · 2025-03-10 15:19:34 +09:00
  3cb32c38ad
• Attempt to fix spectator list showing other users in multiplayer room even if they're not spectating better

  Maybe closes https://github.com/ppy/osu/issues/31972. Not sure. I have
  no reproduction scenario to work with, no solid understanding of how
  the issue can happen, and if this doesn't fix it, then I'm not even
  entirely sure how this can ever be fixed client-side.
  
  The working theory is that not watching updates to the room provoked a
  situation wherein the room was temporarily not in a correct state when
  `WatchingUsers` changed, therefore the collection change callback failed
  to exclude other players in the room from display.
  
  I'm only PRing this because of the `next-release` tag on the issue.

  Bartłomiej Dach · 2025-02-21 11:47:03 +01:00
  fa49b30b5c
• Space out comment
  Dean Herbert · 2025-02-10 21:48:27 +09:00
  310700b4e7
• Fix spectator list showing other users in multiplayer room even if they're not spectating
  Bartłomiej Dach · 2025-02-10 11:17:17 +01:00
  ad642b8425
• Privatise a few members
  Bartłomiej Dach · 2025-02-10 10:41:10 +01:00
  3ba56e009e
• Move bindings to LoadComplete()
  Bartłomiej Dach · 2025-01-21 10:02:16 +01:00
  0265a29000
• Merge spectator list classes into one skinnable
  Bartłomiej Dach · 2025-01-17 11:23:14 +01:00
  3c4bfc0a01
• Add note about the visibility logic because it tripped me up
  Dean Herbert · 2025-01-17 17:14:06 +09:00
  c8b38f05d5
• Playing -> PlayingState
  Dean Herbert · 2025-01-17 17:11:40 +09:00
  f59762f0cb
• Bind to playing state via GameplayState instead to fix more tests
  Bartłomiej Dach · 2025-01-16 15:25:56 +01:00
  5c799d733f
• Merge branch 'spectator-list-visuals' into spectator-list-ready
  Bartłomiej Dach · 2025-01-16 15:13:04 +01:00
  0c54853710
• Fix potential index accounting mistake when creating spectator list with spectators already present

  Noticed by accident, but if the `BindCollectionChanged()` callback fires
  immediately in `LoadComplete()` when set up and there are spectators
  present already, then `NewStartingIndex` in the related event is -1:
  
  	https://github.com/dotnet/runtime/blob/b03f83de362f7168c94daa2f4b192959abefe366/src/libraries/System.ObjectModel/src/System/Collections/Specialized/NotifyCollectionChangedEventArgs.cs#L84-L92
  
  which kinda breaks the math introducing off-by-ones and in result causes
  11 items to be displayed together rather than 10.

  Bartłomiej Dach · 2025-01-16 14:29:41 +01:00
  81f54507dd
• Adjust animations a bit

  Removed autosize duration stuff because it looks weird when the list is
  shown from scratch where users are already fully populated in it.

  Dean Herbert · 2025-01-16 19:23:54 +09:00
  e47244989a
• Add gradient on final spectator if more than list capacity are displayed
  Dean Herbert · 2025-01-16 19:05:19 +09:00
  32906aefde
• Avoid list width changing when spectator count changes
  Dean Herbert · 2025-01-16 19:02:14 +09:00
  996798d2df
• Add a skinnable variant of spectator list & hook it up to online data
  Bartłomiej Dach · 2025-01-15 14:29:53 +01:00
  12b2631e5e
• Add client methods allowing users to be notified of who is watching them
  Bartłomiej Dach · 2025-01-15 14:18:01 +01:00
  43fc48a3f3
• Implement spectator list display

  - First step for https://github.com/ppy/osu/issues/22087
  - Supersedes / closes https://github.com/ppy/osu/pull/22795
  
  Roughly uses design shown in
  https://github.com/ppy/osu/pull/22795#issuecomment-1579936284 with some
  modifications to better fit everything else, and some customisation
  options so it can fit better on other skins.

  Bartłomiej Dach · 2025-01-15 14:17:53 +01:00
  582c5180b9