23 Commits

• Limit leaderboard size to sane minimum values
  Salman Alshamrani · 2025-08-13 12:52:08 +03:00
  a3443f76be
• Fix leaderboard not resizing correctly
  Salman Alshamrani · 2025-08-13 12:51:51 +03:00
  d998847271
• Remove bindable added only for tests
  Dean Herbert · 2025-08-11 21:07:55 +09:00
  e93d15ef0e
• Merge branch 'master' into game-leaderboard-redesign
  Dean Herbert · 2025-08-11 19:20:13 +09:00
  2ff8393603
• Set initial gameplay leaderboard alpha to zero
  Salman Alshamrani · 2025-08-04 09:45:49 +03:00
  4f834532d4
• Add commentary
  Salman Alshamrani · 2025-07-31 04:56:37 +03:00
  fd5e67c34a
• Implement new gameplay leaderboard design
  Salman Alshamrani · 2025-07-23 00:49:46 +03:00
  e172e7f80c
• Rewrite gameplay leaderboard test scene to be usable

  At some point during the leaderboard data refactor, this test scene
  became completely unusable. This change rewrites it to use
  `SoloGameplayLeaderboardProvider` to be able to witness the user score
  being resorted and advancing through the leaderboard.

  Salman Alshamrani · 2025-07-22 23:58:06 +03:00
  84a36b1bfa
• Fix multiplayer spectator leaderboard respecting "show leaderboard" config setting

  Closes https://github.com/ppy/osu/issues/34128
  
  Simplest is best? 🤷

  Bartłomiej Dach · 2025-07-14 09:01:28 +02:00
  0f272ea0f9
• Localise new setting
  Dean Herbert · 2025-06-12 17:30:11 +09:00
  612f853baa
• Combine two similar flags into one
  Dean Herbert · 2025-06-12 17:27:23 +09:00
  ebfc3c9ccf
• Add setting to leaderboard to allow disabling automatic collapsing

  Was a 2 minute implementation, so why not?
  
  Addresses https://github.com/ppy/osu/discussions/33523.

  Dean Herbert · 2025-06-11 17:36:56 +09:00
  04871fe55a
• Disallow placing gameplay leaderboard in skins outside player

  Closes https://github.com/ppy/osu/issues/33542.
  
  For a diff this simple this took much more hemming and hawing because
  things are a bit annoying here from a few angles:
  
  - The only way that is considered idiomatic right now for a skin
    component to not be applicable to a screen is to require a dependency
    from DI that is only provided by applicable screens.
    `DrawableGameplayLeaderboard` has a few of those dependencies, but the
    scope of all the usages makes it so that the only really viable one to
    use here is `IGameplayLeaderboardProvider` itself (see: visual tests,
    and also the usage of multiplayer spectator, where the leaderboard is
    *not* under a player instance).
  
  - The smelly part of this is that the `Player` inheritance hierarchy
    must ensure that *every* non-abstract class has an
    `IGameplayLeaderboardProvider` cached. It is not trivial - if not
    straight up impossible - to force this via some `Player` level
    abstract method, because such a method would need to somehow
    accommodate all possible leaderboard providers. That however also
    means that every possible future `Player` implementor *must inherently
    know* to also cache a leaderboard provider lest it die at runtime. I
    don't love that, but I also don't see better alternatives.
  
  - Speaking of which, I also noticed that solo spectator and playlists
    don't have gameplay leaderboards. At all. Which I don't believe to be
    something that I broke with the leaderboard work - I'm pretty sure
    that was the pre-existing state - however I don't see any reason why
    they *couldn't* receive gameplay leaderboards. I'm not doing that
    here, though, just leaving TODOs for later.

  Bartłomiej Dach · 2025-06-09 13:11:29 +02:00
  6416f59c7b
• Fix back-to-front conditional
  Bartłomiej Dach · 2025-05-07 12:12:25 +02:00
  1fc68a3c48
• Fix gameplay leaderboard not always being expanded in gameplay leaderboard

  I'd have preferred a `get; init;` property but tests were also attached
  at the hip to the public bindable. Without some extra composition this
  is the best that I can do.

  Bartłomiej Dach · 2025-05-07 12:09:26 +02:00
  8cc2af4060
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-05-07 10:45:51 +02:00
  5b61761bbd
• Use actual score positions in gameplay leaderboard

  Intends to close https://github.com/ppy/osu/issues/32859.
  
  The difference between this and https://github.com/ppy/osu/pull/32942 is
  that this PR takes the approach of completely moving the score sorting
  behaviour to `IGameplayLeaderboardProvider` implementations.
  
  This is going to be helpful for further work - to be precise, I am
  looking to add a leaderboard position indicator in the bottom right of
  multiplayer player to match stable, and having the position in the
  provider will make the implementation of that *much* easier.

  Bartłomiej Dach · 2025-04-25 12:40:55 +02:00
  06dc4235f0
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Bring back reading from config value
  Bartłomiej Dach · 2025-04-21 09:15:44 +02:00
  da1fc1013e
• Remove unnecessary interface
  Bartłomiej Dach · 2025-04-18 12:12:21 +02:00
  6d258d4ed5
• Fix incorrect score position treatment if last score on partial leaderboard isn't tracked
  Bartłomiej Dach · 2025-04-18 12:02:02 +02:00
  3ecf56b6f6
• Fix code quality
  Bartłomiej Dach · 2025-04-18 09:09:57 +02:00
  2c690ae94c
• Separate gameplay leaderboard data management from display

  This is a prerequisite for supporting skinning of leaderboards.
  
  - New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
    interfaces are introduced. They are strictly concerned with supplying
    leaderboard data.
  
  - Logic of managing display, which was previously jammed into the
    inheritance hierarchy of `GameplayLeaderboard`, is now moved into
    `IGameplayLeaderboardProvider` implementations. Solo play,
    multiplayer, and multiplayer spectator get their own implementation of
    the interface.
  
  - The inheritance hierarchy of `GameplayLeaderboard` and per-player
    overriding of the implementation of the gameplay leaderboard is gone.
    Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
    allowed to display the leaderboards, across all modes of play.

  Bartłomiej Dach · 2025-04-16 14:46:55 +02:00
  c231571f06