8 Commits

• Make Room.Playlist non-bindable
  Dan Balasescu · 2024-11-15 15:51:01 +09:00
  34c0f72dd6
• Fix crash on calculating playlist duration when rate-changing mods are present

  Regressed in https://github.com/ppy/osu/pull/28399.
  
  To reproduce, enter a playlist that has an item with a rate-changing mod
  (rather than create it yourself).
  
  This is happening because `APIRuleset` has `CreateInstance()`
  unimplemented:
  
      https://github.com/ppy/osu/blob/b4cefe0cc2fda0ab4b5af6138ee158bd32262f9a/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs#L159
  
  and only triggers when the playlist items in question originate from
  web.
  
  This is why it is bad to have interface implementations throw outside of
  maybe mock implementations for tests. `CreateInstance()` is a scourge
  elsewhere in general, we need way less of it in the codebase (because
  while convenient, it's also problematic to implement in online contexts,
  and also expensive because reflection).

  Bartłomiej Dach · 2024-06-25 11:28:10 +02:00
  0d2a47167c
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Re-namespace all files in OnlinePlay directory
  Bartłomiej Dach · 2020-12-25 16:50:09 +01:00
  83fb7c7a1a
• Rename Multi directory to OnlinePlay
  Bartłomiej Dach · 2020-12-25 16:50:02 +01:00
  e797e5ce7a