544 Commits

• Resolve IBindable<WorkingBeatmap> via DI in EditorBackgroundScreen
  Chris Ehmann · 2025-07-21 20:58:09 -07:00
  aeb1941cf9
• Fix editor background not updating in certain scenarios
  Chris Ehmann · 2025-07-18 20:55:45 -07:00
  dd09a2487e
• Improve reliability of unapplying speed adjustment on exiting editor

  Probably closes https://github.com/ppy/osu/issues/33230.
  
  I say "probably" because I couldn't reproduce this myself using the
  scenario provided in the issue but looking at the code involved I can
  see why it would happen. Long and short of it is that the speed
  adjustment cleanup code was much too reliant on disposal executing
  quickly, which as we've learned on several occasions before, cannot be
  relied upon.

  Bartłomiej Dach · 2025-05-22 09:28:47 +02:00
  b7c695b47c
• Change "Delete Difficulty" editor menu item type to destructive
  schiavoanto · 2025-04-19 09:00:53 +02:00
  d1f7afc8ed
• Avoid saving a state when clearly not dirty
  Dean Herbert · 2025-04-07 19:37:26 +09:00
  3738d75202
• Move to file menu
  Dean Herbert · 2025-03-06 19:34:20 +09:00
  d9b7d034ba
• Use localisation
  Dean Herbert · 2025-03-06 18:51:32 +09:00
  64830e2c31
• Add "discard unsaved changes" operation to beatmap editor

  Apparently useful in modding workflows when you want to test out a few
  different variants of a thing.
  
  Re-uses `Ctrl-L` binding from stable. Some folks may argue that the
  dialog makes the hotkey pointless, but I really do want to protect
  users from accidental data loss, and also if you want to power through
  it quickly, you can hit the 1 key when the dialog shows, which will
  bypass the hold-to-activate period (which wasn't intentional, but so
  many people want a bypass at this point that we're probably keeping that
  behaviour for power users).

  Bartłomiej Dach · 2025-03-05 14:34:44 +01:00
  3f461c0734
• Merge branch 'master' into bss/the-actual-submission
  Bartłomiej Dach · 2025-02-13 08:45:23 +01:00
  de9362dae5
• Reword copy to be less verbose
  Bartłomiej Dach · 2025-02-11 08:06:12 +01:00
  daf0130b23
• Add menu items to open beatmap info & discussion pages in browser from editor
  Bartłomiej Dach · 2025-02-10 12:47:38 +01:00
  38e2f793ca
• Merge branch 'master' into bss/the-actual-submission
  Dean Herbert · 2025-02-07 17:44:48 +09:00
  6335228fb0
• Merge branch 'bss/api-setup' into bss/the-actual-submission
  Bartłomiej Dach · 2025-02-06 08:38:08 +01:00
  070d402ac2
• Improve bookmark controls

  - Bookmark menu items get disabled when they would do nothing.
  - Bookmark deletion only deletes the closest bookmark instead of all of
    them within the proximity of 2 seconds to current clock time. Action
    is only however *enabled* within 2 seconds of a bookmark.
  
  Additionally, logic was moved out of `Editor` because it's a huge class
  and I dislike huge classes if they can be at all avoided.

  Bartłomiej Dach · 2025-02-05 15:28:27 +01:00
  abce42b1c8
• Add beatmap submission support
  Bartłomiej Dach · 2025-02-05 14:01:37 +01:00
  78e85dc2c7
• Merge branch 'master' into pr
  NecoDev · 2025-02-05 14:53:20 +08:00
  13fa49d5b5
• Removed unused using

  For https://github.com/ppy/osu/pull/31780

  NecoDev · 2025-02-05 13:31:57 +08:00
  db7b665f4d
• Added warning
  NecoDev · 2025-02-03 16:47:38 +08:00
  55f46e3b66
• Make distance snap settings mutually exclusive
  Dean Herbert · 2025-02-03 17:34:55 +09:00
  26a8fb6984
• Merge branch 'master' into editor-storyboard-display-2
  Bartłomiej Dach · 2025-01-08 15:46:08 +01:00
  bcd35c8899
• Re-route editor tempo adjustment via EditorClock and remove it on gameplay test
  Bartłomiej Dach · 2025-01-07 11:25:00 +01:00
  a5036cd092
• Rename method
  Bartłomiej Dach · 2024-12-31 14:09:36 +01:00
  1803ee4025
• Display storyboard in editor background

  Fixes the main part of https://github.com/ppy/osu/issues/31144.
  Support for selecting a video will come later.
  
  Making this work was an absolutely awful time full of dealing with
  delightfully kooky issues, and yielded in a very weird-shaped
  contraption. There is at least one issue remaining wherein storyboard
  videos do not actually display until the track is started in editor, but
  that is 99% a framework issue and I do not currently have the mental
  fortitude to diagnose further.

  Bartłomiej Dach · 2024-12-31 13:57:50 +01:00
  21dba621f0
• Pause playback when entering gameplay test from editor

  Closes https://github.com/ppy/osu/issues/31290.
  
  Tend to agree that this is a good idea for gameplay test at least. Not
  sure about other similar interactions like exiting - I don't think it
  matters what's done in those cases, because for exiting timing is in no
  way key, so I just applied this locally to gameplay test.

  Bartłomiej Dach · 2024-12-27 09:08:16 +01:00
  5abad07412
• Merge branch 'master' into ios-beatmap-export
  Dean Herbert · 2024-12-10 23:59:15 -08:00
  2a4f596f90
• Enable exporting beatmaps in iOS
  Salman Alshamrani · 2024-12-09 07:47:28 -05:00
  e9868c6318
• Implement basic bookmark support in editor
  Bartłomiej Dach · 2024-12-03 15:14:22 +01:00
  d60b7f4798
• Make editor make sense
  Salman Alshamrani · 2024-11-28 17:43:32 -05:00
  932afcde01
• Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2024-11-26 16:52:39 -05:00
  3e1b4f4ac5
• Move setting back to timing panel
  Bartłomiej Dach · 2024-11-11 10:08:26 +01:00
  c37e4877e2
• Move setting to user config
  Bartłomiej Dach · 2024-11-11 09:57:17 +01:00
  0cddb93dda
• Merge branch 'master' into move-already-placed-objects-when-adjusting-offset-bpm
  Bartłomiej Dach · 2024-11-11 09:50:00 +01:00
  a6cdf6df07
• Add ability to hide breaks from timeline

  This was another IRL request from a mapper / team member. The rationale
  here is that it can be very annoying to map with break time enabled if
  you have a large gap in the beatmap you are trying to fill with
  hitobjects, as you are placing objects on top of a very gray area.

  Dean Herbert · 2024-11-05 12:56:19 +09:00
  9d65d394d3
• Merge pull request #30387 from peppy/editor-sidebars-always-expanded

  Keep editor sidebars expanded by default

  Bartłomiej Dach · 2024-10-25 19:46:35 +02:00
  b72a50bbaa
• Merge branch 'master' into move-already-placed-objects-when-adjusting-offset-bpm
  Dean Herbert · 2024-10-23 18:20:43 +09:00
  cb880f7e9b
• Keep editor sidebars expanded by default

  They will not only contract if the user chooses to have them contract
  (new setting in the `View` menu) or if the game isn't wide enough to
  allow full interaction with the playfield while they are expanded.
  
  Addressess https://github.com/ppy/osu/discussions/28970.

  Dean Herbert · 2024-10-22 20:08:50 +09:00
  e37d415c6f
• Refactor code to read better (and adjust lenience to match stable)
  Dean Herbert · 2024-10-22 18:08:25 +09:00
  16bc188ba7
• attempt to fix formatting
  TaterToes · 2024-10-18 07:21:05 -04:00
  1cc6309656
• cleanup
  TaterToes · 2024-10-17 18:41:00 -04:00
  0a8ba4bfb5
• fix comment
  TaterToes · 2024-10-17 18:12:05 -04:00
  c8b0220934
• adjust margin time and apply rate adjust
  TaterToes · 2024-10-17 18:10:48 -04:00
  e10293531b
• Forgot subtraction
  TaterToes · 2024-10-17 17:01:42 -04:00
  45dd9b1167
• fix seeking back on control points
  TaterToes · 2024-10-17 16:26:13 -04:00
  3fe0791298
• Merge pull request #29860 from bdach/fix-nudging

  Only allow seek to next/previous object via keybinding if there is no selection

  Dean Herbert · 2024-10-07 15:36:19 +09:00
  5c826be652
• Only allow seek to next/previous object via keybinding if there is no selection
  Bartłomiej Dach · 2024-09-13 15:14:09 +02:00
  7f71ef4547
• Add hotkey hints to editor menus
  Bartłomiej Dach · 2024-09-04 12:16:54 +02:00
  130802e480
• Merge branch 'master' into move-already-placed-objects-when-adjusting-offset-bpm
  Bartłomiej Dach · 2024-09-02 09:21:42 +02:00
  d5ef32e46b
• fix difference in sample time calculation
  OliBomby · 2024-08-27 19:02:40 +02:00
  71044a0766
• move public member to top of file
  OliBomby · 2024-08-22 19:18:38 +02:00
  adbdb39e9f
• allow repeating on seek actions
  OliBomby · 2024-08-22 19:15:53 +02:00
  0db068e423