3627 Commits

• Merge pull request #34910 from CloneWith/update/drawable-date

  Make DrawableDate formatting localizable

  Bartłomiej Dach · 2025-09-10 09:54:50 +02:00
  4d76c467f8
• Change ToString() override to match pre-existing conventions
  Bartłomiej Dach · 2025-09-10 15:34:18 +09:00
  6660406ee9
• Change class name

  I suggested it myself but on revisiting it's a bit of a mouthful.

  Bartłomiej Dach · 2025-09-10 15:33:46 +09:00
  482b7b6d3f
• Add HumanisedLocalisableDate for l10n
  CloneWith · 2025-09-10 07:48:09 +08:00
  b3abd09517
• Fix sheared dropdown click sound area
  Joseph Madamba · 2025-09-07 11:00:26 -07:00
  c2bc67d083
• Make DrawableDate formatting localizable
  CloneWith · 2025-09-04 14:44:40 +08:00
  1c608e779d
• Hide object-typed CurrentSelection and expose strongly-typed alternatives instead
  Bartłomiej Dach · 2025-09-03 10:24:25 +02:00
  4a7ee6fafc
• Allow BeatmapCarousel.CurrentSelection to accept raw BeatmapInfos (and redirect to appropriate grouped beatmap)

  This is probably where things get a little controversial.
  
  There are some song select flows wherein song select just wants to
  ensure sanity by authoritatively setting the global beatmap. The goal is
  to change the beatmap immediately and instantly. Therefore it should
  kind of be the carousel's job to figure out its grouping complications.
  
  To that end, `CurrentSelection` is made virtual, and overridden in
  `BeatmapCarousel` to perform a sort of reconciliation logic. If an
  external component sets `CurrentSelection` to a `BeatmapInfo`, one of
  the two following things happen:
  
  - Nothing, if the current `GroupedBeatmap` is already a copy of the
    beatmap that needs to be selected, or
  
  - The carousel looks at its items, finds any first copy which matches
    the beatmap that the external consumer wanted selected, and changes
    selection to that instead.

  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  dfed564bda
• Fix beatmap carousel re-filtering when it doesn't need to

  Local rules ensure we only handle callbacks when we need to.

  Dean Herbert · 2025-08-27 18:21:19 +09:00
  be6fb9aa77
• Add test coverage ensuring filtering does not occur on unnecessary updates
  Dean Herbert · 2025-08-27 18:13:12 +09:00
  043235fed2
• Add and use new mod icon assets
  Bartłomiej Dach · 2025-08-21 09:00:44 +02:00
  92016a7d9b
• Fix "reveal background" triggering in one more case it shouldn't

  Closes https://github.com/ppy/osu/issues/34393 again. Hopefully for the
  last time.

  Dean Herbert · 2025-08-12 17:20:35 +09:00
  086cdce94d
• Fix keyboard selection being reset/invalidated more often than required
  Dean Herbert · 2025-08-12 16:02:03 +09:00
  71d8873cb3
• Provide BeatmapItemsCount in all filters to ensure we always use correct value
  Dean Herbert · 2025-08-07 18:15:52 +09:00
  eed88d7c9b
• Remove outdated comment
  Dean Herbert · 2025-08-07 18:15:37 +09:00
  dc4fb86e8b
• Merge pull request #34491 from peppy/wedge-background-click-block

  Fix clicks propagating through personal best score area

  Bartłomiej Dach · 2025-08-04 12:56:40 +02:00
  3bfe2581a4
• Merge pull request #34498 from peppy/sort-mode-dropdown-always-show

  Always show "sort" dropdown but disable in cases it doesn't (yet) work

  Bartłomiej Dach · 2025-08-04 10:56:54 +02:00
  d72cb6e602
• Fix context menu not working due to too much blocking
  Dean Herbert · 2025-08-04 17:52:27 +09:00
  3557207609
• Always show "sort" dropdown but disable in cases it doesn't (yet) work

  Avoids UI components shifting around, breaking muscle memory.
  
  - Addresses #34443.
  - Closes #34415.
  - Supersedes and closes https://github.com/ppy/osu/pull/34446.

  Dean Herbert · 2025-08-04 15:51:42 +09:00
  82b9a4f449
• Don't require pixel precision to expand editor toolboxes

  I don't think this takes away from usability and it's the easiest
  solution to fix an actual issue.
  
  Closes https://github.com/ppy/osu/issues/34471.

  Dean Herbert · 2025-08-04 13:41:55 +09:00
  ca97d7bf6c
• Expand scrollbar input area for song select carousel
  Dean Herbert · 2025-07-25 17:24:26 +09:00
  b63ba67921
• Fix text flow arbitrary drawable wrapper accessing child in an unsafe manner

  Closes https://github.com/ppy/osu/issues/34126.
  
  I'm not really sure how that issue could have ever happened to begin
  with but I can see a way to make it hopefully safer. If it fails again
  then it's clearly goblins.

  Bartłomiej Dach · 2025-07-11 15:19:45 +02:00
  449b6d36ae
• Ensure adjacent selection when currently selected beatmap(set) is deleted
  Dean Herbert · 2025-07-10 17:46:09 +09:00
  994bd4abfe
• Tweak SSv2 navigation sfx
  Jamie Taylor · 2025-07-05 02:01:22 +09:00
  567d09209b
• Merge pull request #33970 from peppy/song-select-v2-default

  Make Song Select v2 the new default

  Bartłomiej Dach · 2025-07-02 09:10:01 +02:00
  e270be6e7a
• Make ShearedButton block mouse down events

  Closes https://github.com/ppy/osu/issues/33748.
  
  I (and tests) can't find any regressions from this. One would hope we
  aren't relying on fall-through mouse down anywhere beneath buttons..

  Dean Herbert · 2025-07-01 19:30:47 +09:00
  ed189fecf4
• Update existing tests to work with Song Select v2
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  397b9b3994
• Fix player settings no longer collapsing correctly

  Regressed with https://github.com/ppy/osu/pull/33621 for obvious
  reasons. Tachyon doing its job, caught this before hitting a proper
  release.

  Dean Herbert · 2025-06-30 16:57:51 +09:00
  d1c0d58f2e
• Merge branch 'master' into somewhat-less-weird-toolbar
  Bartłomiej Dach · 2025-06-24 14:16:00 +02:00
  7bea51556c
• Fix dropdown search bar not having placeholder text
  Salman Alshamrani · 2025-06-24 09:10:13 +03:00
  3599269cba
• Update group traversal logic to use new debouncing flow
  Dean Herbert · 2025-06-20 18:08:30 +09:00
  131b3f622e
• Merge branch 'master' into fix-another-case-of-keyboard-weird
  Dean Herbert · 2025-06-20 02:16:54 +09:00
  0e34752e5f
• Merge pull request #33668 from peppy/ssv2-group-key-bindings
  Bartłomiej Dach · 2025-06-19 17:35:28 +02:00
  267a6a0ac7
• Remove unused second parameter
  Dean Herbert · 2025-06-19 23:52:11 +09:00
  116463e30d
• Remove noisy carousel logging

  Served its purpose, no longer required.

  Dean Herbert · 2025-06-19 18:44:22 +09:00
  cb90dee3e8
• SongSelectV2: Fix pressing multiple traversal keys in same frame causing weirdness

  Closes #33453.

  Dean Herbert · 2025-06-19 18:30:57 +09:00
  6350e6d1a7
• Refactor group deselection logic to avoid adding complexity to traverseSelection
  Dean Herbert · 2025-06-19 17:49:11 +09:00
  10132f19aa
• Adjust some button's hover colours to improve visual contrast with text

  Addresses https://github.com/ppy/osu/discussions/33722.

  Dean Herbert · 2025-06-18 14:27:26 +09:00
  f48cfa7ef6
• Fix group toggle not working as expected anymore
  Dean Herbert · 2025-06-17 23:15:17 +09:00
  b74db44fde
• Fix group selection acting weirdly when only one group is present
  Dean Herbert · 2025-06-17 22:39:51 +09:00
  27d4ad7991
• Fix incorect masking when displayed at small sizes
  Dean Herbert · 2025-06-16 19:50:12 +09:00
  42e7a69db6
• Fix failing test
  Dean Herbert · 2025-06-16 19:39:37 +09:00
  13df477fc0
• Visual pass on loading spinner

  Fixes regression mentioned
  [here](https://github.com/ppy/osu/pull/33509#issuecomment-2951271131).
  
  Adjust visuals and metrics slightly.

  Dean Herbert · 2025-06-16 15:47:57 +09:00
  c888431201
• Add localisation support to difficulty range slider
  Salman Alshamrani · 2025-06-14 15:05:05 +03:00
  977c26d02f
• Add support for toggling current group expansion using shift-enter

  Closes https://github.com/ppy/osu/issues/33617.

  Dean Herbert · 2025-06-12 20:36:02 +09:00
  52ba22ca1f
• Add support for traversing between groups using shift-left/right

  Closes https://github.com/ppy/osu/issues/33599.

  Dean Herbert · 2025-06-12 20:36:02 +09:00
  3816c5d95f
• Merge pull request #33660 from peppy/more-robust-logo-operations

  Use `IDisposable` flow for common logo tracking/proxy operations for better robustness

  Bartłomiej Dach · 2025-06-12 12:03:17 +02:00
  e258244caf
• Delete redundant string interpolation
  Bartłomiej Dach · 2025-06-12 11:10:43 +02:00
  ee696e32f0
• Always return previous tracking state before taking out a new tracking operation
  Dean Herbert · 2025-06-12 17:13:35 +09:00
  7cdc296c9c
• Remove leftover xmldoc
  Bartłomiej Dach · 2025-06-12 09:32:53 +02:00
  8c0e535d41