26 Commits

• Fix copy-paste fail in log message
  Bartłomiej Dach · 2025-08-25 13:43:03 +02:00
  a2bf8e3988
• Fix submission & rank date failing every launch for some users

  Addresses https://github.com/ppy/osu/discussions/34705, I suppose.
  
  The cagey tone of that statement is because this change merely papers
  over the issue. The issue in question for the user that reported this is
  that they have a bunch of very old beatmaps, whose md5 hashes do not
  match the online hashes, that need updating. The submission/rank date
  population was running every single time for these, and failing every
  time, because there is really not much useful that the lookup *can* do.
  
  Because mappers have made `OnlineID` essentially useless for determining
  the provenance of a beatmap due to reusing them to "fix" beatmap
  submission failures, online IDs have been explicitly disallowed from use
  in any sort of beatmap lookup flow. The only things that are allowed to
  be used are: md5 of the beatmap, and filename as a fallback for very old
  beatmaps / beatmap packs.
  
  If the user has local beatmaps with md5 not matching online, chances are
  that any metadata lookups are likely to fail or return bogus data. At
  that point my personal feeling is that backpopulation flows should leave
  such beatmaps well alone and the user should just go update the beatmap
  themselves.
  
  I am aware that updating 124 individual beatmap sets would - in the
  current state of things - would probably be a ridiculously onerous thing
  to do, and that people have been asking multiple times for a facility to
  update all local beatmaps at once, but that discussion is out of scope
  at this stage.

  Bartłomiej Dach · 2025-08-20 09:21:35 +02:00
  c894969d17
• Reduce number of realm subscription triggers from backpopulation of user tags

  Probably partially alleviates https://github.com/ppy/osu/issues/34580.

  Bartłomiej Dach · 2025-08-12 09:53:17 +02:00
  4439bff822
• Fix metadata cache version queries failing hard if the image is corrupted

  This was not fatal but with this change it should recover in a slightly
  better way.
  
  Also incidentally fixes the cache refetch potentially being attempted
  twice by each of the two background population tasks that use it.

  Bartłomiej Dach · 2025-08-07 11:10:02 +02:00
  dac643121a
• Update inline comment
  Bartłomiej Dach · 2025-07-30 14:27:35 +02:00
  d4794dbc9a
• Apply code review suggestion
  Bartłomiej Dach · 2025-07-30 14:20:13 +02:00
  d49c924709
• Only perform user tag backpopulation after the local metadata cache updates
  Bartłomiej Dach · 2025-07-29 11:50:41 +02:00
  8307947a10
• Add back-population operation for user tags
  Bartłomiej Dach · 2025-07-23 10:35:32 +02:00
  1709811458
• Pull actual diffcalc out of realm transaction
  Bartłomiej Dach · 2025-03-10 10:36:19 +01:00
  6b1472b070
• Cache ruleset instance to avoid instantiation per beatmap processed
  Dean Herbert · 2025-03-10 17:17:45 +09:00
  7ca9d8392d
• Ensure that star rating reprocessing does not incur online lookup requests

  Yesterday after the lazer release there was a bit of a spike in the
  number of osu-web requests pointed at `/api/v2/beatmaps/lookup`
  specifically. The most likely reason for this is that prior to this
  commit, the star rating recalculation was fully performed by the
  `BeatmapUpdater.Process()` flow.
  
  This process does full metadata lookups, and while it *will* attempt
  to use the local `online.db` metadata cache, it *will* also fall back to
  API requests if the local metadata fetch fails. While that means that
  the local cache likely saved us from a doomsday scenario here, it *also*
  is the case that all of that metadata lookup stuff is *entirely
  unnecessary* when wanting to just update star ratings.
  
  Therefore, this splits out only the part relevant to star ratings
  as a separate background process, so that it can run completely
  locally.

  Bartłomiej Dach · 2025-03-07 10:48:29 +01:00
  12fa96de25
• Fix tests not working by forgoing beatmap updates
  Dan Balasescu · 2024-11-07 17:26:10 +09:00
  bd630c189e
• Rename enum to non-plural now that it won't conflict
  Dean Herbert · 2024-10-01 19:55:46 +09:00
  8773c34fdd
• Adjust ILocalUserPlayInfo to expose whether gameplay is in a paused/break state
  Dean Herbert · 2024-10-01 17:53:46 +09:00
  ad3007eaad
• Change log output to only output when matches are found (in line with other methods)
  Dean Herbert · 2024-09-14 02:19:52 +09:00
  562a5006ea
• Backpopulate missing ranked/submitted dates using new local metadata cache

  People keep asking why https://github.com/ppy/osu/pull/29553 didn't fix
  their databases (as stated in the PR, it didn't intend to), so this
  should do it for them.

  Bartłomiej Dach · 2024-09-13 16:00:49 +02:00
  a4f6d4a300
• Fix rank upgrade path upgrading scores that failed background reprocessing earlier
  Bartłomiej Dach · 2024-07-16 14:04:51 +02:00
  7ba1f142e5
• Merge pull request #27866 from Joehuu/fix-online-score-export

  Fix replay export not working correctly from online leaderboards

  Bartłomiej Dach · 2024-04-23 09:08:04 +02:00
  12acdeebf1
• Stop background processing from running when inside a high performance session
  Dean Herbert · 2024-04-16 10:04:38 +08:00
  a651cb8d50
• Enable NRT to ScoreManager
  Joseph Madamba · 2024-04-14 15:53:29 -07:00
  f282152f99
• Inline last version which touched ranks when checking for upgrade
  Bartłomiej Dach · 2024-02-24 13:55:44 +01:00
  f6ceedc7a6
• Do not reprocess ranks for custom rulesets

  Chances are that because we've broken rank API, it would utterly fail
  for all custom rulesets anyhow.

  Bartłomiej Dach · 2024-01-23 12:59:36 +01:00
  6c169e3156
• Fix rank background processing not working (and not bumping score version)
  Bartłomiej Dach · 2024-01-22 21:34:28 +01:00
  fdd499a485
• Unify legacy total score / accuracy / rank recomputation flows
  Bartłomiej Dach · 2024-01-22 20:52:51 +01:00
  db4849442e
• Add migration
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  644e7d6fe6
• Move BackgroundDataStoreProcessor to better namespace
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  4eba3b5d70