550 Commits

• Download online beatmap / present local beatmap on shift-clicking beatmap cards

  Closes https://github.com/ppy/osu/issues/34883.

  Bartłomiej Dach · 2025-09-02 13:11:18 +02:00
  6c82f543e6
• Rename property to reduce confusion

  Caused an actual bug in one of the replaced usages.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  cd2c5075df
• Migrate other usages of GetAdjustedDisplayDifficulty() to use GetBeatmapAttributesForDisplay() instead

  This ensures parity between all beatmap attribute displays that used the
  former method.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  a952e3704e
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Merge pull request #34306 from EYHN/eyhn/fix/beatmap-set-cover-load

  Fix beatmap set cover not loading at screen edges

  Dean Herbert · 2025-07-21 14:49:02 +09:00
  6f0111583d
• Fix beatmap set cover not loading at screen edges
  eyhn · 2025-07-20 22:24:59 +08:00
  d770a08526
• Allow beatmap cards' collapsible icon buttons to be accessible via context menu
  Bartłomiej Dach · 2025-07-17 12:49:12 +02:00
  1ee439ad7f
• Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

  In stable mania, Hard Rock and Easy mods do not work the same way as
  they do on all of the rulesets. The difference is that mania HR and EZ,
  rather than apply a multiplier to the map's original Overall Difficulty,
  apply multipliers to *the durations of hit windows themselves*.
  
  Prior to the last release, lazer was oblivious to this reality and just
  treated mania HR / EZ as it did every other ruleset. Last release, for
  the sake for gameplay parity across rulesets, the mods in question were
  adjusted to match stable, but in the process, it started looking like HR
  / EZ did not change OD anymore.
  
  The problem is that they do, but applying a multiplier to the map's OD
  and applying a multiplier to the hit window duration is not the same
  thing. The second thing is actually *much harsher* in magnitude, to the
  point where applying HR to any map is almost guaranteed to exceed "the
  effective OD" of 10, and applying EZ to any map is almost guaranteed to
  result in "negative effective OD".
  
  This change attempts to convey that reality by displaying "effective
  OD", similar to what's already done in other rulesets when rate-changing
  mods are active. Note that the values this will display *do not match*
  stable *and that is correct*, because stable song select *lies* about
  the actual impact on OD by just assuming it can treat all rulesets in
  the same way.
  
  ---
  
  Would close https://github.com/ppy/osu/issues/34150 I guess.
  
  And yes I would like *all of the above* to land on the changelog if
  possible if this is merged.
  
  For further convincing that this makes any semblance of sense please see
  the following: https://www.desmos.com/calculator/yigt7jycdv

  Bartłomiej Dach · 2025-07-15 09:40:55 +02:00
  131f828e6a
• Switch to IconPills, add storyboard icon
  StanR · 2025-06-22 13:45:07 +05:00
  25eb9914a4
• Fix nominations count system not updated to newer API structure
  Salman Alshamrani · 2025-05-21 17:35:13 +03:00
  bd2851c386
• Merge pull request #33191 from peppy/fix-aggressive-diffcalc

  Reduce difficulty calculation churn overheads when using keyboard to iterate quickly at song select

  Dan Balasescu · 2025-05-21 20:48:14 +09:00
  662cbfcc48
• Resolve inspections
  Dan Balasescu · 2025-05-21 20:00:05 +09:00
  f967091aad
• Add property to allow disabling status pill animation
  Salman Alshamrani · 2025-05-21 00:37:08 +09:00
  c565b76b6e
• Add very basic transition for DifficultyIcon colour changes
  Dean Herbert · 2025-05-20 22:12:03 +09:00
  d9c376067d
• Add animation to star rating display in new carousel

  Also matches the animation speed of `StarRatingDisplay` with
  `StarCounter` as they are regularly displayed together.

  Dean Herbert · 2025-05-19 16:30:58 +09:00
  eb29c45513
• Improve star rating colour animations to match
  Dean Herbert · 2025-04-23 17:04:53 +09:00
  f6d7e29396
• Define constant for difficulty colour cutoff
  Dean Herbert · 2025-04-23 16:57:41 +09:00
  3f719125e6
• Update song select panel metrics in line with standard specifications and apply minor adjustments
  Salman Alshamrani · 2025-04-17 08:21:32 -04:00
  9e2a05a1fb
• Add animated fade when online status pill has an unknown status
  Dean Herbert · 2025-04-16 19:41:50 +09:00
  07d0c7443c
• Avoid performing colour fades when pill is not visible in the first place
  Dean Herbert · 2025-04-11 21:19:26 +09:00
  4b9873f03e
• Fix some incorrect/lacking comments
  Dean Herbert · 2025-04-11 21:14:56 +09:00
  c4cfd3a148
• Allow displaying "unknown" status in status pill
  Dean Herbert · 2025-04-10 23:42:29 +09:00
  57033fc180
• Fix status pill animating from zero height
  Dean Herbert · 2025-04-10 20:11:04 +09:00
  69035ef48f
• Fix code quality
  Bartłomiej Dach · 2025-04-10 07:47:31 +02:00
  fb326c6afd
• Remove manual handling of autosize now that we are using fixed width display
  Dean Herbert · 2025-04-10 01:46:44 +09:00
  962edbdf78
• Fix StarRatingDisplay not using fixed width text
  Dean Herbert · 2025-04-09 19:38:58 +09:00
  0c7c791fb5
• Remove loading spinner and fade out icon instead
  Dean Herbert · 2025-03-26 19:33:20 +09:00
  2b471919e9
• Improve input handling in beatmap card buttons

  This is in response to feedback in
  https://osu.ppy.sh/community/forums/topics/2056547?n=1.
  
  Upon examining the button further, there was indeed some rather weird...
  almost hysteresis in how the button behaved with respect to the area on
  the screen that activated it. Because of the following scourge of a
  method that continues to haunt us to this day:
  
  https://github.com/ppy/osu/blob/31487545d0d17c4337d4b4cc5d4afb3ba1dae838/osu.Game/Graphics/Containers/OsuClickableContainer.cs#L24-L25
  
  the button would effectively only be activated by 80% of its drawable
  area when it was not hovered, because of the scale applied to the
  `content` container which `Container.Content` redirected to.
  
  This is resolved here by various rearrangements of paddings and sizes
  such that the clickable area of any of the buttons of the card is always
  the full top or bottom half of the button area.
  
  Also included are some cosmetic touch-ups which happened to be
  convenient like folding the loading spinner into the base
  `BeatmapCardIconButton`, adding loading support for the favourite
  button, using BDL more, and resolving some "virtual member call in
  constructor" inspections.

  Bartłomiej Dach · 2025-03-25 12:59:37 +01:00
  199bcd7fdb
• Avoid multiple enumerations of beatmaps
  Dean Herbert · 2025-03-20 01:50:16 +09:00
  149e160964
• Fix DifficultySpectrumDisplay churning drawables

  Was causing so much GC that song select (v2) was grinding to a halt.

  Dean Herbert · 2025-03-19 19:31:57 +09:00
  63fcde5538
• Remove unnecessary customisation settings in DifficultySpectrumDisplay
  Dean Herbert · 2025-03-19 19:31:57 +09:00
  cfb14fbca6
• Fix status pills displaying wrong
  Dean Herbert · 2025-02-28 16:47:57 +09:00
  0e257038e8
• Implement beatmap set header design
  Salman Alshamrani · 2025-02-05 08:16:41 -05:00
  206b5c93c0
• Add inline comments for sets that are not marked FA but should be
  Bartłomiej Dach · 2025-01-27 09:40:53 +01:00
  e24af4b341
• Remove explicit beatmap set from list of bundled beatmap sets
  Bartłomiej Dach · 2025-01-27 09:40:20 +01:00
  836a9e5c25
• Add FormatStarRating() method util
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  e95dc2b308
• Merge branch 'master' into scale-profile-beatmaps
  Dean Herbert · 2024-11-22 18:33:37 +09:00
  e33e0e16e8
• Merge branch 'master' into multiplayer-remove-cmc-and-composite
  Dean Herbert · 2024-11-20 17:24:55 +09:00
  6fba6de4dc
• Use properties instead of fields
  Dan Balasescu · 2024-11-19 18:48:30 +09:00
  a5327aa562
• Scale beatmap cards down by ~0.8
  StanR · 2024-11-18 14:48:51 +05:00
  4066186b24
• use .ToFormattedDuration
  Shin Morisawa · 2024-11-14 16:59:03 +09:00
  7dff243e6a
• fix issue
  Shin Morisawa · 2024-11-14 16:33:52 +09:00
  64e7e44f28
• fixed said issue
  Shin Morisawa · 2024-11-14 07:19:18 +09:00
  a3da10ff44
• change stuff. (idk what exactly)
  Shin Morisawa · 2024-11-14 06:58:54 +09:00
  7e96ae6da4
• Make CurrentPlaylistItem not a bindable
  Dan Balasescu · 2024-11-12 18:17:24 +09:00
  72564b5c98
• Fix preview play button having incorrect click area
  Joseph Madamba · 2024-08-15 22:49:12 -07:00
  e2bf02cf94
• Expose BeatmapCardNormal height const
  Joseph Madamba · 2024-08-15 22:49:12 -07:00
  fda17a5a72
• Fix various visuals of playlist beatmap panels

  Supersedes https://github.com/ppy/osu/pull/28907.
  
  - Fix border being fat
  - Fix thumbnail not masking correctly
  - Fix background layer not being correctly fit to the panel
  - Dim the main background on hover
  - Minor tweaks to dimming

  Dean Herbert · 2024-07-19 19:26:04 +09:00
  f11f01f9b7
• Fix beatmap card progress bar becoming pancake when starting
  Dean Herbert · 2024-07-10 19:19:49 +09:00
  2ba1ebe410
• Fix code quality and null handling
  Dean Herbert · 2024-06-07 00:01:50 +08:00
  dd3f4bcdab