10447 Commits

• Add failing test case
  Salman Alshamrani · 2025-03-23 21:38:36 -04:00
  b3d572029f
• Add sheared dropdown
  Salman Alshamrani · 2025-03-22 22:49:34 -04:00
  25e404c734
• Add test coverage
  Salman Alshamrani · 2025-03-22 22:15:02 -04:00
  b6068e6e29
• Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  RFC. Another attempt at this.
  
  - Supersedes https://github.com/ppy/osu/pull/31881
  - Supersedes / closes https://github.com/ppy/osu/pull/31355
  - Closes https://github.com/ppy/osu/issues/29861
  
  This is a weird diff because I am feeling rather boxed in by all the
  constraints, namely that:
  
  - Leaderboard state should be global state
  - But the global state is essentially managed by song select and namely
    `BeatmapLeaderboard` itself. That's because trying to e.g. not have
    `BeatmapLeaderboard` pass the beatmap and the ruleset to the global
    leaderboard manager is worse, as it essentially introduces two
    parallel paths of execution that need to be somehow merged into one
    (as in I'd have to somehow sync `LeaderboardManager` responding to
    beatmap/ruleset changes with `BeatmapLeaderboard` which is inheritance
    hell)
  - Also local leaderboard fetching is data-push (as in the scores can
    change under the leaderboard manager), and online leaderboard fetching
    is data-pull (as in the scores do not change unless the leaderboard
    manager does something). Also online leaderboard fetching can fail.
    Which is why I need to still have the weird setup wherein there's a
    `FetchWithCriteriaAsync()` (because I need to be able to respond to
    online requests taking time, or failing), but also the
    `BeatmapLeaderboard` only uses the public `Scores` bindable to
    actually read the scores (because it needs to respond to new local
    scores arriving).
  - Another thing to think about here is what happens when a retrieval
    fails because e.g. the user requested friend leaderboards without
    having supporter. With how this diff is written, that special
    condition is handled to `BeatmapLeaderboard`, and
    `LeaderboardManager`'s state will remain as whatever it was before
    that scope change was requested, which may be considered good or it
    may not (I imagine it's better to show scores in gameplay than not in
    this case, but maybe I'm wrong?)

  Bartłomiej Dach · 2025-03-21 12:06:16 +01:00
  0209129618
• Merge pull request #32478 from peppy/no-tag-on-convert

  Disallow tagging beatmaps when playing as convert

  Dean Herbert · 2025-03-20 19:54:47 +09:00
  6b1d09bec7
• Add visual test coverage for no convert conditional
  Bartłomiej Dach · 2025-03-20 10:32:40 +01:00
  36ba9dbc8c
• Merge pull request #32467 from peppy/diff-display-spectrum-no-churn

  Fix `DifficultySpectrumDisplay` churning drawables

  Bartłomiej Dach · 2025-03-20 08:43:51 +01:00
  0580d806b9
• Merge pull request #30866 from frenzibyte/image-proxying

  Fix some image attachments in comments not loading in game

  Dean Herbert · 2025-03-20 16:00:22 +09:00
  5183078801
• Merge pull request #32446 from GioSDA/chat-right-click-functionality

  Add more functionality to right clicking in the chat window

  Bartłomiej Dach · 2025-03-19 12:34:21 +01:00
  8b566d2955
• Fix DifficultySpectrumDisplay churning drawables

  Was causing so much GC that song select (v2) was grinding to a halt.

  Dean Herbert · 2025-03-19 19:31:57 +09:00
  63fcde5538
• Remove unnecessary customisation settings in DifficultySpectrumDisplay
  Dean Herbert · 2025-03-19 19:31:57 +09:00
  cfb14fbca6
• Merge pull request #32459 from smoogipoo/remove-superfluous-method

  Replace superfluous method with concrete implementation

  Bartłomiej Dach · 2025-03-19 11:02:42 +01:00
  e51b666f5c
• Fix intermittent mod customisation panel test
  Dan Balasescu · 2025-03-19 16:13:56 +09:00
  9272ada859
• Fix code quality issue
  Dan Balasescu · 2025-03-19 15:50:39 +09:00
  54b079098b
• Remove no-longer used bindable from footer
  Dan Balasescu · 2025-03-19 15:48:25 +09:00
  606bf1eb9f
• Refactor ready button to remove selected item bindable
  Dan Balasescu · 2025-03-19 15:48:25 +09:00
  ca2c48bbd6
• Refactor spectate button to remove selected item bindable
  Dan Balasescu · 2025-03-19 15:41:24 +09:00
  b4a934a797
• Replace superfluous method with concrete implementation
  Dan Balasescu · 2025-03-19 15:32:29 +09:00
  23fa3060b2
• Add playlists/multiplayer versions of RoomPanel
  Dan Balasescu · 2025-03-19 15:28:50 +09:00
  ec0f8142c2
• Rename DrawableRoom -> RoomPanel
  Dan Balasescu · 2025-03-19 15:24:51 +09:00
  36e78119ae
• Rename APIUser.IsOnline and add better documentation around online checks
  Dean Herbert · 2025-03-19 15:01:40 +09:00
  b17ec5e69d
• Merge pull request #32376 from nekodex/better-kiai-fountain-sfx

  Improve SFX playback behaviour of rapid kiai/star fountain activations

  Dean Herbert · 2025-03-18 17:49:21 +09:00
  aa6d644f70
• Allow testing fountain sound effects in tests
  Dean Herbert · 2025-03-18 16:35:11 +09:00
  533b0e0f88
• Make freestyle not bypass ruleset filter once more
  Dan Balasescu · 2025-03-18 14:32:07 +09:00
  bf3caacf51
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Add the most basic (yet failing) test possible
  Bartłomiej Dach · 2025-03-17 14:52:09 +01:00
  613c46d375
• Merge branch 'master' into set-guest-update
  Bartłomiej Dach · 2025-03-17 12:26:41 +01:00
  05366c2397
• Fix code quality
  Salman Alshamrani · 2025-03-17 03:35:27 -04:00
  597eec99e6
• Fix inconsistent access
  Salman Alshamrani · 2025-03-17 02:19:03 -04:00
  0bc5a8103c
• Rewrite test to contain asserts
  Salman Alshamrani · 2025-03-17 02:16:09 -04:00
  e8d245e9f1
• Fix one more test (sorry)
  Dean Herbert · 2025-03-16 14:10:57 +09:00
  4d54f98c55
• Fix failing test
  Dean Herbert · 2025-03-16 13:28:57 +09:00
  3e36820117
• Merge pull request #32346 from bdach/user-tags-on-results

  Add ability to vote for beatmap user tags after completing a play

  Dean Herbert · 2025-03-15 14:36:27 +09:00
  d704adf5fa
• Add failing test
  Dan Balasescu · 2025-03-14 19:11:15 +09:00
  7715a3dd9f
• Fix test
  Bartłomiej Dach · 2025-03-13 12:06:27 +01:00
  723a22130d
• Require high enough score rank for tagging beatmap
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  5b1a4c8ed1
• Simplify boolean flags
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  f78e371b1b
• Merge pull request #32360 from peppy/add-team-beatmap-leaderboards

  Add team beatmap leaderboards

  Bartłomiej Dach · 2025-03-13 10:04:53 +01:00
  0f74f7eed5
• Merge pull request #32352 from smoogipoo/friend-display-user-presence

  Make friends display respond to realtime user presence

  Dean Herbert · 2025-03-13 17:24:57 +09:00
  dc1674105e
• Add support for team beatmap leaderboards
  Dean Herbert · 2025-03-13 16:28:20 +09:00
  b0cf5e8bff
• Merge pull request #31148 from peppy/editor-right-click-as-people-expect

  Add back right-click-for-new-combo and right-click-delete when in object placement mode

  Bartłomiej Dach · 2025-03-13 08:24:08 +01:00
  61ed52eb69
• Add test coverage of friend going offline
  Dean Herbert · 2025-03-13 15:28:04 +09:00
  829dfedfdc
• Fix tests
  Dan Balasescu · 2025-03-13 12:57:29 +09:00
  f00d2cbfa2
• Merge branch 'master' into image-proxying
  Dean Herbert · 2025-03-13 12:33:36 +09:00
  80c896a895
• Merge pull request #31882 from smoogipoo/room-subscreen-split

  Rewrite playlists to not inherit `RoomSubScreen`

  Dean Herbert · 2025-03-13 12:29:48 +09:00
  d9f7d13894
• Fix no display if friends already loaded
  Dan Balasescu · 2025-03-13 01:54:36 +09:00
  bfdc7c1688
• Update tests
  Dan Balasescu · 2025-03-13 01:36:32 +09:00
  4b54b8c0d8
• Add visual test coverage of user tag control on results
  Bartłomiej Dach · 2025-03-12 12:20:37 +01:00
  6f74d8ad50
• Add user tag control to results screen's statistics panel
  Bartłomiej Dach · 2025-03-12 12:19:21 +01:00
  d1ce64b3f6
• Remove inheritance in StatisticsPanel
  Bartłomiej Dach · 2025-03-12 12:17:38 +01:00
  5f0451eb79