247 Commits

• Fix test failure due to stupid reasons

  I'm actually not sure why not resetting this fails, but I don't want to
  spend the time investigating either.

  Dean Herbert · 2025-07-29 17:51:15 +09:00
  54a7f7ee71
• Fix missed inspection
  Dean Herbert · 2025-07-29 16:48:39 +09:00
  584362efc3
• Add test coverage of read-only scenario
  Dean Herbert · 2025-07-29 16:46:07 +09:00
  988f1a4e76
• Merge branch 'master' into NotStirred/master
  Dean Herbert · 2025-07-29 16:36:37 +09:00
  2dde5b1eaf
• Add failing test case
  Bartłomiej Dach · 2025-06-25 11:01:53 +02:00
  ee2a247c66
• Add testing
  Bartłomiej Dach · 2025-06-24 11:46:40 +02:00
  a78dc31d8b
• Address review comments
  Tom Martin · 2025-06-11 04:34:13 +01:00
  33905f2e70
• Fix oversight in other test
  Bartłomiej Dach · 2025-06-09 11:01:45 +02:00
  348c727264
• Add failing test coverage
  Bartłomiej Dach · 2025-06-09 10:52:10 +02:00
  9707fd43f4
• Always allow a map's user-tags to be read
  Tom Martin · 2025-06-07 22:51:13 +01:00
  934e529eca
• Fix solo results screen tests better

  See 12b09586c7.

  Bartłomiej Dach · 2025-05-20 12:10:07 +02:00
  6a56ed1d3b
• Fix solo results screen test failure

  As spotted in https://github.com/ppy/osu/pull/33191/checks?check_run_id=42460062656
  
  Seems like just a bog-standard race. Could be reproduced via
  
  diff --git a/osu.Game/Screens/Ranking/SoloResultsScreen.cs b/osu.Game/Screens/Ranking/SoloResultsScreen.cs
  index d11e7db178..1a594fd21b 100644
  --- a/osu.Game/Screens/Ranking/SoloResultsScreen.cs
  +++ b/osu.Game/Screens/Ranking/SoloResultsScreen.cs
  @@ -45,6 +45,8 @@ protected override async Task<ScoreInfo[]> FetchScores()
               if (Score.BeatmapInfo!.OnlineID <= 0 || Score.BeatmapInfo.Status <= BeatmapOnlineStatus.Pending)
                   return [];
  
  +            await Task.Delay(5000).ConfigureAwait(false);
  +
               var criteria = new LeaderboardCriteria(
                   Score.BeatmapInfo!,
                   Score.Ruleset,

  Bartłomiej Dach · 2025-05-20 11:09:18 +02:00
  12b09586c7
• Add failing test coverage for expected behaviour
  Bartłomiej Dach · 2025-05-13 10:15:54 +02:00
  3c219a799b
• Add test coverage for position accounting on results screen
  Bartłomiej Dach · 2025-04-29 12:58:30 +02:00
  be34331f17
• Fix global offset adjust control showing adjustment available when it shouldn't

  Audio offset is integer based in configuration, so let's make sure not
  to show that there's an applicable offset when the value difference is
  too low.
  
  I've also fixed rounding to match expectations (`AudioOffset` is
  precision limited to integer), and handled the case where a user adjusts
  the slider but also has a suggested offset – previously it would not
  enable the button after slider adjustments but now it will work as
  expected.

  Dean Herbert · 2025-04-16 20:21:50 +09:00
  51ad6289ca
• Fix crashes in statistics panel test scene
  Bartłomiej Dach · 2025-04-07 14:49:55 +02:00
  9643beafa7
• Switch to using a popover again
  Dean Herbert · 2025-04-07 20:14:08 +09:00
  43ee43c9e2
• Merge branch 'ruleset-specific-user-tags' into better-user-tag-ui
  Bartłomiej Dach · 2025-04-02 13:28:28 +02:00
  ad334b2bf4
• Add rudimentary test coverage
  Bartłomiej Dach · 2025-04-02 13:25:18 +02:00
  db0f1895fb
• Add groupings to all tags list
  Bartłomiej Dach · 2025-03-31 10:45:44 +02:00
  624948f082
• Move the extra tag selector out of popover
  Bartłomiej Dach · 2025-03-28 14:05:35 +01:00
  1d44d5e100
• Redesign vote buttons to better work with hierarchical tags
  Bartłomiej Dach · 2025-03-28 13:24:26 +01:00
  9b9cfbc9c2
• Remove unused local
  Dean Herbert · 2025-03-26 19:10:14 +09:00
  90bc2318e1
• Allow tagging already played beatmaps without playing another time

  Addresses
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12610577.
  
  No changes in criteria (yet?), just allowing locally imported plays to
  count the same way as full beatmap completion does.
  
  The test scene is a bit rough / semi-manual but dealing with score
  imports is a bit of a pain in general. The way to semi-manually test
  with the test scene is to import a subset of scores, then recreate the
  statistics panel, and observe behaviour. I'm not sure it's worth it to
  be putting subscriptions in there, so the full recreation of the panel
  is necessary.

  Bartłomiej Dach · 2025-03-25 14:16:26 +01:00
  40d20f4e10
• Merge branch 'master' into show-full-rank
  Bartłomiej Dach · 2025-03-24 12:56:20 +01:00
  c631e7a1c5
• Add extra test coverage
  Bartłomiej Dach · 2025-03-24 12:28:46 +01:00
  f6dd2e4ac2
• Add visual test coverage for no convert conditional
  Bartłomiej Dach · 2025-03-20 10:32:40 +01:00
  36ba9dbc8c
• Fix test
  Bartłomiej Dach · 2025-03-13 12:06:27 +01:00
  723a22130d
• Require high enough score rank for tagging beatmap
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  5b1a4c8ed1
• Simplify boolean flags
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  f78e371b1b
• Add visual test coverage of user tag control on results
  Bartłomiej Dach · 2025-03-12 12:20:37 +01:00
  6f74d8ad50
• Add user tag control to results screen's statistics panel
  Bartłomiej Dach · 2025-03-12 12:19:21 +01:00
  d1ce64b3f6
• Remove inheritance in StatisticsPanel
  Bartłomiej Dach · 2025-03-12 12:17:38 +01:00
  5f0451eb79
• Rewrite OverallRanking to interface directly with UserStatisticsWatcher
  Bartłomiej Dach · 2025-03-12 12:17:02 +01:00
  0ffb233796
• Add UI for assigning custom tags to beatmaps

  Visual part for https://github.com/ppy/osu/issues/31913. Opening
  separately for appropriate visual UI adjustments.
  
  Also mostly ready to be hooked up to the results screen, pending merge
  of https://github.com/ppy/osu-web/pull/11951.

  Bartłomiej Dach · 2025-03-04 13:08:02 +01:00
  c051ff84d2
• Fix intermittent score panel test
  Dan Balasescu · 2025-03-04 11:38:25 +09:00
  df25734834
• Arrays instead of enumerables
  Dan Balasescu · 2025-02-25 22:55:55 +09:00
  3b5bf391da
• Make results screens use tasks to fetch scores
  Dan Balasescu · 2025-02-25 21:54:16 +09:00
  13ca8c20f6
• Adjust results screen designs and tests slightly
  Dean Herbert · 2025-02-07 14:21:43 +09:00
  25846b2327
• Decouple game-wide ruleset bindable and refactor LocalUserStatisticsProvider

  This also throws away the logic of updating
  `API.LocalUser.Value.Statistics`. Components should rely on
  `LocalUserStatisticsProvider` instead for proper behaviour and ability
  to update on statistics updates.

  Salman Alshamrani · 2024-11-17 18:13:37 -05:00
  4a628287e2
• Add failing test showing crash when adjusting offset with no HitEvents
  Dean Herbert · 2024-11-14 16:03:00 +09:00
  1b6952c42a
• Add failing test case
  Bartłomiej Dach · 2024-09-24 17:51:54 +02:00
  555d4ffe89
• Remove unnecessary depth and padding set
  Joseph Madamba · 2024-07-27 19:13:11 -07:00
  bc25e5d706
• Use same size button for everything
  Joseph Madamba · 2024-07-27 18:43:54 -07:00
  b4ca07300a
• Remove nullable disable
  Layendan · 2024-07-21 23:56:47 -07:00
  6a4872faa8
• Fix lint errors
  Layendan · 2024-07-22 12:22:52 +09:00
  e4cccb5e31
• Add tests
  Layendan · 2024-07-22 12:22:51 +09:00
  a575566638
• Merge pull request #27994 from bdach/timing-distribution-graph-only-basic

  Do not show non-basic results in timing distribution graph

  Dan Balasescu · 2024-04-26 01:36:16 +09:00
  459f97891d
• Add test case covering ignoring non-basic results
  Bartłomiej Dach · 2024-04-25 11:19:29 +02:00
  9e919b784d
• Apply nullability annotations to ResultsScreen & inheritors
  Bartłomiej Dach · 2024-04-25 10:58:28 +02:00
  da953b34a7