55 Commits

• Fix external edit filename sanitising unintentionally dropping folder separators (#34945)

  * Add failing test coverage showing external edits not working with folders
  
  * Fix external edit filename sanitising unintentionally dropping folder separators
  
  Closes https://github.com/ppy/osu/issues/34929.

  Dean Herbert · 2025-09-07 21:47:20 +09:00
  645518f5bd
• Check exported filenames for added safety
  Dean Herbert · 2025-09-03 17:14:45 +09:00
  a840e55977
• Add failing test case
  Bartłomiej Dach · 2025-09-03 09:26:06 +02:00
  6399f7e3db
• Add failing test case
  Bartłomiej Dach · 2024-03-12 09:05:28 +01:00
  961058f5c8
• Remove unused using directive
  Bartłomiej Dach · 2023-11-15 18:27:08 +09:00
  b118999120
• Add test coverage of layout retrievable after importing modified skins
  Dean Herbert · 2023-11-15 14:08:05 +09:00
  aac1854d83
• Add test coverage of incorrect version on missing skin.ini
  Dean Herbert · 2023-09-27 16:50:01 +09:00
  84682b4227
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Merge remote-tracking branch 'upstream/master' into export
  cdwcgt · 2023-04-09 15:02:47 +09:00
  ce6a87b4a3
• use Live<TModel>

  Use RealmAccess only when needed

  cdwcgt · 2023-04-09 22:21:15 +09:00
  de21b4a2f7
• Add test to check for import of exported skin with non-ASCII name
  rozukke · 2023-03-13 23:37:45 +11:00
  4570c0030f
• Merge branch 'master' into export
  cdwcgt · 2023-02-17 22:15:19 +09:00
  e84e011d5d
• Move ImportParameters to better home
  Dean Herbert · 2022-12-13 21:41:26 +09:00
  b8904fe747
• Convert batchImport parameter to parameters class to allow further import configuration
  Dean Herbert · 2022-12-13 19:55:18 +09:00
  cf2719d4c0
• refactor based on reviews

  removed LegacyExportManager
  
  Separated the method of CreateZip method and the default export method

  cdwcgt · 2022-11-21 18:58:01 +09:00
  e37d30a373
• typo fix
  cdwcgt · 2022-11-21 17:42:11 +09:00
  ed53168267
• working with test
  cdwcgt · 2022-11-19 01:02:35 +09:00
  fc4a6cb125
• add LegacyExportManager
  cdwcgt · 2022-11-18 20:00:00 +09:00
  4b29941b47
• create a task to export to avoid block main thread

  Code quality and remove some #nullable disable

  cdwcgt · 2022-11-17 01:08:06 +09:00
  e1a21e0cf9
• Update import skin test in line with new default
  Dean Herbert · 2022-09-19 23:16:46 +09:00
  70d60a7e73
• Apply more renames
  Dean Herbert · 2022-09-18 18:19:00 +09:00
  d0b8409de5
• Remove "default" prefix from naming
  Dean Herbert · 2022-09-18 00:15:26 +09:00
  41e69fbca6
• Rename references to DefaultSkin to have Triangles suffix
  Dean Herbert · 2022-09-17 23:57:25 +09:00
  51841988bf
• Add test coverage for batch-import path
  Salman Ahmed · 2022-07-07 18:06:35 +03:00
  cd4755fbd9
• Remove null default value in ImportSkinTest helper method
  Bartłomiej Dach · 2022-06-20 10:44:14 +02:00
  b0b3ea42cc
• Remove Import(ArchiveReader) and redirect existing usages to Import(ImportTask)
  Dean Herbert · 2022-06-20 15:14:57 +09:00
  a6c8a832aa
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add failing test coverage of skin import after exporting from lazer
  Dean Herbert · 2022-04-12 00:29:15 +09:00
  4ab6c11079
• Remove ILive<> interface (and use abstract Live<> instead)
  Dean Herbert · 2022-01-26 13:38:56 +09:00
  cd71ec0edd
• Update usages to new naming
  Dean Herbert · 2022-01-06 22:54:43 +09:00
  00177a3ae1
• Replace usage of .Result with .WaitSafelyForResult
  Dean Herbert · 2022-01-04 11:51:41 +09:00
  73b40e6833
• Update usages of CleanRunHeadlessGameHost to match new signature
  Dean Herbert · 2021-12-24 20:17:34 +09:00
  4b88e257e5
• Add failing test coverage of exporting default skin importing with incorrect type
  Dean Herbert · 2021-12-02 18:05:16 +09:00
  b976848774
• Remove excess brackets

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-12-01 12:44:25 +09:00
  d78c18d03f
• Use ILive for current skin
  Dean Herbert · 2021-11-29 18:28:25 +09:00
  23146d59d1
• Update tests and file access code
  Dean Herbert · 2021-11-29 18:28:25 +09:00
  2a9c7c00c8
• Add test coverage of skin with missing section header
  Dean Herbert · 2021-11-02 14:05:14 +09:00
  d4be6fc797
• Add missing verbatim string markers
  Dean Herbert · 2021-11-01 14:24:38 +09:00
  6b250955d7
• Add test coverage of failure from incorrect case in skin.ini filename
  Dean Herbert · 2021-11-01 14:24:38 +09:00
  32817a4c66
• Fix typo in region spedc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-10-22 11:03:28 +09:00
  08971ff8f2
• Revert disallowing imports with no files

  While it is logical that we want this, from a testing perspective this is a bit of a nightmare to fix. Let's revisit at a later point in time.

  Dean Herbert · 2021-10-21 13:43:42 +09:00
  59b7210efa
• Rename test variable for legibility
  Dean Herbert · 2021-10-20 17:56:45 +09:00
  5f53dd8021
• Add test coverage for skin.ini contents
  Dean Herbert · 2021-10-20 17:56:45 +09:00
  602303e947
• Rewrite tests completely
  Dean Herbert · 2021-10-20 17:45:06 +09:00
  19f30177ea
• Add skin.ini write support to allow for more correct hashing
  Dean Herbert · 2021-10-20 17:45:06 +09:00
  789c715f13
• Initial push to use ILive in import process
  Dean Herbert · 2021-09-30 22:55:25 +09:00
  a2e61883e3
• Change brackets to square
  Dean Herbert · 2021-08-23 20:37:19 +09:00
  a2484692b3
• Add test coverage of different folder names with same skin.ini
  Dean Herbert · 2021-08-23 20:28:46 +09:00
  0cbe95d661
• Fix tests by allowing retrieval with files where required
  Dean Herbert · 2021-08-17 19:21:22 +09:00
  d66f7cb6b5
• Add test coverage
  Salman Ahmed · 2021-03-24 22:55:15 +03:00
  35810bb2fb