29 Commits

• Add and use new mod icon assets
  Bartłomiej Dach · 2025-08-21 09:00:44 +02:00
  92016a7d9b
• Fix another potential crash in bubbles mod

  Storing `DrawableHitObject` for later use is not safe – especially
  when accessing `HitObject` – as it's a pooled class. In the case here,
  it's important to note that `PrepareForUse` can be called a frame or
  more later in execution, which made this unsafe.
  
  Closes https://github.com/ppy/osu/issues/24444.

  Dean Herbert · 2023-11-02 02:43:51 +09:00
  48bdeaeff1
• Simplify code
  Salman Ahmed · 2023-09-24 02:22:50 +03:00
  734ee0e68b
• Get first Spinner,Slider or HitCircle instead of only HitCircle

  Fixes bug

  Fabian van Oeffelt · 2023-09-23 13:18:49 +02:00
  7c40072c47
• Fix "bubbles" mod not adding pool to hierarchy (and constructing too early)
  Dean Herbert · 2023-06-02 23:01:03 +09:00
  a5fd833214
• Avoid using Schedule in transforms (doesn't handle rewind well)
  Dean Herbert · 2023-05-02 17:08:49 +09:00
  e44672bdd5
• Tidy up various code quality issues in OsuModBubbles
  Dean Herbert · 2023-05-02 17:08:37 +09:00
  7830711c8e
• Ensure lifetime start is also updated when reverting judgements
  Dean Herbert · 2023-05-02 17:07:12 +09:00
  fb0e90913d
• Code cleanup pass:

  Make bubble transform logic more sane.
  
  Extract bubble `getPosition()` method.
  
  Address poorly named variables.

  mk56-spn · 2023-02-16 11:12:30 +01:00
  d5bc8e2941
• Remove dysfunctional slider colouring
  mk56-spn · 2023-02-15 10:04:50 +01:00
  8fc35b159f
• Remove BubbleInfo struct and consume DrawableOsuHitObjects directly
  mk56-spn · 2023-02-15 10:00:46 +01:00
  297963b461
• Invert pointless nested if statement
  mk56-spn · 2023-02-15 09:37:47 +01:00
  1d1c794ccf
• make transform duration for bubble a method instead of a variable
  mk56-spn · 2023-02-15 09:33:18 +01:00
  e9a7d90273
• Make colouring for bubble more intuitive and remove unnecessary alpha assignment
  mk56-spn · 2023-02-15 09:30:56 +01:00
  82292d6162
• Change bubble rewind removal to be in ApplyToDrawableHitObject method.
  mk56-spn · 2023-02-14 18:06:43 +01:00
  5db624159b
• move logic for bubble invoking to ApplyToDrawableHitobject()` method
  mk56-spn · 2023-02-14 16:31:34 +01:00
  92c61c7339
• Move bubbles to ruleset overlays container
  mk56-spn · 2023-02-14 14:03:48 +01:00
  2d49b5f9d6
• Make lastJudgedHitObject nullable, and fix typo in name.
  mk56-spn · 2023-02-14 10:12:37 +01:00
  d100a4a491
• Simplify bubble container structure, modify some comments
  mk56-spn · 2023-02-12 11:37:07 +01:00
  6ff6e06a69
• Refactor pooling for bubbles, tweak the animations a tad, add some clarifying comments
  mk56-spn · 2023-02-12 00:59:46 +01:00
  5e0c4aa904
• Add inline comment for colour border override
  mk56-spn · 2023-02-06 17:00:47 +01:00
  f0d4b9f0ca
• Code quality pass of OsuModBubbles
  Dean Herbert · 2023-02-06 17:35:43 +09:00
  abcb564a74
• Redo the drawable structure of bubbledrawable to run and look better
  mk56-spn · 2023-01-29 00:48:14 +01:00
  3bdf83bf44
• Add colouration to the sliders to better match the vibrancy of the mod
  mk56-spn · 2023-01-28 17:38:24 +01:00
  66da4c0288
• Simplify animations
  mk56-spn · 2023-01-28 00:30:30 +01:00
  c3090dea5f
• Remove unnecessary BDL from bubble drawable

  Improve animation duration formula

  mk56-spn · 2023-01-27 12:53:19 +01:00
  7c81f1e75b
• Add more detail to bubbles
  mk56-spn · 2023-01-11 17:51:41 +01:00
  ca84b885dc
• Address mod incompatibilities
  mk56-spn · 2022-12-25 23:11:15 +01:00
  8a108b143e
• Add "ModBubbles" for the osu ruleset.
  mk56-spn · 2022-12-25 23:09:52 +01:00
  bbb22479a8