503 Commits

• Reword comment to be more coherent
  Bartłomiej Dach · 2025-08-06 15:04:29 +02:00
  f1f7784272
• Fix grid placement aggressively changing tool selection
  Salman Alshamrani · 2025-08-05 15:20:04 +03:00
  6001d6418b
• Fix crashes when attempting to adjust length of slider whose maximum path length is less than the current beat snap

  Closes https://github.com/ppy/osu/issues/32289.
  
  There are two possible choices here: either pulling the lower bound of
  the clamp down to `HitObject.Path.CalculatedDistance`, or pulling the
  higher bound up to `minDistance`, if it happens to be larger than the
  path's calculated distance.
  
  Both options are a bit weird; pulling down can result in unsnapped
  sliders when attempting to drag a slider's end when on a lower beat
  divisor than was used to place the slider, and pulling up can result in
  weird sliders wherein they get extended beyond their path's definition
  with a weird linear section at the end without an anchor that is tangent
  to the slider shape's end. I decided the first one was less weird, but
  I'm open to discuss further.

  Bartłomiej Dach · 2025-05-14 13:34:12 +02:00
  9b2f25cb93
• Fix edge case allowing almost-zero-length sliders to be placed during distance snapping
  Dean Herbert · 2025-03-11 16:17:44 +09:00
  23891b1994
• Merge pull request #32158 from bdach/scaling-crash

  Fix possible crash when scaling objects in editor

  Dean Herbert · 2025-03-04 13:40:41 +09:00
  3fe92fb83c
• Mark MathHelper.Clamp() as banned API

  See previous commit for partial rationale.
  
  There's an argument to be made about the `NaN`-spreading semantics being
  desirable because at least something will loudly fail in that case, but
  I'm not so sure about that these days. It feels like either way if
  `NaN`s are produced, then things are outside of any control, and chances
  are the game can probably continue without crashing. And, this move
  reduces our dependence on osuTK, which has already been living on
  borrowed time for years now and is only awaiting someone brave to go
  excise it.

  Bartłomiej Dach · 2025-02-28 13:48:22 +01:00
  35b0ff80bb
• Fix sliders not being selectable if the body is hidden but the head is still visible

  Closes https://github.com/ppy/osu/issues/31998.
  
  Previously: https://github.com/ppy/osu/commit/1648f2efa306f587714178f113e69d8ad8c4ac02,
  https://github.com/ppy/osu/pull/31923.
  
  Oh input handling, how I love ya.

  Bartłomiej Dach · 2025-02-27 15:00:29 +01:00
  5b318edbfb
• Fix selected sliders sometimes not being clickable in editor

  Closes https://github.com/ppy/osu/issues/31918.
  Regressed with
  https://github.com/ppy/osu/commit/1648f2efa306f587714178f113e69d8ad8c4ac02
  for obvious reasons.

  Dean Herbert · 2025-02-18 13:41:30 +09:00
  77e40140e5
• Refactor IDistanceSnapProvider to accept slider velocity objects as a reference

  Method signatures are also changed to be a lot more explicit as to what
  inputs they expect.

  Bartłomiej Dach · 2025-02-03 14:00:57 +01:00
  a1185df2eb
• Avoid moving already placed objects temporally when "limit distance snap to current time" is active
  Bartłomiej Dach · 2025-01-31 09:51:13 +01:00
  8718483c70
• Refactor further to avoid weird non-virtual common method
  Bartłomiej Dach · 2025-01-24 13:14:31 +01:00
  daec91f61d
• Fix behavioural change in interaction between grid & distance snap
  Bartłomiej Dach · 2025-01-24 13:14:26 +01:00
  b04144df54
• Fix tests
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  269ade178e
• Remove dependence of placement blueprints on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  a6987f5c95
• Remove dependence of blueprint containers on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:05 +01:00
  15b6e28ebe
• Ensure slider is not selectable when body is not visible
  Dean Herbert · 2025-01-07 16:38:22 +09:00
  1648f2efa3
• Fix slider end drag marker blocking open of control point piece context menus

  Closes https://github.com/ppy/osu/issues/31323.

  Bartłomiej Dach · 2024-12-30 11:07:25 +01:00
  4d326ec31f
• Fix quick-deleting unselected slider path control point also deleting all selected control points

  Closes https://github.com/ppy/osu/issues/31308.
  
  Logic matches corresponding quick-delete logic in
  https://github.com/ppy/osu/blob/130802e48048c134c6c8f19c77e3e032834acf72/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs#L307-L316.

  Bartłomiej Dach · 2024-12-30 09:44:04 +01:00
  182f998f9b
• Fix being able to click through slider tail drag handles

  Closes https://github.com/ppy/osu/issues/31176.

  Dean Herbert · 2024-12-19 00:01:36 +09:00
  c68dc11412
• Add comments backreferences to copies of duplicated code for future use
  Bartłomiej Dach · 2024-12-11 16:26:11 +09:00
  5a0b732ee3
• Merge branch 'master' into editor-slider-touch-support-2
  Salman Alshamrani · 2024-10-23 17:02:38 -04:00
  6e9ff49e59
• Fix placement blueprints sometimes not behaving correctly with touch input

  More specifically, this fixes placement blueprints not beginning placement when using touch input while the cursor was previously outside compose area, due to the placement blueprint not existing (removed from the scene by `ComposeBlueprintContainer`).

  Salman Alshamrani · 2024-10-23 16:51:21 -04:00
  3a4d5af83e
• Terminate existing anchor create operation when object is deselected
  Bartłomiej Dach · 2024-10-15 12:54:11 +02:00
  232301f27d
• Terminate existing anchor drag operations when object is deselected
  Bartłomiej Dach · 2024-10-15 12:53:40 +02:00
  1a7acbac33
• Fix isSplittable depending on unreliable order of path control point pieces
  OliBomby · 2024-10-09 23:31:12 +02:00
  9936ec579f
• Let right-click reset grid to default values
  OliBomby · 2024-10-08 10:51:35 +02:00
  de2f9dec39
• update comment
  OliBomby · 2024-10-08 10:46:10 +02:00
  e794862da5
• Switch back to last tool after using grid tool, rather than always select tool
  Dean Herbert · 2024-10-08 17:34:51 +09:00
  b1be31cd6a
• Fix crash on placing circular grid
  OliBomby · 2024-10-07 16:19:01 +02:00
  533ed609fb
• Merge remote-tracking branch 'upstream/master' into grids-4
  OliBomby · 2024-10-01 15:43:54 +02:00
  f8397cccc7
• Merge pull request #29691 from bdach/hotkeys-in-context-menus

  Add hotkey hints to editor menus

  Dean Herbert · 2024-10-01 19:29:05 +09:00
  54e68005ef
• Less var please
  Dean Herbert · 2024-10-01 18:44:27 +09:00
  24d534929d
• Merge pull request #30062 from bdach/distance-snap-weirdness

  Fix various distance snap grid weirdness around unsnapped objects

  Dean Herbert · 2024-10-01 16:16:22 +09:00
  87ab953935
• Merge branch 'master' into hotkeys-in-context-menus
  Dean Herbert · 2024-10-01 15:50:19 +09:00
  590f27e0a0
• Ensure sliders are snapped when changing path types

  Closes https://github.com/ppy/osu/issues/29915.
  
  Uses behaviour suggested in
  https://github.com/ppy/osu/issues/29915#issuecomment-2361843011.

  Bartłomiej Dach · 2024-09-30 14:38:20 +02:00
  48b03a328b
• Fix distance spacing grid displaying incorrectly for unsnapped objects with duration
  Bartłomiej Dach · 2024-09-30 13:36:16 +02:00
  75fc57c34b
• Combine drag and clicky interactions
  OliBomby · 2024-09-28 17:26:39 +02:00
  4568af8fda
• place grid with drag instead
  OliBomby · 2024-09-28 15:56:37 +02:00
  4e2bc0d1bd
• Refactor PlacementBlueprint to not be hitobject specific
  OliBomby · 2024-09-24 20:31:00 +02:00
  e3b4483872
• Don't snap to global grid while placing grid
  OliBomby · 2024-09-23 17:24:09 +02:00
  0f0f490598
• Convert 'grid from points' button to placement tool
  OliBomby · 2024-09-23 16:36:45 +02:00
  0a5a463380
• Refactor PlacementBlueprint to not be hitobject specific
  OliBomby · 2024-09-23 16:33:36 +02:00
  1a81e12192
• Fix slider end drag marker being in incorrect position for stacked sliders

  Closes https://github.com/ppy/osu/issues/29884.

  Bartłomiej Dach · 2024-09-17 08:23:46 +02:00
  67a7f608f1
• Add hotkey hints to editor menus
  Bartłomiej Dach · 2024-09-04 12:16:54 +02:00
  130802e480
• Use FastCircle in demanding places in the editor
  Andrei Zavatski · 2024-08-30 17:45:26 +03:00
  f5a2b5ea03
• Apply NRT to remaining classes in slider blueprint namespace
  Dean Herbert · 2024-08-27 13:18:55 +09:00
  50a8348bf9
• Tidy some thing up
  Dean Herbert · 2024-08-27 13:13:22 +09:00
  4fc96ebfde
• snap the slider duration in normal drag
  OliBomby · 2024-08-21 12:28:56 +02:00
  094b184191
• Merge branch 'master' into free-sliders
  Dean Herbert · 2024-08-19 14:27:54 +09:00
  0c6bee4033
• Merge pull request #29433 from OliBomby/grid-anchors

  Fix grid snap slider placement double-click not making new segment if anchor not hovered

  Dan Balasescu · 2024-08-16 17:42:15 +09:00
  3b94d1f8eb