2742 Commits

• Fix osu!mania legacy skin WidthForNoteHeightScale not being used (#35050)

  * Add osu!mania legacy skin widthForNoteHeightScale
  
  * Ensure WidthForNoteHeightScale correctly defaults to MinimumColumnWidth

  qinvvv · 2025-09-19 10:53:25 +09:00
  b91ff8a5c5
• Add "retro" default skin
  clayton · 2025-09-05 21:21:52 +09:00
  6af48975b0
• Do not pass a whole bunch of InputKey.None down three levels for no reason
  Bartłomiej Dach · 2025-09-03 07:51:52 +02:00
  dc5794dceb
• Change deafult keys to none
  Krystian Ptach-Żurakowski · 2025-09-02 17:53:31 +02:00
  4a193e96e0
• Better secondary keybinds for 10K
  Krystian Ptach-Żurakowski · 2025-08-31 21:19:26 +02:00
  c7f1210281
• Code quality
  Krystian Ptach-Żurakowski · 2025-08-30 20:36:29 +02:00
  08ad27459e
• Add Secondary Keys for Mania
  Krystian Ptach-Żurakowski · 2025-08-30 20:35:51 +02:00
  2fb481e2ee
• refactor(ManiaFilterCriteria): exclude converted beatmaps from long note filter
  Binwalker · 2025-08-26 21:36:20 +09:00
  6a82b7331f
• fix(ManiaFilterCriteria): converted beatmaps are not included
  Binwalker · 2025-08-26 21:36:20 +09:00
  556c2469bf
• feat(ManiaFilterCriteria): add long note ratio filter for mania
  Binwalker · 2025-08-26 21:36:19 +09:00
  68677200f3
• Add and use new mod icon assets
  Bartłomiej Dach · 2025-08-21 09:00:44 +02:00
  92016a7d9b
• Merge pull request #34584 from Hiviexd/verify/refactor-verifier-context

  Refactor `BeatmapVerifierContext`

  Dean Herbert · 2025-08-14 02:28:57 +09:00
  75c72b150e
• initial pass on updated verifier context usage across most checks
  Hivie · 2025-08-11 14:57:14 +01:00
  fd6cf680b9
• Merge branch 'master' into osu!mania-touch-on-desktop
  Salman Alshamrani · 2025-08-11 11:15:16 +03:00
  2d1ca7dacc
• Allow enabling osu!mania touch overlay on non-mobile platforms
  AeroKoder · 2025-08-11 11:09:58 +03:00
  ef972e4a04
• Merge pull request #34500 from frenzibyte/mania-long-notes-sound-broken

  Prevent playing sliding sounds in hold notes when beatmap is not converted

  Bartłomiej Dach · 2025-08-05 11:41:22 +02:00
  619fe60dd1
• Fix grammar in comment
  Bartłomiej Dach · 2025-08-05 10:48:17 +02:00
  50daae399b
• Fix special cases of mania beatmaps not playing sliding samples

  Apparently mania sliders are a thing. See https://github.com/ppy/osu/pull/34500#issuecomment-3150610188

  Salman Alshamrani · 2025-08-05 10:25:39 +03:00
  03dae97ff3
• Clarify "invert" mod cannot possibly play sliding samples
  Salman Alshamrani · 2025-08-04 12:27:57 +03:00
  6d43ae8ac1
• Fix "no release" mod not playing sliding samples in converted beatmaps
  Salman Alshamrani · 2025-08-04 12:27:57 +03:00
  d216256fdf
• Only play hold note sliding samples when beatmap is converted
  Salman Alshamrani · 2025-08-04 12:27:55 +03:00
  4171c3a241
• Adjust some formatting to read better
  Dean Herbert · 2025-08-04 18:20:56 +09:00
  af290ddc0c
• Simplify redundant code
  Bartłomiej Dach · 2025-08-01 12:12:20 +02:00
  b22ca878ba
• Fix mania classic mod impact on hit window not being displayed
  Bartłomiej Dach · 2025-08-01 12:00:41 +02:00
  81cf577670
• Adjust displayed precision to match stable
  Bartłomiej Dach · 2025-08-01 12:00:25 +02:00
  21ef184ae3
• Show effect of beatmap attributes on gameplay metrics in mania
  Bartłomiej Dach · 2025-08-01 11:27:36 +02:00
  e899f0df42
• Fix code quality
  Bartłomiej Dach · 2025-07-30 15:00:55 +02:00
  640fe5752d
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Add new ruleset method responsible for displaying beatmap attributes consistently everywhere

  The intention is to use this in every place that wishes to display
  beatmap attributes (and also remove a bunch of local hack-arounds for
  mania, etc.)

  Bartłomiej Dach · 2025-07-30 13:41:19 +02:00
  e2a454ae00
• remove unused var
  Hivie · 2025-07-28 12:38:16 +01:00
  d5b0c5404c
• apply review
  Hivie · 2025-07-28 12:24:24 +01:00
  8466d64c69
• refactor issue templates to be more unified
  Hivie · 2025-07-24 13:25:15 +01:00
  c0ba8bc997
• Account for almost concurrent case in concurrent objects check
  Hivie · 2025-07-24 13:12:24 +01:00
  806d3160f8
• Merge pull request #34181 from Hiviexd/verify/check-lowest-diff-drain

  Add verify check for lowest diff drain/play time requirements

  Bartłomiej Dach · 2025-07-22 08:38:59 +02:00
  c408d60fbe
• use TimeSpan for defining thresholds
  Hivie · 2025-07-21 12:32:45 +01:00
  86369ab403
• Merge pull request #30506 from smoogipoo/mania-key-mod-multiplier

  Add default multiplier for mania key mods

  Dean Herbert · 2025-07-16 17:20:30 +09:00
  7e373f6410
• Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

  In stable mania, Hard Rock and Easy mods do not work the same way as
  they do on all of the rulesets. The difference is that mania HR and EZ,
  rather than apply a multiplier to the map's original Overall Difficulty,
  apply multipliers to *the durations of hit windows themselves*.
  
  Prior to the last release, lazer was oblivious to this reality and just
  treated mania HR / EZ as it did every other ruleset. Last release, for
  the sake for gameplay parity across rulesets, the mods in question were
  adjusted to match stable, but in the process, it started looking like HR
  / EZ did not change OD anymore.
  
  The problem is that they do, but applying a multiplier to the map's OD
  and applying a multiplier to the hit window duration is not the same
  thing. The second thing is actually *much harsher* in magnitude, to the
  point where applying HR to any map is almost guaranteed to exceed "the
  effective OD" of 10, and applying EZ to any map is almost guaranteed to
  result in "negative effective OD".
  
  This change attempts to convey that reality by displaying "effective
  OD", similar to what's already done in other rulesets when rate-changing
  mods are active. Note that the values this will display *do not match*
  stable *and that is correct*, because stable song select *lies* about
  the actual impact on OD by just assuming it can treat all rulesets in
  the same way.
  
  ---
  
  Would close https://github.com/ppy/osu/issues/34150 I guess.
  
  And yes I would like *all of the above* to land on the changelog if
  possible if this is merged.
  
  For further convincing that this makes any semblance of sense please see
  the following: https://www.desmos.com/calculator/yigt7jycdv

  Bartłomiej Dach · 2025-07-15 09:40:55 +02:00
  131f828e6a
• Add verify check for lowest diff drain time requirement
  Hivie · 2025-07-13 02:00:50 +01:00
  ccf6d9c173
• Fix mania Hard Rock & Easy mods not matching stable

  The implementation in `master` was presuming that Hard Rock and Easy
  worked the same way across all rulesets, but actually, in stable mania,
  the two mods have special treatment as per
  
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L147-L150
  
  The open question here would be what this means for existing scores set
  on lazer using this mod.

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  8e53f47e78
• Support mania-specific hit window quirks

  The quirks in question being that lazer's hit windows in mania preceding
  this change are used in stable *if and only if* Score V2 is active. If
  Score V2 is *not* active, stable has two disparate other sets of hit
  window ranges, dependent on whether the beatmap is a convert or not.
  
  With this commit, those hit windows are used in lazer when the Classic
  mod is active.
  
  Open points for discussion would be:
  
  - What does this mean for plays already set on lazer using the Classic
    mod? Are there even enough of them to care about? Also, on `master`
    the Classic mod does precisely nothing, so maybe such scores should
    just have Classic mod stripped from them?
  
  - What does this mean for the mod multiplier of Classic in mania? (I don't
    expect an answer to this one.)

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  6afdf99df8
• Apply flooring and half-millisecond-adjustments to hit windows

  This is a "two-birds-with-one-stone" change, which addresses both
  https://github.com/ppy/osu/issues/28744 and
  https://github.com/ppy/osu/issues/11311 simultaneously.
  
  - The replay stability issue caused by time instants being rounded to
    nearest integer is fixed by this, because flooring and
    subtracting/adding 0.5 from the hit window threshold makes it
    impossible for a judgement to switch to anything else after replay
    rounding is applied - all hit windows are always a full integer plus
    0.5 milliseconds, which immunizes them to rounding-to-full-ms issues.
  
  - The direction of applying the 0.5 adjustment additionally fixes the
    disparity with stable - in osu! and taiko 0.5 is subtracted as
    hit window ranges in those rulesets are exclusive on stable, while in
    mania 0.5 is added, as the hit window ranges there are *inclusive* on
    stable.
  
  As should be obvious, this materially changes hit windows. To what degree
  this is a *significant* change is up for discussion; I would say "no"
  since hitting half a millisecond changes would require 2000fps input
  recording, and we're still timestamping inputs using the update thread's
  clock, that gives a 1ms resolution at best.
  
  In the worst case, in osu! and taiko, this can change a hit window range
  by 1.5ms (e.g. 300.9ms -> floored to 300ms -> 299.5ms after subtraction
  of the half). It's more than the best-case resolution of input
  timestamps, but not by much. Considering how cleanly this resolves the
  issues in question, I see it as an acceptable tradeoff.

  Bartłomiej Dach · 2025-06-25 11:44:13 +02:00
  0f078ee550
• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Add localisation usage to BeatmapStatistic and revert ShowDetailsMappedBy
  diquoks · 2025-06-21 21:01:48 +03:00
  cad4382350
• Fix drawable hold notes continuing to show hit lighting with No Release mod and classic skin

  Closes https://github.com/ppy/osu/issues/33751.

  Bartłomiej Dach · 2025-06-18 17:59:54 +02:00
  176a85763c
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Make CheckConcurrentObjects.Run virtual

  And let implementers copy-paste common code.

  Derrick Timmermans · 2025-05-26 10:59:57 +02:00
  0495a03607
• Rename ConcurrentCondition to ConcurrencyPrecondition

  Better describes the intent of the method.

  Derrick Timmermans · 2025-05-26 10:59:17 +02:00
  257767b311
• Flip equality in CheckManiaConcurrentObjects

  Bad copy and paste.

  Derrick Timmermans · 2025-05-25 14:35:59 +02:00
  53340fe4b7
• Make CheckConcurrentObject ruleset specific
  Derrick Timmermans · 2025-05-25 14:19:23 +02:00
  0065696248
• Fix incorrect translation of note freezing logic
  Bartłomiej Dach · 2025-05-20 08:58:11 +02:00
  bd703b60f9