1
0
mirror of https://github.com/ppy/osu.git synced 2025-03-13 06:27:21 +08:00

115 Commits

Author SHA1 Message Date
nathen
ad818a492c Increase readability 2024-01-14 20:20:28 -05:00
Natelytle
75c295c228 Remove hit windows scaling by rate, adjust tests 2023-09-04 07:44:44 -04:00
Natelytle
1e80f799b4 Fix non-existent attribute call 2023-08-13 22:55:56 -04:00
Natelytle
4eb307b9da
Merge pull request #1 from Eve-ning/maniastatacc-improve-test
Improves `maniastatacc` branch for Tests
2023-08-13 22:46:56 -04:00
Dan Balasescu
95c72374cd Remove IsConvert difficulty attribute 2023-08-07 21:35:34 +09:00
Natelytle
9cc6a3a4c0 Switch to using deviation on notes and heads for multiplier scaling 2023-08-02 00:51:28 -04:00
Evening
b2ad8ad9b4 Add remark on null & exception throwable 2023-08-02 12:07:26 +08:00
Evening
d00d7fd7a5 Narrow scope of computeEstimatedUr
We narrow it because maniaAttributes is a large dictionary.
If we can narrow down to the primitives that drives computeEstimatedUr, it makes it easier end-users to supply minimal parameters necessary for it to operate.
2023-08-01 19:10:08 +08:00
Evening
515ff5571f Narrow scope of hitWindows fns 2023-08-01 18:41:16 +08:00
Evening
1d7dd8ba99 Expose getHitWindows for tests 2023-08-01 18:37:24 +08:00
Natelytle
c20e1508dd Merge master 2023-07-31 23:11:29 -04:00
Evening
7ed9141d09 Fix incorrect legacyLogPHold function name
Also append that this is only used for legacy holds
2023-07-31 19:57:46 +08:00
Evening
20de476fbb Fix incorrect function name logPNote
The function actually returns the natural log of the probability of each note.
2023-07-31 19:55:28 +08:00
Evening
951861acf5 Shorten property fetching code 2023-07-31 19:27:18 +08:00
Evening
f60317c482 Nest Ternary into Math.Log
This removes the need to call Math.Log twice, improving readability.
I did consider doing NoteCount + (isLeg ? 0 : HoldNoteCount), but I think it deproves readability
2023-07-31 19:19:39 +08:00
Natelytle
a58470d00c Fix stable LN logic 2023-07-31 01:08:19 -04:00
Natelytle
0a72493395 Band-aid math error on stable LNs, add tail deviation multiplier 2023-07-30 00:44:57 -04:00
Dean Herbert
0ab0c52ad5 Automated pass 2023-06-24 01:00:03 +09:00
Natelytle
69b99f6e71 Change curve (again) to fix jittering edge cases 2023-04-18 16:33:04 -04:00
Natelytle
d8d4cc7775 Change curve to clamp PP to <700ur 2023-04-17 17:47:41 -04:00
Natelytle
ec19983726 Update desmos 2023-04-16 22:09:37 -04:00
Natelytle
6ace77ad06 Revert back to previous curve, add more tests 2023-04-16 22:02:33 -04:00
Natelytle
9de2585852 Move comment 2023-04-16 15:53:11 -04:00
Natelytle
d44d8938a4 Rename to IsConvert, add handling for converts below od4 2023-04-16 15:47:32 -04:00
Natelytle
a10dccfcfb Revert to live scaling 2023-04-16 03:17:57 -04:00
Natelytle
4affdc6234 Change UR scaling curve 2023-04-16 02:36:57 -04:00
Natelytle
d0d0aae81a Edit comments 2023-04-15 23:23:30 -04:00
Natelytle
32a3878e8f Add tests 2023-04-15 22:40:06 -04:00
Natelytle
6399b9b5b1 expose hit windows publicly for testing purposes 2023-03-05 21:35:36 -05:00
Natelytle
ab8d19e627 Fix erfc approximation 2023-02-24 21:31:57 -05:00
Natelytle
bfc642ee9b Change types, remove pointless duplicate likelihood function 2023-02-24 21:22:17 -05:00
Natelytle
66529f67b8 Add comments 2023-02-24 00:41:34 -05:00
Natelytle
3a1c47981d Avoid repeated code using structs and methods 2023-02-24 00:03:18 -05:00
Natelytle
4a8d67980c Fix NaNs (whoops) 2023-02-21 18:37:14 -05:00
Natelytle
bafb8f6108 Address abraker's review, add approximation for legacy LN tails 2023-02-21 18:34:38 -05:00
Natelytle
15ca5359a7 Fix incorrect logDiff function, make lazer tail multiplier a const 2023-02-20 18:13:54 -05:00
Natelytle
11f6fd08ac Fix issue with high misscount plays returning 115 UR 2023-02-19 22:35:38 -05:00
Natelytle
06a2358c43 account for mania tests 2023-02-19 17:52:15 -05:00
Natelytle
35119bc5fa Address reviews 2023-02-19 16:33:32 -05:00
Natelytle
08ceb02576 Rename "Judgements" to "HitWindows" 2023-02-19 00:37:53 -05:00
Natelytle
97da8cc2ff Reformatting, increase precision a lot by rewriting in terms of the log of the complement 2023-02-19 00:32:38 -05:00
Natelytle
33a73e3818 update desmos, remove redundant parenthesis 2023-02-17 20:03:55 -05:00
Natelytle
2d7c99b6f3 Massively improve estimation accuracy using a folded distribution 2023-02-17 00:28:09 -05:00
Natelytle
db0fda0638 Remove pointless erf approximation, fix lazer return statement 2023-02-15 23:09:57 -05:00
Natelytle
01dbce6a31 More formatting 2023-02-12 20:00:19 -05:00
Natelytle
9ff4c1b8ef fix const name 2023-02-12 19:44:11 -05:00
Natelytle
5a0aa24ebc Code quality overhaul 2023-02-12 19:05:52 -05:00
Natelytle
fde20e1216 Add desmos links to likelihood functions 2023-02-12 16:42:08 -05:00
Natelytle
b0cd729b88 fix convert OD with lazer judgements 2023-02-11 22:25:39 -05:00
Natelytle
4535b297fb rename method 2023-02-06 17:48:18 -05:00