16833 Commits

• Merge pull request #33191 from peppy/fix-aggressive-diffcalc

  Reduce difficulty calculation churn overheads when using keyboard to iterate quickly at song select

  Dan Balasescu · 2025-05-21 20:48:14 +09:00
  662cbfcc48
• Merge pull request #33203 from frenzibyte/carousel-select-first-visible

  Fix carousel potentially selecting filtered difficulty

  Dean Herbert · 2025-05-21 18:15:48 +09:00
  275dcca4b5
• Use better method to select first difficulty
  Salman Alshamrani · 2025-05-20 21:42:19 +03:00
  59b0ab7f46
• Merge pull request #33207 from frenzibyte/ssv2-hook-mod-to-selected-beatmap

  SongSelectV2: Hook mod select overlay to selected beatmap

  Dean Herbert · 2025-05-21 00:38:36 +09:00
  c5ec25358d
• Merge pull request #33205 from frenzibyte/carousel-disable-status-animation

  Disable status pill animation on carousel panels

  Dean Herbert · 2025-05-21 00:37:49 +09:00
  420a49b812
• Add property to allow disabling status pill animation
  Salman Alshamrani · 2025-05-21 00:37:08 +09:00
  c565b76b6e
• Merge pull request #33202 from frenzibyte/hidden-beatmap-difficulties

  Fix hidden beatmap difficulties not handled in new carousel

  Dean Herbert · 2025-05-21 00:33:36 +09:00
  875414a47a
• Hook mod select overlay to selected beatmap
  Salman Alshamrani · 2025-05-20 01:14:42 +03:00
  fc436553a8
• Merge branch 'master' into iss32064
  Nuno Pelágio · 2025-05-19 21:17:23 +01:00
  7893b885c5
• Fix carousel potentially selecting filtered diff when clicking set panel
  Salman Alshamrani · 2025-05-19 22:33:24 +03:00
  e2e156c6ba
• Fix hidden beatmap difficulties not handled in new carousel
  Salman Alshamrani · 2025-05-19 22:02:41 +03:00
  ce1da54af4
• Fix ppy#32064: Fixed Formatting.
  Nuno Pelagio · 2025-05-19 20:00:24 +01:00
  dc86b77f80
• Fix case where there's only one player causing NaN

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-05-19 18:25:41 +09:00
  962ec3dca0
• Fix multiplayer position display looking wrong when player count is low

  Spotted when watching video in #33173's opening post.

  Dean Herbert · 2025-05-19 16:58:01 +09:00
  beb77176b6
• Add animation to star rating display in new carousel

  Also matches the animation speed of `StarRatingDisplay` with
  `StarCounter` as they are regularly displayed together.

  Dean Herbert · 2025-05-19 16:30:58 +09:00
  eb29c45513
• Aggressively cancel difficulty calculation for new beatmap carousel usages

  This was already being done on the old carousel (see `ApplyState`
  methods) but wasn't correctly on new carousel.
  
  Importantly, `FreeAfterUse` alone is not enough due to transitions. We
  want to immediately stop calculation as soon as a panel is marked
  non-visible.
  
  There's no bindable flow for this so it's performed in `Update`. I don't
  see this as an issue.

  Dean Herbert · 2025-05-19 16:18:54 +09:00
  3a532013ac
• Add debounce to difficulty calculation operations in churn scenarios
  Dean Herbert · 2025-05-19 16:16:33 +09:00
  192a1642d4
• Fix footer buttons not restoring when exiting an already displayed screen

  Closes https://github.com/ppy/osu/issues/33168.

  Dean Herbert · 2025-05-18 16:53:33 +09:00
  bec3450a44
• Remove song select background scale for now

  Based on some negative feedback which I can agree with.

  Dean Herbert · 2025-05-18 16:00:10 +09:00
  159a09fdc5
• Merge branch 'master' into ssv2-score-opens-results
  Bartłomiej Dach · 2025-05-16 13:23:38 +02:00
  ea55fa2703
• Rename new song select interface to be more generic and add score presentation to it
  Dean Herbert · 2025-05-16 18:22:42 +09:00
  bc35b58db6
• Open results screen when clicking leaderboard scores
  Salman Alshamrani · 2025-05-16 18:22:42 +09:00
  4ec4923c17
• SongSelectV2: Add support for deselecting all mods by right clicking mod button

  Addresses https://github.com/ppy/osu/discussions/28301.
  
  No sound effects on click because right click handling is weird. I would
  have liked to call `DeselectAll` on the mod select overlay, but this
  doesn't work unless it's displayed due to queued operation.

  Dean Herbert · 2025-05-16 18:22:25 +09:00
  a8b247f7f1
• Tidy up TestSceneFooterButtonMods tests
  Dean Herbert · 2025-05-16 15:04:45 +09:00
  45d248cd26
• Hook up footer beatmap options via new ISongSelectBeatmapActions class
  Dean Herbert · 2025-05-15 20:31:54 +09:00
  9fea4a2ed0
• Fix screen footer buttons not having access to screen dependencies
  Dean Herbert · 2025-05-15 20:27:51 +09:00
  5a17d3c290
• Merge branch 'master' into tidy-screen-footer
  Bartłomiej Dach · 2025-05-15 12:55:28 +02:00
  0132b78eec
• Merge pull request #33141 from frenzibyte/footer-fix-back-button

  Fix back button not displaying when transitioning to non-footer screen

  Dean Herbert · 2025-05-15 19:34:58 +09:00
  7f16feb92c
• Tidy up ScreenFooter and back button action flow
  Dean Herbert · 2025-05-15 18:37:42 +09:00
  087e054708
• Improve code quality
  Salman Alshamrani · 2025-05-15 12:26:28 +03:00
  60f56a0729
• Code quality fixes
  Dean Herbert · 2025-05-15 12:14:54 +03:00
  bb8d3bcf66
• Remove pointless dependency from ScreenFooter
  Dean Herbert · 2025-05-15 17:18:28 +09:00
  856693d7ee
• Allow starting beatmap with autoplay via ctrl-enter
  Salman Alshamrani · 2025-05-15 17:01:23 +09:00
  8e7c093476
• Merge pull request #33067 from frenzibyte/full-sorting-support

  Implement complete sorting mode support

  Dean Herbert · 2025-05-15 03:44:26 +09:00
  5939f51558
• Move dependency to correct class and use more appropriate name
  Dean Herbert · 2025-05-15 01:55:49 +09:00
  5eb14a5b26
• Expose general song select operations
  Salman Alshamrani · 2025-05-14 15:43:44 +03:00
  8fe422c35a
• Merge branch 'master' into full-sorting-support
  Bartłomiej Dach · 2025-05-14 14:42:29 +02:00
  a57ca72ccf
• Implement complete sorting mode support
  Salman Alshamrani · 2025-05-14 19:21:57 +09:00
  1a02e3266b
• Allow accessing song select v2 by holding control while entering song select
  Dean Herbert · 2025-05-14 17:06:18 +09:00
  0a3f05c52b
• Merge pull request #33120 from frenzibyte/ssv2-cache-class

  SongSelectV2: Fix `SongSelect` not cached for subcomponents

  Dean Herbert · 2025-05-14 10:47:01 +09:00
  93fda73062
• Fix SongSelect not cached for subcomponents
  Salman Alshamrani · 2025-05-13 15:32:44 +03:00
  74d10e2a62
• Apply mod adjustments to beatmap track
  Salman Alshamrani · 2025-05-13 15:24:18 +03:00
  bd136b88c6
• Merge pull request #32972 from bdach/multiplayer-position-indicator

  Add non-skinnable position indicator to multiplayer player

  Dean Herbert · 2025-05-13 20:53:15 +09:00
  3ce5389558
• Allow scrolling to adjust volume
  Salman Alshamrani · 2025-05-13 14:08:12 +03:00
  0b6e36d61e
• Fix multiplayer position display not hiding on user change
  Bartłomiej Dach · 2025-05-13 11:47:01 +02:00
  1d3f4ac02b
• Merge pull request #33056 from frenzibyte/fix-difficulty-sorting

  Display separate design for beatmap panels on difficulty sort mode

  Dean Herbert · 2025-05-13 18:43:57 +09:00
  2dceee8ba9
• Fix code inspection
  Bartłomiej Dach · 2025-05-13 11:37:52 +02:00
  79f88528ae
• Merge pull request #33111 from peppy/fix-letterbox-rewind

  Fix letterbox overlay potentially fading incorrectly during seeks

  Bartłomiej Dach · 2025-05-13 11:18:38 +02:00
  464ad4ec77
• Display separate design for beatmap panels on difficulty sort mode
  Salman Alshamrani · 2025-05-13 17:58:18 +09:00
  f58cf8e971
• Merge pull request #33114 from bdach/solo-results-dont-show-best-if-beat

  Do not show previous best score on solo results screen if the local user just beat it

  Dean Herbert · 2025-05-13 17:50:45 +09:00
  a360f153f7