5551 Commits

• Also perform time-based frame de-duplication at frame bundle level

  See https://github.com/ppy/osu/pull/33148#discussion_r2092467082

  Bartłomiej Dach · 2025-05-16 09:39:29 +02:00
  baf069ccf7
• Do not emit multiple consequent replay frames with the exact same data

  With judgements occurring forcing emission of important frames, there's
  the question of emitting redundant frames. In a majority of cases
  still, a judgement *will* be tied to a specific user input, which means
  that there's a high likelihood of duplicate frames, as one will be
  emitted by the input change, and another by the judgement.
  
  To a degree this is a pre-existing issue. The replay recording code
  responds to both mouse movement and key presses by recording frames, so
  depending on the intrinsic (basically undefined) ordering between
  handling mouse move and key presses, it was possible for multiple frames
  to be emitted with the same timestamp to the replay, each containing
  partial input state changes (e.g. first frame with mouse position
  changed, and the second with a key pressed).
  
  The extent to which this increases the frame count will obviously depend
  on the beatmap, but in my ballpark testing across all rulesets on a
  single "relatively standard" beatmap (think no aspire chicanery), around
  4-10% of frames can end up being duplicates / not meaningful. This has
  implications both on replay size and on playback performance.
  
  This commit therefore performs de-duplication of the frames based on
  timestamp - only the last frame with a given timestamp ends up in the
  final replay.
  
  The CPU cost of this is negligible to the point of not being useful to
  profile - it's a single condition gated behind a single float comparison

  Bartłomiej Dach · 2025-05-16 08:40:07 +02:00
  cd4ab9307c
• Emit important replay frames on every judgement

  - Closes https://github.com/ppy/osu/issues/4287
  - Probably closes https://github.com/ppy/osu/issues/25405 (but not
    retroactively)
  
  Up until now, whether or not a replay frame is emitted depended solely
  on the user's input, i.e. mouse movement or key presses/releases. This,
  intersected with the replay playback system which is given allowance to
  perform interpolation between replay frames, leads to potential
  situations wherein a replay can play inaccurately when a judgement takes
  place without user input meaningfully changing. One such case is slider
  ends with their 36ms of judgement leniency; see
  https://github.com/ppy/osu/issues/25405#issuecomment-2879031106 for
  details on that.
  
  To that end, this commit aims to counteract that issue by *forcing* an
  important replay frame to be emitted on every new judgement recorded
  during gameplay. This will only benefit rulesets wherein judgements can
  occur that are not inherently tied to user input changing, which are
  going to be osu! as mentioned above, and maybe possibly catch. I don't
  foresee this doing anything relevant for taiko or mania.

  Bartłomiej Dach · 2025-05-15 11:43:09 +02:00
  9f91c2e25c
• Remove unnecessary replay recorder depth hack

  Addresses https://github.com/ppy/osu/pull/33102#discussion_r2087963889.

  Bartłomiej Dach · 2025-05-14 11:25:31 +02:00
  acebf3e95e
• Merge pull request #33104 from frenzibyte/adjust-pitch-tooltip

  Fix rate adjust / time ramp mods not showing "Adjust pitch" in tooltip

  Dean Herbert · 2025-05-13 15:11:26 +09:00
  cb59e5acbf
• Change implementation to match other implementations

  The previous version was confusing to read.

  Dean Herbert · 2025-05-13 15:10:59 +09:00
  7918685c4e
• Fix rate adjust / time ramp mods not showing "Adjust pitch" in tooltip
  Salman Alshamrani · 2025-05-12 15:14:26 +03:00
  9c77a3e74f
• Fix mod tooltip not handling settings changes to same mod instance
  Salman Alshamrani · 2025-05-12 15:04:51 +03:00
  d5be4bf8d4
• Allow any hit result for empty hit windows

  It's really going to return zero anyway even if given a "supported"
  one, so probably fine?

  Bartłomiej Dach · 2025-05-09 10:31:00 +02:00
  bf86878597
• Fix HitWindows.WindowFor() returning values for invalid results

  This fell out of my work on hit window-related replay issues. In my WIP
  branch (that is probably going to get PR'd as draft soon) I refactored
  `HitWindows` and found a few straggling test failures due to some places
  reading hit windows for results that were not actually supported by the
  underlying `HitWindows` implementations, leading to returning garbage
  (mostly zeroes).
  
  Importantly, there is one actual usage in game code with impact here -
  `TaikoModSingleTap` was attempting to read the hit window for MEH, when
  MEH was never actually a valid hit result in taiko (OK is). This was a
  result of a copy-paste oversight from osu!, specifically from
  
  	https://github.com/ppy/osu/blob/51cf835fb6300aca53b5b98143d606f64d7a4d49/osu.Game.Rulesets.Osu/Mods/InputBlockingMod.cs#L58

  Bartłomiej Dach · 2025-05-09 09:40:20 +02:00
  ceb58a1141
• Merge pull request #32970 from peppy/mod-icon-improvements

  Improve visibility of setting adjustments on mod icons

  Dean Herbert · 2025-04-30 17:21:12 +09:00
  373a74da4b
• Move UserAdjustedSettingsCount local to ModDifficultyAdjust in absence of other usages
  Dean Herbert · 2025-04-30 16:04:26 +09:00
  a397737476
• Fix adjustment marker not updating when settings' states change
  Dean Herbert · 2025-04-30 13:04:50 +09:00
  0c5193ba59
• Don't bother with localised implementation of AdjustedSettingsCount

  I was avoiding using reflection to save on overheads, but it's probably
  not worth it.

  Dean Herbert · 2025-04-30 12:58:40 +09:00
  babccca2bb
• Add xmldoc note explaining new flag is instantaneous state
  Dean Herbert · 2025-04-30 12:49:39 +09:00
  14d0565194
• Adjust colours to match icon better
  Dean Herbert · 2025-04-30 12:48:07 +09:00
  713fbfb2c8
• Show marker when settings are adjusted
  Dean Herbert · 2025-04-28 18:14:14 +09:00
  1e8d9b3482
• Show singular difficulty adjust modifications inline in mod icons
  Dean Herbert · 2025-04-28 16:58:16 +09:00
  c16514274d
• Simplify taglib interactions further
  Dean Herbert · 2025-04-28 15:52:31 +09:00
  40faa3fc99
• Add manual MIME type resolution for TagLib file creation
  Stedoss · 2025-04-28 13:38:38 +09:00
  c2efda20d7
• Merge branch 'master' into freestyle-mods
  Bartłomiej Dach · 2025-04-23 13:49:32 +02:00
  6da4e09717
• Fix rate adjust no longer showing the rate if custom

  "Accidentally" removed in 6e635f124a
  apparently.

  Bartłomiej Dach · 2025-04-18 14:03:32 +02:00
  5791375b38
• Improve IMod documentation
  Dan Balasescu · 2025-04-17 18:32:35 +09:00
  92267c8bb3
• Use IMod documentation where present
  Dan Balasescu · 2025-04-17 18:32:26 +09:00
  95cf4887e1
• Apply changes from reviews
  Dan Balasescu · 2025-04-17 02:19:31 +09:00
  64aafa4e4c
• Adjust property name
  Dan Balasescu · 2025-04-14 19:34:33 +09:00
  35ee4b6f24
• Only apply freestyle validation to required mods
  Dan Balasescu · 2025-04-14 19:34:21 +09:00
  b4c7d7f498
• Revert "Use median for statistic display"

  This reverts commit fa06643bb6.
  
  Revert "Remove mean hit error calculation"
  
  This reverts commit b3c578e545.

  Dean Herbert · 2025-04-11 02:12:40 +09:00
  ba5932c1dd
• Allow classic mod in freestyle
  Dan Balasescu · 2025-04-10 13:05:17 +09:00
  c6e368d3ea
• Merge pull request #32723 from sineplusx/fix-multi-chat-hint

  Use actual keybind in multiplayer chat hint

  Bartłomiej Dach · 2025-04-09 09:29:12 +02:00
  c5eda87ac3
• Move key binding string retrieval to RealmKeyBindingStore
  Dean Herbert · 2025-04-09 15:23:55 +09:00
  9e90f80ab5
• Merge branch 'master' into freestyle-mods
  Dan Balasescu · 2025-04-08 19:57:28 +09:00
  1c060f986c
• Remove obsoleted overload of ApplyResult
  Dean Herbert · 2025-04-08 15:47:30 +09:00
  5d572e1ab2
• Disable incorrect cancellation token inspection
  Dean Herbert · 2025-04-07 20:12:49 +09:00
  2dc38b5f09
• Merge pull request #32675 from peppy/disable-scroll-adjust-during-gameplay

  Disallow adjusting scroll speed during gameplay

  Bartłomiej Dach · 2025-04-07 11:05:58 +02:00
  82c52918c8
• Resolve test failures
  Dan Balasescu · 2025-04-04 23:17:16 +09:00
  319e3db14e
• Fix thread-race leading to OnScreenDisplay crash
  Dan Balasescu · 2025-04-04 22:48:33 +09:00
  abfda9cbcd
• Disallow adjusting scroll speed during gameplay

  Matches stable. Addresses https://github.com/ppy/osu/discussions/32670.

  Dean Herbert · 2025-04-04 19:46:14 +09:00
  32c60bfb36
• Allow more mods in freestyle
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  3a56f59749
• Allow specifying mod compatibility with freestyle
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  ef0cf5143d
• Merge pull request #32593 from peppy/less-sample-overhead-during-silly-sliders

  Fix stutters when sliders with hundreds of repeats display for the first time

  Bartłomiej Dach · 2025-04-03 12:31:46 +02:00
  f11d3ddb5c
• Remove left-over scheduling thing
  Dean Herbert · 2025-04-03 16:17:29 +09:00
  b471750812
• Remove mean hit error calculation
  sineplusx · 2025-03-29 13:45:39 +01:00
  b3c578e545
• Add comment
  sineplusx · 2025-03-26 17:22:57 +01:00
  6452514066
• Use median instead of mean for automatic beatmap offset adjustment
  sineplusx · 2025-03-26 15:41:48 +01:00
  bb8f8e8d8c
• Avoid large sample depool overhead on drawable hitobjects with many nested objects

  Closes https://github.com/ppy/osu/issues/32588.

  Dean Herbert · 2025-03-26 18:45:12 +09:00
  78de898f7f
• Introduce rich mod tooltip
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  9b55325526
• Change SettingDescription to differentiate between settings and values
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  6e635f124a
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Fix edge case allowing almost-zero-length sliders to be placed during distance snapping
  Dean Herbert · 2025-03-11 16:17:44 +09:00
  23891b1994