46738 Commits

• Merge pull request #33191 from peppy/fix-aggressive-diffcalc

  Reduce difficulty calculation churn overheads when using keyboard to iterate quickly at song select

  Dan Balasescu · 2025-05-21 20:48:14 +09:00
  662cbfcc48
• Resolve inspections
  Dan Balasescu · 2025-05-21 20:00:05 +09:00
  f967091aad
• Merge pull request #33203 from frenzibyte/carousel-select-first-visible

  Fix carousel potentially selecting filtered difficulty

  Dean Herbert · 2025-05-21 18:15:48 +09:00
  275dcca4b5
• Use better method to select first difficulty
  Salman Alshamrani · 2025-05-20 21:42:19 +03:00
  59b0ab7f46
• Merge pull request #33207 from frenzibyte/ssv2-hook-mod-to-selected-beatmap

  SongSelectV2: Hook mod select overlay to selected beatmap

  Dean Herbert · 2025-05-21 00:38:36 +09:00
  c5ec25358d
• Merge pull request #33205 from frenzibyte/carousel-disable-status-animation

  Disable status pill animation on carousel panels

  Dean Herbert · 2025-05-21 00:37:49 +09:00
  420a49b812
• Add property to allow disabling status pill animation
  Salman Alshamrani · 2025-05-21 00:37:08 +09:00
  c565b76b6e
• Merge pull request #33202 from frenzibyte/hidden-beatmap-difficulties

  Fix hidden beatmap difficulties not handled in new carousel

  Dean Herbert · 2025-05-21 00:33:36 +09:00
  875414a47a
• Add very basic transition for DifficultyIcon colour changes
  Dean Herbert · 2025-05-20 22:12:03 +09:00
  d9c376067d
• Hook mod select overlay to selected beatmap
  Salman Alshamrani · 2025-05-20 01:14:42 +03:00
  fc436553a8
• Merge branch 'master' into iss32064
  Nuno Pelágio · 2025-05-19 21:17:23 +01:00
  7893b885c5
• Fix carousel potentially selecting filtered diff when clicking set panel
  Salman Alshamrani · 2025-05-19 22:33:24 +03:00
  e2e156c6ba
• Fix hidden beatmap difficulties not handled in new carousel
  Salman Alshamrani · 2025-05-19 22:02:41 +03:00
  ce1da54af4
• Fix ppy#32064: Fixed Formatting.
  Nuno Pelagio · 2025-05-19 20:00:24 +01:00
  dc86b77f80
• Fix case where there's only one player causing NaN

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-05-19 18:25:41 +09:00
  962ec3dca0
• Fix multiplayer position display looking wrong when player count is low

  Spotted when watching video in #33173's opening post.

  Dean Herbert · 2025-05-19 16:58:01 +09:00
  beb77176b6
• Merge pull request #33189 from peppy/fix-clock-animation

  Fix analog clock animation not animating when hand crosses zero

  Bartłomiej Dach · 2025-05-19 09:39:45 +02:00
  34e5c7ee42
• Add animation to star rating display in new carousel

  Also matches the animation speed of `StarRatingDisplay` with
  `StarCounter` as they are regularly displayed together.

  Dean Herbert · 2025-05-19 16:30:58 +09:00
  eb29c45513
• Aggressively cancel difficulty calculation for new beatmap carousel usages

  This was already being done on the old carousel (see `ApplyState`
  methods) but wasn't correctly on new carousel.
  
  Importantly, `FreeAfterUse` alone is not enough due to transitions. We
  want to immediately stop calculation as soon as a panel is marked
  non-visible.
  
  There's no bindable flow for this so it's performed in `Update`. I don't
  see this as an issue.

  Dean Herbert · 2025-05-19 16:18:54 +09:00
  3a532013ac
• Start with known star rating for no-mod-no-convert rather than zero

  This makes displays look better, even if it's incorrect momentarily.

  Dean Herbert · 2025-05-19 16:18:54 +09:00
  01edee123f
• Add debounce to difficulty calculation operations in churn scenarios
  Dean Herbert · 2025-05-19 16:16:33 +09:00
  192a1642d4
• Merge pull request #33178 from peppy/fix-footer-button-thing

  Fix footer buttons not restoring when exiting an already displayed screen

  Bartłomiej Dach · 2025-05-19 09:02:07 +02:00
  5ae39819b6
• Merge pull request #33162 from smoogipoo/photon-release

  Add "Tachyon" (unstable) release stream

  Dean Herbert · 2025-05-19 15:27:35 +09:00
  c339977e98
• Fix analog clock animation not animating when hand crosses zero

  Pointed out in
  [discord](https://discord.com/channels/188630481301012481/188630652340404224/1373836064313180200).

  Dean Herbert · 2025-05-19 15:08:15 +09:00
  8aedfb81ff
• Fix footer buttons not restoring when exiting an already displayed screen

  Closes https://github.com/ppy/osu/issues/33168.

  Dean Herbert · 2025-05-18 16:53:33 +09:00
  bec3450a44
• Remove song select background scale for now

  Based on some negative feedback which I can agree with.

  Dean Herbert · 2025-05-18 16:00:10 +09:00
  159a09fdc5
• Add confirmation dialog before switching to unstable release stream
  Dean Herbert · 2025-05-18 03:57:53 +09:00
  b6ce627bc7
• Change release strem name to tachyon
  Dean Herbert · 2025-05-18 01:35:28 +09:00
  06b61ed5f5
• Merge pull request #33148 from bdach/emit-important-replay-frames-on-judgements

  Emit important replay frames on every judgement

  Dean Herbert · 2025-05-17 23:41:12 +09:00
  8c053e856f
• Add matching comment in SpectatorClient for clarity
  Dean Herbert · 2025-05-17 23:33:46 +09:00
  7c44883042
• Merge pull request #33161 from bdach/replay-decode-float-woes

  Fix possible replay playback inaccuracy with very large lead-in time

  Dean Herbert · 2025-05-17 12:31:38 +09:00
  6346cff380
• Add "Photon" release stream
  Dan Balasescu · 2025-05-16 21:03:07 +09:00
  2c4666c896
• Merge branch 'master' into ssv2-score-opens-results
  Bartłomiej Dach · 2025-05-16 13:23:38 +02:00
  ea55fa2703
• Merge pull request #33160 from peppy/carousel-animation-fixes

  Fix multiple inconsistencies in beatmap carousel animations

  Bartłomiej Dach · 2025-05-16 13:20:56 +02:00
  31fe6e4ec0
• Fix possible replay playback inaccuracy with very large lead-in time

  Closes https://github.com/ppy/osu/issues/22086
  
  While this *is* a case of aspire-tier breakage, I hesitate to dismiss it
  as wontfix, because the fix is somewhat easy, and probably results in
  better accuracy across the board.
  
  The issue in question here manifests when there is a significant amount
  of lead-in time, like what the beatmap linked in the aforementioned
  issue (https://osu.ppy.sh/beatmapsets/948643#osu/1981090) does.
  
  Both stable and lazer record replay frames using absolute timestamps,
  *but* the legacy replay format after the first frame uses time *deltas*,
  i.e. amounts of time elapsed since the previous frame. This means that
  the decoding process of the replay has to reconstruct absolute timestamps
  by doing cumulative summation starting from the first frame.
  
  When the very first frame has a timestamp that is very large in
  magnitude (say, like the negative 2 billion that the beatmap in question
  uses), this will lead to error if the cumulative summation is using
  floating point numbers, because it will be adding a small magnitude
  frame delta to a large magnitude cumulative absolute time. Which means
  that sometimes adding the frame delta to the cumulative time *will not
  change the cumulative time*, leading to the loss of time and thus replay
  de-synchronisation.
  
  Knowing that the legacy replay format only deals in integral time
  values, however, this can be circumvented by just using a large enough
  integral number type for the cumulative time tracking instead. I think
  `long` in this case can be safely used "large enough" for our purposes:
  
  	> Console.WriteLine(long.MaxValue);
  	9223372036854775807
  
  	9 223 372 036 854 775 807 ms equals 292 277 024,6269277149 years

  Bartłomiej Dach · 2025-05-16 12:52:49 +02:00
  56e17dd7ba
• Add failing test case
  Bartłomiej Dach · 2025-05-16 12:45:47 +02:00
  8854db0264
• Use larger offset to ensure depth is still backmost even with DepthLayer is in use
  Dean Herbert · 2025-05-16 19:08:54 +09:00
  bfc23c98f1
• Rename new song select interface to be more generic and add score presentation to it
  Dean Herbert · 2025-05-16 18:22:42 +09:00
  bc35b58db6
• Open results screen when clicking leaderboard scores
  Salman Alshamrani · 2025-05-16 18:22:42 +09:00
  4ec4923c17
• SongSelectV2: Add support for deselecting all mods by right clicking mod button

  Addresses https://github.com/ppy/osu/discussions/28301.
  
  No sound effects on click because right click handling is weird. I would
  have liked to call `DeselectAll` on the mod select overlay, but this
  doesn't work unless it's displayed due to queued operation.

  Dean Herbert · 2025-05-16 18:22:25 +09:00
  a8b247f7f1
• Avoid animating list tail

  At very high scroll speeds (using pageup/pagedown) you would see a weird
  animation of panels appearing. This removes the animation for that edge
  case.

  Dean Herbert · 2025-05-16 17:45:32 +09:00
  a32da2ea10
• Add new panels to carousel with a better initial Y position

  Previously, carousel panels would appear immediately at their required Y
  position. This didn't look great when they appear with other panels
  surrounding them.
  
  Now they will spawn in underneath the nearest item before them, making
  the animation feel much more correct.

  Dean Herbert · 2025-05-16 17:23:08 +09:00
  615d4accfb
• Add fade animation when carousel panels are expired

  This fixes the hard cut that was previously very jarring.

  Dean Herbert · 2025-05-16 17:21:49 +09:00
  6a2337dbea
• Fix depth flip-flopping during initial animation
  Dean Herbert · 2025-05-16 17:14:27 +09:00
  7efa724a8a
• Remove misplaced assert
  Dean Herbert · 2025-05-16 17:14:11 +09:00
  0302a37190
• Also perform time-based frame de-duplication at frame bundle level

  See https://github.com/ppy/osu/pull/33148#discussion_r2092467082

  Bartłomiej Dach · 2025-05-16 09:39:29 +02:00
  baf069ccf7
• Do not emit multiple consequent replay frames with the exact same data

  With judgements occurring forcing emission of important frames, there's
  the question of emitting redundant frames. In a majority of cases
  still, a judgement *will* be tied to a specific user input, which means
  that there's a high likelihood of duplicate frames, as one will be
  emitted by the input change, and another by the judgement.
  
  To a degree this is a pre-existing issue. The replay recording code
  responds to both mouse movement and key presses by recording frames, so
  depending on the intrinsic (basically undefined) ordering between
  handling mouse move and key presses, it was possible for multiple frames
  to be emitted with the same timestamp to the replay, each containing
  partial input state changes (e.g. first frame with mouse position
  changed, and the second with a key pressed).
  
  The extent to which this increases the frame count will obviously depend
  on the beatmap, but in my ballpark testing across all rulesets on a
  single "relatively standard" beatmap (think no aspire chicanery), around
  4-10% of frames can end up being duplicates / not meaningful. This has
  implications both on replay size and on playback performance.
  
  This commit therefore performs de-duplication of the frames based on
  timestamp - only the last frame with a given timestamp ends up in the
  final replay.
  
  The CPU cost of this is negligible to the point of not being useful to
  profile - it's a single condition gated behind a single float comparison

  Bartłomiej Dach · 2025-05-16 08:40:07 +02:00
  cd4ab9307c
• Tidy up TestSceneFooterButtonMods tests
  Dean Herbert · 2025-05-16 15:04:45 +09:00
  45d248cd26
• Fix line lost in merge resolution causing footer to disappear
  Dean Herbert · 2025-05-15 21:37:53 +09:00
  bc5c222953
• Hook up footer beatmap options via new ISongSelectBeatmapActions class
  Dean Herbert · 2025-05-15 20:31:54 +09:00
  9fea4a2ed0