Dean Herbert
554884710c
Rename classes for better discoverability / grouping
2025-02-12 19:34:42 +09:00
Dean Herbert
3a0464299a
Remove unnecessary V2 suffixes
2025-02-12 19:22:57 +09:00
Dean Herbert
bc94ffe21e
Merge branch 'master' into freestyle-mods
2025-02-12 18:32:01 +09:00
Dean Herbert
9c3e9e7c55
Change free mods button to show "all" when freestyle is enabled
2025-02-12 18:27:10 +09:00
Dan Balasescu
8c85616d1c
Fix test
2025-02-11 21:28:21 +09:00
Dan Balasescu
38cd4fa56a
Merge branch 'master' into room-management-lio
2025-02-11 21:19:32 +09:00
Bartłomiej Dach
ad642b8425
Fix spectator list showing other users in multiplayer room even if they're not spectating
2025-02-10 11:17:17 +01:00
Bartłomiej Dach
1afd1f5000
Merge branch 'master' into bss/the-actual-submission
2025-02-07 15:30:37 +01:00
Dean Herbert
5ace8e911b
Fix failing test
2025-02-07 21:46:00 +09:00
Dean Herbert
d8f3dbf988
Merge branch 'master' into carousel-v2-implement-designs
2025-02-07 19:37:06 +09:00
Layendan
aad12024b0
remove using cache, improve tests, and revert loading
2025-02-07 03:13:51 -07:00
Bartłomiej Dach
a068d88b84
Merge pull request #31823 from peppy/carousel-v2-optimisation-pass
...
Refactor grouping to be much more efficient
2025-02-07 10:44:53 +01:00
Bartłomiej Dach
ae179c8feb
Merge pull request #31824 from peppy/carousel-v2-group-click-transfer-keyboard
...
Always transfer keyboard selection on activation
2025-02-07 10:12:10 +01:00
Dean Herbert
bf57fef412
Fix missing cached settings in BetamapSubmissionOverlay test
2025-02-07 17:50:32 +09:00
Dean Herbert
cf4b501214
Merge pull request #31804 from bdach/bss/api-setup
...
Add API request & response structures for beatmap submission
2025-02-07 17:43:38 +09:00
Bartłomiej Dach
9af5ebbca9
Merge pull request #31822 from peppy/dont-submit-zero-scores
...
Don't attempt to submit zero scores
2025-02-07 09:42:38 +01:00
Dean Herbert
177ca4fb7c
Merge pull request #31799 from frenzibyte/carousel-v2-spacing
...
Support variable spacing between beatmap carousel panels
2025-02-07 17:41:28 +09:00
Dean Herbert
41c8f64806
Simplify naming of endpoints
2025-02-07 17:33:32 +09:00
Dean Herbert
cef9d2eac5
Reduce number of beatmaps added in selection test
...
This is because with the new keyboard selection logic, adding too many
can cause the re-added selection to be off-screen in the headless test
setup.
2025-02-07 17:02:53 +09:00
Dean Herbert
c935c3154b
Always transfer keyboard selection on activation
2025-02-07 17:02:53 +09:00
Bartłomiej Dach
a49b1b61b4
Add test coverage for scores with zero total not submitting
2025-02-07 08:21:34 +01:00
Dean Herbert
75ef6f6a0e
Use random generation in carousel stress test
2025-02-07 16:09:35 +09:00
Dean Herbert
0235928fda
Merge pull request #31815 from smoogipoo/score-panel-ruleset
...
Add ruleset icon to expanded score panel
2025-02-07 16:04:24 +09:00
Dean Herbert
aa329f397e
Remove stray [Solo]s
2025-02-07 15:30:31 +09:00
Dean Herbert
d505c529cd
Adjust tests in line with new expectations
2025-02-07 15:27:28 +09:00
Dean Herbert
1cf375e329
Merge branch 'master' into carousel-v2-spacing
2025-02-07 14:34:59 +09:00
Dean Herbert
25846b2327
Adjust results screen designs and tests slightly
2025-02-07 14:21:43 +09:00
Layendan
b7483b9442
Add playlist collection button w/ tests
2025-02-06 07:25:45 -07:00
Bartłomiej Dach
91bc23e39e
Merge pull request #31801 from peppy/carousel-v2-artist-grouping
...
Add support for grouping by artist to beatmap carousel v2
2025-02-06 13:13:35 +01:00
Dean Herbert
33035f0206
Merge branch 'master' into carousel-v2-spacing
2025-02-06 17:30:49 +09:00
Salman Alshamrani
05a9160884
Simplify LINQ expressions to appease CI
...
don't ask me
2025-02-06 03:10:21 -05:00
Dean Herbert
024fbde0fd
Refactor selection and activation handling
...
I had a bit of a struggle getting header traversal logic to work well.
The constraints I had in place were a bit weird:
- Group panels should toggle or potentially fall into the prev/next
group
- Set panels should just traverse around them
The current method of using `CheckValidForGroupSelection` return type
for traversal did not mesh with the above two cases. Just trust me on
this one since it's quite hard to explain in words.
After some re-thinking, I've gone with a simpler approach with one
important change to UX: Now when group traversing with a beatmap set
header currently keyboard focused, the first operation will be to reset
keyboard selection to the selected beatmap, rather than traverse.
I find this non-offensive – at most it means a user will need to press
their group traversal key one extra time.
I've also changed group headers to always toggle expansion when doing
group traversal with them selected.
To make all this work, the meaning of `Activation` has changed somewhat.
It is now the primary path for carousel implementations to change
selection of an item. It is what the `Drawable` panels call when they
are clicked.
Selection changes are not performed implicitly by `Carousel` – an
implementation should decide when it actually wants to change the
selection, usually in `HandleItemActivated`.
Having less things mutating `CurrentSelection` is better in my eyes, as
we see this variable as only being mutated internally when utmost
required (ie the user has requested the change). With this change,
`CurrentSelection` can no longer become of a non-`T` type (in the
beatmap carousel implementation at least).
This might pave a path forward for making `CurrentSelection` typed, but
that comes with a few other concerns so I'll look at that as a
follow-up.
2025-02-06 17:02:44 +09:00
Dean Herbert
4026ca84f8
Move selected retrieval functions to base class
2025-02-06 16:48:17 +09:00
Dean Herbert
a25e1f4f9b
Add test coverage of artist grouping
2025-02-06 16:48:17 +09:00
Salman Alshamrani
aa9727c020
Fix helper method in carousel test scene
2025-02-06 02:44:52 -05:00
Bartłomiej Dach
5bcd79956b
Merge branch 'master' into bss/api-setup
2025-02-06 08:30:01 +01:00
Salman Alshamrani
e1d6ce5ff4
Add V2 suffix for easier test browsing
2025-02-06 02:25:14 -05:00
Salman Alshamrani
3ab208bb46
Fix group visual test scene
2025-02-06 02:21:44 -05:00
Dean Herbert
bf377e081a
Reorganise tests to make more logical when manually testing
2025-02-06 15:09:41 +09:00
Dan Balasescu
d93f7509b6
Fix participant panels not displaying mods from other rulesets correctly
2025-02-06 14:24:09 +09:00
Dean Herbert
0257b8c2ff
Move metadata randomisation local to usage
2025-02-06 14:07:50 +09:00
Dean Herbert
4fda4d625f
Merge pull request #31803 from bdach/bss/submission-progress-display
...
Implement visual component for displaying submission progress
2025-02-06 13:37:08 +09:00
Salman Alshamrani
5e894a6f7e
Fix carousel tests failing due to X offsets
2025-02-05 22:25:39 -05:00
Salman Alshamrani
04a3ee863c
Fix design tests
2025-02-05 21:45:34 -05:00
Salman Alshamrani
f9962f95f0
Implement group panel design
2025-02-05 21:45:34 -05:00
Salman Alshamrani
29882a2542
Allow importing real beatmaps in song select test scene
2025-02-05 21:45:34 -05:00
Salman Alshamrani
696366f8cb
Implement beatmap "standalone" panel design
2025-02-05 08:16:41 -05:00
Salman Alshamrani
04d8bafdce
Implement beatmap difficulty panel design
2025-02-05 08:16:41 -05:00
Salman Alshamrani
206b5c93c0
Implement beatmap set header design
2025-02-05 08:16:41 -05:00
Bartłomiej Dach
7d299bb2ad
Expose EndpointConfiguration directly in IAPIAccess
2025-02-05 13:31:37 +01:00
