1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-22 00:30:45 +08:00

Merge branch 'master' into fix/window-sizing-dropdown

This commit is contained in:
Bartłomiej Dach
2025-11-19 09:52:31 +01:00
committed by GitHub
Unverified
2 changed files with 5 additions and 2 deletions
@@ -67,6 +67,9 @@ namespace osu.Game.Rulesets.Osu.Mods
{
if (LastAcceptedAction != null && nonGameplayPeriods.IsInAny(gameplayClock.CurrentTime))
LastAcceptedAction = null;
if (LastAcceptedAction != null && gameplayClock.IsRewinding)
LastAcceptedAction = null;
}
protected abstract bool CheckValidNewAction(OsuAction action);
+2 -2
View File
@@ -1035,13 +1035,13 @@ namespace osu.Game.Screens.SelectV2
private bool nextRandomBeatmap()
{
ICollection<GroupedBeatmap> visibleBeatmaps = ExpandedGroup != null
ICollection<GroupedBeatmap> visibleBeatmaps = ExpandedGroup != null && grouping.GroupItems.TryGetValue(ExpandedGroup, out var groupItems)
// In the case of grouping, users expect random to only operate on the expanded group.
// This is going to incur some overhead as we don't have a group-beatmapset mapping currently.
//
// If this becomes an issue, we could either store a mapping, or run the random algorithm many times
// using the `SetItems` method until we get a group HIT.
? grouping.GroupItems[ExpandedGroup].Select(i => i.Model).OfType<GroupedBeatmap>().ToArray()
? groupItems.Select(i => i.Model).OfType<GroupedBeatmap>().ToArray()
: GetCarouselItems()!.Select(i => i.Model).OfType<GroupedBeatmap>().ToArray();
GroupedBeatmap beatmap;