h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-13 03:02:56 +08:00
Code Issues Releases Wiki Activity

Factor out edge type logic

Browse Source
This commit is contained in:
Naxess 2021-06-26 20:45:31 +02:00
parent 51147405c5
commit f78cc9397e
1 changed files with 30 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
osu.Game/Rulesets/Edit/Checks/CheckMutedObjects.cs
View File

@ -22,6 +22,14 @@ namespace osu.Game.Rulesets.Edit.Checks
/// </summary> /// </summary>
private const int low_volume_threshold = 20; private const int low_volume_threshold = 20;
private enum EdgeType
{
Head,
Repeat,
Tail,
None
}
public CheckMetadata Metadata { get; } = new CheckMetadata(CheckCategory.Audio, "Low volume hitobjects"); public CheckMetadata Metadata { get; } = new CheckMetadata(CheckCategory.Audio, "Low volume hitobjects");
public IEnumerable<IssueTemplate> PossibleTemplates => new IssueTemplate[] public IEnumerable<IssueTemplate> PossibleTemplates => new IssueTemplate[]
@ -58,37 +66,43 @@ namespace osu.Game.Rulesets.Edit.Checks
int maxVolume = sampledHitObject.Samples.Max(sample => sample.Volume > 0 ? sample.Volume : sampledHitObject.SampleControlPoint.SampleVolume); int maxVolume = sampledHitObject.Samples.Max(sample => sample.Volume > 0 ? sample.Volume : sampledHitObject.SampleControlPoint.SampleVolume);
double samplePlayTime = sampledHitObject.GetEndTime(); double samplePlayTime = sampledHitObject.GetEndTime();
bool head = Precision.AlmostEquals(samplePlayTime, hitObject.StartTime, 1f); EdgeType edgeType = getEdgeAtTime(hitObject, samplePlayTime);
bool tail = Precision.AlmostEquals(samplePlayTime, hitObject.GetEndTime(), 1f);
bool repeat = false;
if (hitObject is IHasRepeats hasRepeats && !head && !tail)
{
double spanDuration = hasRepeats.Duration / hasRepeats.SpanCount();
repeat = Precision.AlmostEquals((samplePlayTime - hitObject.StartTime) % spanDuration, 0f, 1f);
}
// We only care about samples played on the edges of objects, not ones like spinnerspin or slidertick. // We only care about samples played on the edges of objects, not ones like spinnerspin or slidertick.
if (!head && !tail && !repeat) if (edgeType == EdgeType.None)
yield break; yield break;
string postfix = null; string postfix = hitObject is IHasDuration ? edgeType.ToString().ToLower() : null;
if (hitObject is IHasDuration)
postfix = head ? "head" : tail ? "tail" : "repeat";
if (maxVolume <= muted_threshold) if (maxVolume <= muted_threshold)
{ {
if (head) if (edgeType == EdgeType.Head)
yield return new IssueTemplateMutedActive(this).Create(hitObject, maxVolume / 100f, sampledHitObject.GetEndTime(), postfix); yield return new IssueTemplateMutedActive(this).Create(hitObject, maxVolume / 100f, sampledHitObject.GetEndTime(), postfix);
else else
yield return new IssueTemplateMutedPassive(this).Create(hitObject, maxVolume / 100f, sampledHitObject.GetEndTime(), postfix); yield return new IssueTemplateMutedPassive(this).Create(hitObject, maxVolume / 100f, sampledHitObject.GetEndTime(), postfix);
} }
else if (maxVolume <= low_volume_threshold && head) else if (maxVolume <= low_volume_threshold && edgeType == EdgeType.Head)
{ {
yield return new IssueTemplateLowVolumeActive(this).Create(hitObject, maxVolume / 100f, sampledHitObject.GetEndTime(), postfix); yield return new IssueTemplateLowVolumeActive(this).Create(hitObject, maxVolume / 100f, sampledHitObject.GetEndTime(), postfix);
} }
} }
private EdgeType getEdgeAtTime(HitObject hitObject, double time)
{
if (Precision.AlmostEquals(time, hitObject.StartTime, 1f))
return EdgeType.Head;
if (Precision.AlmostEquals(time, hitObject.GetEndTime(), 1f))
return EdgeType.Tail;
if (hitObject is IHasRepeats hasRepeats)
{
double spanDuration = hasRepeats.Duration / hasRepeats.SpanCount();
if (Precision.AlmostEquals((time - hitObject.StartTime) % spanDuration, 0f, 1f))
return EdgeType.Repeat;
}
return EdgeType.None;
}
public abstract class IssueTemplateMuted : IssueTemplate public abstract class IssueTemplateMuted : IssueTemplate
{ {
protected IssueTemplateMuted(ICheck check, IssueType type, string unformattedMessage) protected IssueTemplateMuted(ICheck check, IssueType type, string unformattedMessage)