h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-05 10:33:22 +08:00
Code Issues Releases Wiki Activity

Move rate-changing TODO to a common place in CalculateRateWithMods

Browse Source
This commit is contained in:
Tim Schumacher 2024-12-02 23:49:26 +01:00
parent 164b809c89
commit e920cfa187
3 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
osu.Game/Screens/OnlinePlay/Playlists/PlaylistsReadyButton.cs
View File

@ -88,7 +88,6 @@ namespace osu.Game.Screens.OnlinePlay.Playlists
private bool enoughTimeLeft() private bool enoughTimeLeft()
{ {
// TODO: This doesn't consider mods which apply variable rates, yet.
double rate = ModUtils.CalculateRateWithMods(mods.Value); double rate = ModUtils.CalculateRateWithMods(mods.Value);
// We want to avoid users not being able to submit scores if they chose to not skip, // We want to avoid users not being able to submit scores if they chose to not skip,

1
osu.Game/Screens/Select/BeatmapInfoWedge.cs
View File

@ -401,7 +401,6 @@ namespace osu.Game.Screens.Select
if (beatmap == null || bpmLabelContainer == null) if (beatmap == null || bpmLabelContainer == null)
return; return;
// this doesn't consider mods which apply variable rates, yet.
double rate = ModUtils.CalculateRateWithMods(mods.Value); double rate = ModUtils.CalculateRateWithMods(mods.Value);
int bpmMax = FormatUtils.RoundBPM(beatmap.ControlPointInfo.BPMMaximum, rate); int bpmMax = FormatUtils.RoundBPM(beatmap.ControlPointInfo.BPMMaximum, rate);

1
osu.Game/Utils/ModUtils.cs
View File

@ -286,6 +286,7 @@ namespace osu.Game.Utils
{ {
double rate = 1; double rate = 1;
// TODO: This doesn't consider mods which apply variable rates, yet.
foreach (var mod in mods.OfType<IApplicableToRate>()) foreach (var mod in mods.OfType<IApplicableToRate>())
rate = mod.ApplyToRate(0, rate); rate = mod.ApplyToRate(0, rate);