Fix potential exception during removal

2026-05-22 21:00:58 +08:00 · 2019-12-18 12:03:15 +09:00
parent bcc19e29f2
commit df8f8ffd0d
1 changed files with 3 additions and 2 deletions
@@ -33,13 +33,14 @@ namespace osu.Game.Rulesets.UI

        public virtual bool Remove(DrawableHitObject hitObject)
        {
-            bool result = RemoveInternal(hitObject);
+            if (!RemoveInternal(hitObject))
+                return false;

            // Removed last for the comparer to remain ordered during RemoveInternal
            startTimeMap[hitObject].bindable.UnbindAll();
            startTimeMap.Remove(hitObject);

-            return result;
+            return true;
        }

        private void onStartTimeChanged(DrawableHitObject hitObject)