h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-09-21 21:27:24 +08:00
Code Issues Releases Wiki Activity

Fix holding a selection while changing screens causing a crash

Browse Source
This commit is contained in:
Dean Herbert 2023-02-07 16:07:33 +09:00
parent 71eef238c4
commit dad348111d
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game/Overlays/SkinEditor/SkinEditor.cs
View File

@ -481,8 +481,16 @@ namespace osu.Game.Overlays.SkinEditor
remove => throw new NotImplementedException();
}
public void BeginChange() => changeHandler?.BeginChange();
public void EndChange() => changeHandler?.EndChange();
private IEditorChangeHandler? beginChangeHandler;
public void BeginChange()
{
// Change handler may change between begin and end, which can cause unbalanced operations.
// Let's track the one that was used when beginning the change so we can call EndChange on it specifically.
(beginChangeHandler = changeHandler)?.BeginChange();
}
public void EndChange() => beginChangeHandler?.EndChange();
public void SaveState() => changeHandler?.SaveState();
#endregion