h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-15 06:42:56 +08:00
Code Issues Releases Wiki Activity

Add test scene with failing test case

Browse Source
This commit is contained in:
Salman Ahmed 2021-01-23 23:29:32 +03:00
parent f2236312a0
commit d83abfa7d2
2 changed files with 137 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

130
osu.Game.Tests/Visual/UserInterface/TestSceneUpdateableBeatmapSetCover.cs Normal file
View File

@ -0,0 +1,130 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading;
using NUnit.Framework;
using osu.Framework.Allocation;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
using osu.Framework.Testing;
using osu.Game.Beatmaps;
using osu.Game.Beatmaps.Drawables;
using osu.Game.Graphics.Containers;
using osuTK;
namespace osu.Game.Tests.Visual.UserInterface
{
public class TestSceneUpdateableBeatmapSetCover : OsuTestScene
{
[Test]
public void TestLocal([Values] BeatmapSetCoverType coverType)
{
AddStep("setup cover", () => Child = new UpdateableBeatmapSetCover
{
CoverType = coverType,
BeatmapSet = CreateBeatmap(Ruleset.Value).BeatmapInfo.BeatmapSet,
RelativeSizeAxes = Axes.Both,
Masking = true,
});
AddUntilStep("wait for load", () => this.ChildrenOfType<BeatmapSetCover>().SingleOrDefault()?.IsLoaded ?? false);
}
[Test]
public void TestUnloadAndReload()
{
OsuScrollContainer scroll = null;
List<UpdateableBeatmapSetCover> covers = new List<UpdateableBeatmapSetCover>();
AddStep("setup covers", () =>
{
BeatmapSetInfo setInfo = CreateBeatmap(Ruleset.Value).BeatmapInfo.BeatmapSet;
FillFlowContainer fillFlow;
Child = scroll = new OsuScrollContainer
{
Size = new Vector2(500f),
Child = fillFlow = new FillFlowContainer
{
RelativeSizeAxes = Axes.X,
AutoSizeAxes = Axes.Y,
Direction = FillDirection.Vertical,
Spacing = new Vector2(10),
Padding = new MarginPadding { Bottom = 550 }
}
};
var coverTypes = Enum.GetValues<BeatmapSetCoverType>();
for (int i = 0; i < 25; i++)
{
var coverType = coverTypes[i % coverTypes.Length];
var cover = new UpdateableBeatmapSetCover
{
CoverType = coverType,
BeatmapSet = setInfo,
Height = 100,
Masking = true,
};
if (coverType == BeatmapSetCoverType.Cover)
cover.Width = 500;
else if (coverType == BeatmapSetCoverType.Card)
cover.Width = 400;
else if (coverType == BeatmapSetCoverType.List)
cover.Size = new Vector2(100, 50);
fillFlow.Add(cover);
covers.Add(cover);
}
});
var loadedCovers = covers.Where(c => c.ChildrenOfType<BeatmapSetCover>().SingleOrDefault()?.IsLoaded ?? false);
AddUntilStep("some loaded", () => loadedCovers.Any());
AddStep("scroll to end", () => scroll.ScrollToEnd());
AddUntilStep("all unloaded", () => !loadedCovers.Any());
}
[Test]
public void TestSetNullBeatmapWhileLoading()
{
TestUpdateableBeatmapSetCover updateableCover = null;
AddStep("setup cover", () => Child = updateableCover = new TestUpdateableBeatmapSetCover
{
BeatmapSet = CreateBeatmap(Ruleset.Value).BeatmapInfo.BeatmapSet,
RelativeSizeAxes = Axes.Both,
Masking = true,
});
AddStep("change model", () => updateableCover.BeatmapSet = null);
AddWaitStep("wait some", 5);
AddAssert("no cover added", () => !updateableCover.ChildrenOfType<DelayedLoadUnloadWrapper>().Any());
}
private class TestUpdateableBeatmapSetCover : UpdateableBeatmapSetCover
{
protected override BeatmapSetCover CreateBeatmapSetCover(BeatmapSetInfo beatmapSet, BeatmapSetCoverType coverType) => new TestBeatmapSetCover(beatmapSet, coverType);
}
private class TestBeatmapSetCover : BeatmapSetCover
{
public TestBeatmapSetCover(BeatmapSetInfo set, BeatmapSetCoverType type = BeatmapSetCoverType.Cover)
: base(set, type)
{
}
[BackgroundDependencyLoader]
private void load()
{
Thread.Sleep(10000);
}
}
}
}

14
osu.Game/Beatmaps/Drawables/UpdateableBeatmapSetCover.cs
View File

@ -59,6 +59,8 @@ namespace osu.Game.Beatmaps.Drawables
updateCover(); updateCover();
} }
protected virtual BeatmapSetCover CreateBeatmapSetCover(BeatmapSetInfo beatmapSet, BeatmapSetCoverType coverType) => new BeatmapSetCover(beatmapSet, coverType);
private void updateCover() private void updateCover()
{ {
displayedCover?.FadeOut(400); displayedCover?.FadeOut(400);
@ -69,13 +71,11 @@ namespace osu.Game.Beatmaps.Drawables
{ {
Add(displayedCover = new DelayedLoadUnloadWrapper(() => Add(displayedCover = new DelayedLoadUnloadWrapper(() =>
{ {
var cover = new BeatmapSetCover(beatmapSet, coverType) var cover = CreateBeatmapSetCover(beatmapSet, coverType);
{ cover.Anchor = Anchor.Centre;
Anchor = Anchor.Centre, cover.Origin = Anchor.Centre;
Origin = Anchor.Centre, cover.RelativeSizeAxes = Axes.Both;
RelativeSizeAxes = Axes.Both, cover.FillMode = FillMode.Fill;
FillMode = FillMode.Fill,
};
cover.OnLoadComplete += d => d.FadeInFromZero(400, Easing.Out); cover.OnLoadComplete += d => d.FadeInFromZero(400, Easing.Out);
return cover; return cover;
})); }));