h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-21 01:00:27 +08:00
Code Issues Releases Wiki Activity

Reduce the possibility of recomputing drawables when underlying beatmap hasn't changed

Browse Source
This commit is contained in:
Dean Herbert
2017-05-17 16:45:17 +09:00
Unverified
parent 12716d2ab4
commit cab12ee55a
3 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/Select/BeatmapDetails.cs
+2
View File
@@ -49,6 +49,8 @@ namespace osu.Game.Screens.Select
get { return beatmap; }
set
{
if (beatmap == value) return;
beatmap = value;
pendingBeatmapSwitch?.Cancel();
osu.Game/Screens/Select/Leaderboards/Leaderboard.cs
+2
View File
@@ -100,6 +100,8 @@ namespace osu.Game.Screens.Select.Leaderboards
get { return beatmap; }
set
{
if (beatmap == value) return;
beatmap = value;
Scores = null;
osu.Game/Screens/Select/SongSelect.cs
+8 -8
View File
@@ -313,15 +313,15 @@ namespace osu.Game.Screens.Select
{
bool beatmapSetChange = false;
if (!beatmap.Equals(Beatmap?.BeatmapInfo))
if (beatmap.Equals(Beatmap?.BeatmapInfo))
return;
if (beatmap.BeatmapSetInfoID == selectionChangeNoBounce?.BeatmapSetInfoID)
sampleChangeDifficulty.Play();
else
{
if (beatmap.BeatmapSetInfoID == selectionChangeNoBounce?.BeatmapSetInfoID)
sampleChangeDifficulty.Play();
else
{
sampleChangeBeatmap.Play();
beatmapSetChange = true;
}
sampleChangeBeatmap.Play();
beatmapSetChange = true;
}
selectionChangeNoBounce = beatmap;