Fix online lookup cache not clearing completed task on early return

The task not being cleared in the early return path would cause
`pendingRequestTask` to become stuck as a completed task, and
`queryValue()` would not recreate it due to the null check there,
therefore stalling all lookups forevermore until a game restart.

osu.Game/Database/OnlineLookupCache.cs

@@ -116,7 +116,10 @@ namespace osu.Game.Database
             }
 
             if (nextTaskBatch.Count == 0)
+            {
+                finishPendingTask();
                 return;
+            }
 
             // Query the values.
             var request = CreateRequest(nextTaskBatch.Keys.ToArray());
@@ -125,13 +128,7 @@ namespace osu.Game.Database
             // todo: we probably want retry logic here.
             api.Perform(request);
 
-            // Create a new request task if there's still more values to query.
+            finishPendingTask();
-            lock (taskAssignmentLock)
-            {
-                pendingRequestTask = null;
-                if (pendingTasks.Count > 0)
-                    createNewTask();
-            }
 
             var foundValues = RetrieveResults(request);
 
@@ -157,6 +154,17 @@ namespace osu.Game.Database
             }
         }
 
+        private void finishPendingTask()
+        {
+            // Create a new request task if there's still more values to query.
+            lock (taskAssignmentLock)
+            {
+                pendingRequestTask = null;
+                if (pendingTasks.Count > 0)
+                    createNewTask();
+            }
+        }
+
         private void createNewTask() => pendingRequestTask = Task.Run(performLookup);
     }
 }