h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-05 08:52:55 +08:00
Code Issues Releases Wiki Activity

Fix and use score user's IsBot property in results screen animation

Browse Source 
While a mod-created replay did flag itself as performed by a bot, the extension method converting it into a Score did not copy all the generated properties.

As noted, it might be preferable for ModCreatedUser to inherit APIUser and forward it as-is to the Score instance.

Related to PR #24675
This commit is contained in:
Nabile Rahmani 2023-08-29 23:28:50 +02:00
parent 4915b2563c
commit b658b0e346
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Rulesets/Mods/ModExtensions.cs
View File

@ -21,8 +21,10 @@ namespace osu.Game.Rulesets.Mods
{ {
User = new APIUser User = new APIUser
{ {
Id = APIUser.SYSTEM_USER_ID, // TODO: Some fields weren't copied from replayData.User (namely IsBot and Id). Should ModCreatedUser inherit from APIUser so we could pass it verbatim to avoid future mistakes ?
Id = replayData.User.OnlineID,
Username = replayData.User.Username, Username = replayData.User.Username,
IsBot = replayData.User.IsBot,
} }
} }
}; };

2
osu.Game/Screens/Ranking/ResultsScreen.cs
View File

@ -156,7 +156,7 @@ namespace osu.Game.Screens.Ranking
if (Score != null) if (Score != null)
{ {
// only show flair / animation when arriving after watching a play that isn't autoplay. // only show flair / animation when arriving after watching a play that isn't autoplay.
bool shouldFlair = player != null && Score.Mods.All(m => m.UserPlayable); bool shouldFlair = player != null && !Score.User.IsBot;
ScorePanelList.AddScore(Score, shouldFlair); ScorePanelList.AddScore(Score, shouldFlair);
} }