1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-08 08:12:54 +08:00

Add classic skin sprites for slider tick and slider end misses

This commit is contained in:
Dean Herbert 2023-12-25 17:17:23 +09:00
parent ee00f7ea1f
commit b1d994b6ff
No known key found for this signature in database
2 changed files with 23 additions and 6 deletions

View File

@ -58,14 +58,24 @@ namespace osu.Game.Skinning
if (result.IsMiss()) if (result.IsMiss())
{ {
decimal? legacyVersion = skin.GetConfig<SkinConfiguration.LegacySetting, decimal>(SkinConfiguration.LegacySetting.Version)?.Value;
// missed ticks / slider end don't get the normal animation.
if (isMissedTick()) if (isMissedTick())
applyMissedTickScaling();
else
{ {
this.ScaleTo(1.6f); this.ScaleTo(1.6f);
this.ScaleTo(1, 100, Easing.In); this.ScaleTo(1, 100, Easing.In);
decimal? legacyVersion = skin.GetConfig<SkinConfiguration.LegacySetting, decimal>(SkinConfiguration.LegacySetting.Version)?.Value; if (legacyVersion > 1.0m)
{
this.MoveTo(new Vector2(0, -2f));
this.MoveToOffset(new Vector2(0, 10), fade_out_delay + fade_out_length, Easing.In);
}
}
else
{
this.ScaleTo(1.6f);
this.ScaleTo(1, 100, Easing.In);
if (legacyVersion > 1.0m) if (legacyVersion > 1.0m)
{ {

View File

@ -453,11 +453,18 @@ namespace osu.Game.Skinning
private Drawable? getJudgementAnimation(HitResult result) private Drawable? getJudgementAnimation(HitResult result)
{ {
if (result.IsMiss())
return this.GetAnimation("hit0", true, false);
switch (result) switch (result)
{ {
case HitResult.Miss:
return this.GetAnimation("hit0", true, false);
case HitResult.LargeTickMiss:
return this.GetAnimation("slidertickmiss", true, false);
case HitResult.ComboBreak:
case HitResult.IgnoreMiss:
return this.GetAnimation("sliderendmiss", true, false);
case HitResult.Meh: case HitResult.Meh:
return this.GetAnimation("hit50", true, false); return this.GetAnimation("hit50", true, false);