From b1d994b6ffb617f12a09aca20cf0482a3b5db2b9 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Mon, 25 Dec 2023 17:17:23 +0900
Subject: [PATCH] Add classic skin sprites for slider tick and slider end
 misses

---
 osu.Game/Skinning/LegacyJudgementPieceOld.cs | 16 +++++++++++++---
 osu.Game/Skinning/LegacySkin.cs              | 13 ++++++++++---
 2 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/osu.Game/Skinning/LegacyJudgementPieceOld.cs b/osu.Game/Skinning/LegacyJudgementPieceOld.cs
index b8fe2f8d06..1834a17279 100644
--- a/osu.Game/Skinning/LegacyJudgementPieceOld.cs
+++ b/osu.Game/Skinning/LegacyJudgementPieceOld.cs
@@ -58,14 +58,24 @@ namespace osu.Game.Skinning
 
             if (result.IsMiss())
             {
+                decimal? legacyVersion = skin.GetConfig<SkinConfiguration.LegacySetting, decimal>(SkinConfiguration.LegacySetting.Version)?.Value;
+
+                // missed ticks / slider end don't get the normal animation.
                 if (isMissedTick())
-                    applyMissedTickScaling();
-                else
                 {
                     this.ScaleTo(1.6f);
                     this.ScaleTo(1, 100, Easing.In);
 
-                    decimal? legacyVersion = skin.GetConfig<SkinConfiguration.LegacySetting, decimal>(SkinConfiguration.LegacySetting.Version)?.Value;
+                    if (legacyVersion > 1.0m)
+                    {
+                        this.MoveTo(new Vector2(0, -2f));
+                        this.MoveToOffset(new Vector2(0, 10), fade_out_delay + fade_out_length, Easing.In);
+                    }
+                }
+                else
+                {
+                    this.ScaleTo(1.6f);
+                    this.ScaleTo(1, 100, Easing.In);
 
                     if (legacyVersion > 1.0m)
                     {
diff --git a/osu.Game/Skinning/LegacySkin.cs b/osu.Game/Skinning/LegacySkin.cs
index a37a386889..270abe2849 100644
--- a/osu.Game/Skinning/LegacySkin.cs
+++ b/osu.Game/Skinning/LegacySkin.cs
@@ -453,11 +453,18 @@ namespace osu.Game.Skinning
 
         private Drawable? getJudgementAnimation(HitResult result)
         {
-            if (result.IsMiss())
-                return this.GetAnimation("hit0", true, false);
-
             switch (result)
             {
+                case HitResult.Miss:
+                    return this.GetAnimation("hit0", true, false);
+
+                case HitResult.LargeTickMiss:
+                    return this.GetAnimation("slidertickmiss", true, false);
+
+                case HitResult.ComboBreak:
+                case HitResult.IgnoreMiss:
+                    return this.GetAnimation("sliderendmiss", true, false);
+
                 case HitResult.Meh:
                     return this.GetAnimation("hit50", true, false);