h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-12 22:34:40 +08:00
Code Issues Releases Wiki Activity

Remove localisation schedule hack in TabletSettings (#38040)

Browse Source 
Originally added in https://github.com/ppy/osu/pull/36848.

The reason I'm bothering is that the original instance is being used in
https://github.com/ppy/osu/pull/37494#discussion_r3391818630 as
precedent justification for copy-pasting the same hack in however many
places going forward and I do not want that to happen.
This commit is contained in:
Bartłomiej Dach
2026-06-11 10:36:14 +02:00
committed by GitHub
Unverified
parent bbbd3f6b12
commit ada19d93a7
1 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Overlays/Settings/Sections/Input/TabletSettings.cs
+11 -14
View File
@@ -345,14 +345,14 @@ namespace osu.Game.Overlays.Settings.Sections.Input
private partial class NoTabletMessage : CompositeDrawable
{
private readonly Bindable<Language> currentLanguage = new Bindable<Language>();
private IBindable<string> noTabletDetectedText = new Bindable<string>();
private LinkFlowContainer linkContainer;
[Resolved]
private LocalisationManager localisation { get; set; }
[BackgroundDependencyLoader]
private void load(OsuGameBase game, OsuColour colours, OverlayColourProvider colourProvider)
private void load(OsuColour colours, OverlayColourProvider colourProvider)
{
RelativeSizeAxes = Axes.X;
AutoSizeAxes = Axes.Y;
@@ -406,26 +406,23 @@ namespace osu.Game.Overlays.Settings.Sections.Input
},
};
if (game != null)
currentLanguage.BindTo(game.CurrentLanguage);
const string url = @"https://opentabletdriver.net/Wiki/FAQ/General";
noTabletDetectedText = localisation.GetLocalisedBindableString(TabletSettingsStrings.NoTabletDetectedDescription(url));
}
protected override void LoadComplete()
{
base.LoadComplete();
currentLanguage.BindValueChanged(_ =>
// schedule required because `LocalisationManager` won't have new language set correctly yet.
Schedule(() =>
{
linkContainer.Clear();
linkContainer.NewLine();
noTabletDetectedText.BindValueChanged(_ =>
{
linkContainer.Clear();
linkContainer.NewLine();
const string url = @"https://opentabletdriver.net/Wiki/FAQ/General";
var formattedSource = MessageFormatter.FormatText(localisation.GetLocalisedString(TabletSettingsStrings.NoTabletDetectedDescription(url)));
var formattedSource = MessageFormatter.FormatText(noTabletDetectedText.Value);
linkContainer.AddLinks(formattedSource.Text, formattedSource.Links);
}), true);
linkContainer.AddLinks(formattedSource.Text, formattedSource.Links);
}, true);
}
}
}