h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-18 18:27:45 +08:00
Code Issues Releases Wiki Activity

Use isTick.

Browse Source
This commit is contained in:
smoogipooo 2017-03-24 11:24:07 +09:00
parent 4ae45ea866
commit a1f5bc04aa
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
osu.Game.Modes.Taiko/Scoring/TaikoScoreProcessor.cs
View File

@ -187,10 +187,10 @@ namespace osu.Game.Modes.Taiko.Scoring
protected override void UpdateCalculations(TaikoJudgement newJudgement)
{
var tickJudgement = newJudgement as TaikoDrumRollTickJudgement;
bool isTick = newJudgement is TaikoDrumRollTickJudgement;
// Don't consider ticks as a type of hit that counts towards map completion
if (tickJudgement == null)
if (!isTick)
totalHits++;
// Apply score changes
@ -203,7 +203,7 @@ namespace osu.Game.Modes.Taiko.Scoring
baseValue += baseValue * finisherScoreScale;
// Add score to portions
if (tickJudgement != null)
if (isTick)
bonusScore += baseValue;
else
{
@ -222,7 +222,7 @@ namespace osu.Game.Modes.Taiko.Scoring
{
case HitResult.Miss:
// Missing ticks shouldn't drop HP
if (tickJudgement == null)
if (!isTick)
Health.Value += hpIncreaseMiss;
break;
case HitResult.Hit:
@ -232,8 +232,7 @@ namespace osu.Game.Modes.Taiko.Scoring
Health.Value += hpIncreaseGood;
break;
case TaikoHitResult.Great:
// Ticks only give out a different portion of HP because they're more spammable
if (tickJudgement != null)
if (isTick)
Health.Value += hpIncreaseTick;
else
Health.Value += hpIncreaseGreat;