h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-28 01:47:33 +08:00
Code Issues Releases Wiki Activity

Merge pull request #16218 from peppy/mouse-wheel-volume-test-reliability

Browse Source 
Adjust testing methodology to improve reliability of mosue wheel volume adjust tests
This commit is contained in:
Dan Balasescu 2021-12-23 14:23:05 +09:00 committed by GitHub
commit 9a8569545e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
osu.Game.Tests/Visual/Navigation/TestSceneMouseWheelVolumeAdjust.cs
View File

@ -25,8 +25,11 @@ namespace osu.Game.Tests.Visual.Navigation
public void TestAdjustVolumeFromMainMenu() public void TestAdjustVolumeFromMainMenu()
{ {
// First scroll makes volume controls appear, second adjusts volume. // First scroll makes volume controls appear, second adjusts volume.
AddRepeatStep("Adjust volume using mouse wheel", () => InputManager.ScrollVerticalBy(5), 2); AddUntilStep("Adjust volume using mouse wheel", () =>
AddUntilStep("Volume is above zero", () => Game.Audio.AggregateVolume.Value > 0); {
InputManager.ScrollVerticalBy(5);
return Game.Audio.AggregateVolume.Value > 0;
});
} }
[Test] [Test]
@ -35,7 +38,11 @@ namespace osu.Game.Tests.Visual.Navigation
loadToPlayerNonBreakTime(); loadToPlayerNonBreakTime();
// First scroll makes volume controls appear, second adjusts volume. // First scroll makes volume controls appear, second adjusts volume.
AddRepeatStep("Adjust volume using mouse wheel", () => InputManager.ScrollVerticalBy(5), 2); AddUntilStep("Adjust volume using mouse wheel", () =>
{
InputManager.ScrollVerticalBy(5);
return Game.Audio.AggregateVolume.Value > 0;
});
AddAssert("Volume is above zero", () => Game.Audio.Volume.Value > 0); AddAssert("Volume is above zero", () => Game.Audio.Volume.Value > 0);
} }
@ -47,7 +54,7 @@ namespace osu.Game.Tests.Visual.Navigation
loadToPlayerNonBreakTime(); loadToPlayerNonBreakTime();
// First scroll makes volume controls appear, second adjusts volume. // First scroll makes volume controls appear, second adjusts volume.
AddRepeatStep("Adjust volume using mouse wheel", () => InputManager.ScrollVerticalBy(5), 2); AddRepeatStep("Adjust volume using mouse wheel", () => InputManager.ScrollVerticalBy(5), 10);
AddAssert("Volume is still zero", () => Game.Audio.Volume.Value == 0); AddAssert("Volume is still zero", () => Game.Audio.Volume.Value == 0);
} }
@ -59,14 +66,13 @@ namespace osu.Game.Tests.Visual.Navigation
loadToPlayerNonBreakTime(); loadToPlayerNonBreakTime();
// First scroll makes volume controls appear, second adjusts volume. // First scroll makes volume controls appear, second adjusts volume.
AddRepeatStep("Adjust volume using mouse wheel holding alt", () => AddUntilStep("Adjust volume using mouse wheel holding alt", () =>
{ {
InputManager.PressKey(Key.AltLeft); InputManager.PressKey(Key.AltLeft);
InputManager.ScrollVerticalBy(5); InputManager.ScrollVerticalBy(5);
InputManager.ReleaseKey(Key.AltLeft); InputManager.ReleaseKey(Key.AltLeft);
}, 2); return Game.Audio.AggregateVolume.Value > 0;
});
AddAssert("Volume is above zero", () => Game.Audio.Volume.Value > 0);
} }
private void loadToPlayerNonBreakTime() private void loadToPlayerNonBreakTime()