h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-06 03:43:21 +08:00
Code Issues Releases Wiki Activity

Remove unnecessary UnbindAdjustments call

Browse Source 
It is not necessary given that `CurrentTrack` already removes all adjustments first.
This commit is contained in:
Salman Ahmed 2022-05-10 20:49:15 +03:00
parent 36a7644164
commit 9446be2511
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
osu.Game/Overlays/MusicController.cs
View File

@ -393,21 +393,11 @@ namespace osu.Game.Overlays
CurrentTrack.RemoveAllAdjustments(AdjustableProperty.Tempo); CurrentTrack.RemoveAllAdjustments(AdjustableProperty.Tempo);
CurrentTrack.RemoveAllAdjustments(AdjustableProperty.Volume); CurrentTrack.RemoveAllAdjustments(AdjustableProperty.Volume);
var applicableToTrack = mods.Value.OfType<IApplicableToTrack>(); if (allowTrackAdjustments)
if (!allowTrackAdjustments || !applicableToTrack.Any())
{
if (modTrackAdjustments != null)
{
CurrentTrack.UnbindAdjustments(modTrackAdjustments);
modTrackAdjustments = null;
}
}
else
{ {
CurrentTrack.BindAdjustments(modTrackAdjustments = new AudioAdjustments()); CurrentTrack.BindAdjustments(modTrackAdjustments = new AudioAdjustments());
foreach (var mod in applicableToTrack) foreach (var mod in mods.Value.OfType<IApplicableToTrack>())
mod.ApplyToTrack(modTrackAdjustments); mod.ApplyToTrack(modTrackAdjustments);
} }
} }