h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-03 22:14:57 +08:00
Code Issues Releases Wiki Activity

Merge pull request #34882 from peppy/fix-excess-requests-song-select

Browse Source 
Fix excess requests leading to queueing / delays of updating metadata at song select
This commit is contained in:
Bartłomiej Dach
2025-09-01 11:49:32 +02:00
committed by GitHub
Unverified
parent 5de7cc3efb 9d0043d03b
commit 82a135af19
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/SelectV2/RealmPopulatingOnlineLookupSource.cs
+2
View File
@@ -43,6 +43,8 @@ namespace osu.Game.Screens.SelectV2
var request = new GetBeatmapSetRequest(id);
var tcs = new TaskCompletionSource<APIBeatmapSet?>();
token.Register(() => request.Cancel());
// async request success callback is a bit of a dangerous game, but there's some reasoning for it.
// - don't really want to use `IAPIAccess.PerformAsync()` because we still want to respect request queueing & online status checks
// - we want the realm write here to be async because it is known to be slow for some users with large beatmap collections
osu.Game/Screens/SelectV2/SongSelect.cs
+1 -1
View File
@@ -1011,7 +1011,7 @@ namespace osu.Game.Screens.SelectV2
lastLookupResult.Value = BeatmapSetLookupResult.InProgress();
onlineLookupCancellation = new CancellationTokenSource();
currentOnlineLookup = onlineLookupSource.GetBeatmapSetAsync(beatmapSetInfo.OnlineID);
currentOnlineLookup = onlineLookupSource.GetBeatmapSetAsync(beatmapSetInfo.OnlineID, onlineLookupCancellation.Token);
currentOnlineLookup.ContinueWith(t =>
{
if (t.IsCompletedSuccessfully)