h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-05 20:24:45 +08:00
Code Issues Releases Wiki Activity

Fix crash when trying to scope to beatmap set in multiplayer freestyle select screen with sorting/grouping mode which has difficulties split apart (#37997)

Browse Source 
Closes https://github.com/ppy/osu/issues/37995.

See
https://github.com/ppy/osu/blob/9727d95ad9a46ecaafd8b4fe62e68f45db607661/osu.Game/Screens/Select/SongSelect.cs#L91-L95
for why this would crash.
This commit is contained in:
Bartłomiej Dach
2026-06-05 08:57:33 +02:00
committed by GitHub
Unverified
parent c83737bec5
commit 776d92de7b
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/Select/PanelBeatmapStandalone.SpreadDisplay.cs
+8
View File
@@ -26,6 +26,7 @@ namespace osu.Game.Screens.Select
{
public Bindable<BeatmapInfo?> Beatmap { get; } = new Bindable<BeatmapInfo?>();
public Bindable<StarDifficulty> StarDifficulty { get; } = new Bindable<StarDifficulty>();
public BindableBool Selected { get; } = new BindableBool();
protected override Colour4 DimColour => Colour4.White;
@@ -140,6 +141,8 @@ namespace osu.Game.Screens.Select
StarDifficulty.BindValueChanged(_ => updateBeatmap());
showConvertedBeatmaps.BindValueChanged(_ => updateBeatmap());
scopedBeatmapSet.BindValueChanged(_ => updateBeatmap(), true);
Selected.BindValueChanged(_ => updateEnabled());
scopedBeatmapSet.BindDisabledChanged(_ => updateEnabled(), true);
Enabled.BindValueChanged(_ => updateAppearance(), true);
FinishTransforms(true);
}
@@ -254,6 +257,11 @@ namespace osu.Game.Screens.Select
base.OnHoverLost(e);
}
private void updateEnabled()
{
Enabled.Value = Selected.Value && !scopedBeatmapSet.Disabled;
}
private void updateAppearance()
{
bool isInteractable = Enabled.Value && IsHovered;
osu.Game/Screens/Select/PanelBeatmapStandalone.cs
+1 -1
View File
@@ -194,6 +194,7 @@ namespace osu.Game.Screens.Select
{
Origin = Anchor.CentreLeft,
Anchor = Anchor.CentreLeft,
Selected = { BindTarget = Selected },
}
},
}
@@ -214,7 +215,6 @@ namespace osu.Game.Screens.Select
Selected.BindValueChanged(s =>
{
Expanded.Value = s.NewValue;
spreadDisplay.Enabled.Value = s.NewValue;
}, true);
}