1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 10:18:22 +08:00

Expand tests to cover non-bank sample lookups

This commit is contained in:
Bartłomiej Dach 2020-07-30 20:10:41 +02:00
parent e60c085bf2
commit 5af45bcdcc

View File

@ -67,9 +67,11 @@ namespace osu.Game.Tests.Gameplay
/// Tests that a hitobject which provides a custom sample set of 2 retrieves the following samples from the beatmap skin: /// Tests that a hitobject which provides a custom sample set of 2 retrieves the following samples from the beatmap skin:
/// normal-hitnormal2 /// normal-hitnormal2
/// normal-hitnormal /// normal-hitnormal
/// hitnormal
/// </summary> /// </summary>
[TestCase("normal-hitnormal2")] [TestCase("normal-hitnormal2")]
[TestCase("normal-hitnormal")] [TestCase("normal-hitnormal")]
[TestCase("hitnormal")]
public void TestDefaultCustomSampleFromBeatmap(string expectedSample) public void TestDefaultCustomSampleFromBeatmap(string expectedSample)
{ {
SetupSkins(expectedSample, expectedSample); SetupSkins(expectedSample, expectedSample);
@ -83,9 +85,11 @@ namespace osu.Game.Tests.Gameplay
/// Tests that a hitobject which provides a custom sample set of 2 retrieves the following samples from the user skin when the beatmap does not contain the sample: /// Tests that a hitobject which provides a custom sample set of 2 retrieves the following samples from the user skin when the beatmap does not contain the sample:
/// normal-hitnormal2 /// normal-hitnormal2
/// normal-hitnormal /// normal-hitnormal
/// hitnormal
/// </summary> /// </summary>
[TestCase("normal-hitnormal2")] [TestCase("normal-hitnormal2")]
[TestCase("normal-hitnormal")] [TestCase("normal-hitnormal")]
[TestCase("hitnormal")]
public void TestDefaultCustomSampleFromUserSkinFallback(string expectedSample) public void TestDefaultCustomSampleFromUserSkinFallback(string expectedSample)
{ {
SetupSkins(string.Empty, expectedSample); SetupSkins(string.Empty, expectedSample);
@ -145,6 +149,7 @@ namespace osu.Game.Tests.Gameplay
/// </summary> /// </summary>
[TestCase("normal-hitnormal2")] [TestCase("normal-hitnormal2")]
[TestCase("normal-hitnormal")] [TestCase("normal-hitnormal")]
[TestCase("hitnormal")]
public void TestControlPointCustomSampleFromBeatmap(string sampleName) public void TestControlPointCustomSampleFromBeatmap(string sampleName)
{ {
SetupSkins(sampleName, sampleName); SetupSkins(sampleName, sampleName);