Merge pull request #36580 from peppy/fix-revert-button-wrong-size

Fix revert to default button not resizing correctly after changing languages

osu.Game/Graphics/UserInterfaceV2/FormCheckBox.cs

@@ -139,5 +139,7 @@ namespace osu.Game.Graphics.UserInterfaceV2
         public void SetDefault() => Current.SetDefault();
 
         public bool IsDisabled => Current.Disabled;
+
+        public float MainDrawHeight => DrawHeight;
     }
 }

osu.Game/Graphics/UserInterfaceV2/FormDropdown.cs

@@ -80,6 +80,8 @@ namespace osu.Game.Graphics.UserInterfaceV2
 
         public bool IsDisabled => Current.Disabled;
 
+        public float MainDrawHeight => header.DrawHeight;
+
         protected override DropdownHeader CreateHeader() => header = new FormDropdownHeader
         {
             Dropdown = this,

osu.Game/Graphics/UserInterfaceV2/FormSliderBar.cs

@@ -631,5 +631,7 @@ namespace osu.Game.Graphics.UserInterfaceV2
         public void SetDefault() => Current.SetDefault();
 
         public bool IsDisabled => Current.Disabled;
+
+        public float MainDrawHeight => DrawHeight;
     }
 }

osu.Game/Graphics/UserInterfaceV2/FormTextBox.cs

@@ -249,5 +249,7 @@ namespace osu.Game.Graphics.UserInterfaceV2
         public bool IsDisabled => current.Disabled;
 
         public IEnumerable<LocalisableString> FilterTerms => Caption.Yield();
+
+        public float MainDrawHeight => DrawHeight;
     }
 }

osu.Game/Graphics/UserInterfaceV2/IFormControl.cs

@@ -31,5 +31,11 @@ namespace osu.Game.Graphics.UserInterfaceV2
         /// Whether the control is currently disabled.
         /// </summary>
         bool IsDisabled { get; }
+
+        /// <summary>
+        /// The height of the main part of the control (when not expanded).
+        /// This is used to attach external elements.
+        /// </summary>
+        float MainDrawHeight { get; }
     }
 }

osu.Game/Overlays/Settings/Sections/Input/KeyBindingRow.cs

@@ -136,6 +136,7 @@ namespace osu.Game.Overlays.Settings.Sections.Input
                 {
                     Anchor = Anchor.TopRight,
                     Origin = Anchor.TopRight,
+                    RelativeSizeAxes = Axes.Y,
                     Action = RestoreDefaults,
                 },
                 new Container

osu.Game/Overlays/Settings/SettingsItemV2.cs

@@ -85,12 +85,6 @@ namespace osu.Game.Overlays.Settings
             controlDefault.BindValueChanged(_ => updateDefaultState());
             controlEnabled.BindValueChanged(_ => updateDefaultState(), true);
             FinishTransforms(true);
-
-            ScheduleAfterChildren(() =>
-            {
-                revertButton.RelativeSizeAxes = Axes.None;
-                revertButton.Height = ((Drawable)Control).DrawHeight;
-            });
         }
 
         private void updateDefaultState()
@@ -108,6 +102,8 @@ namespace osu.Game.Overlays.Settings
             base.Update();
             controlDefault.Value = Control.IsDefault;
             controlEnabled.Value = !Control.IsDisabled;
+
+            revertButton.Height = Control.MainDrawHeight;
         }
 
         #region ISettingsItem

osu.Game/Overlays/Settings/SettingsRevertToDefaultButton.cs

@@ -30,7 +30,6 @@ namespace osu.Game.Overlays.Settings
 
         public SettingsRevertToDefaultButton()
         {
-            RelativeSizeAxes = Axes.Y;
             Width = WIDTH;
         }