h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-13 22:03:21 +08:00
Code Issues Releases Wiki Activity

Fix incorrect passing logic

Browse Source
This commit is contained in:
Dean Herbert 2020-05-10 07:51:39 +09:00
parent 7ce78d8ce4
commit 3565fe1cb2
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game.Rulesets.Taiko/Skinning/LegacyTaikoScroller.cs
View File

@ -39,7 +39,11 @@ namespace osu.Game.Rulesets.Taiko.Skinning
{ {
var r = result.NewValue; var r = result.NewValue;
passing = r == null || (r.Judgement.AffectsCombo && r.Type > HitResult.Miss); // always ignore hitobjects that don't affect combo (drumroll ticks etc.)
if (r?.Judgement.AffectsCombo == false)
return;
passing = r == null || r.Type > HitResult.Miss;
foreach (var sprite in InternalChildren.OfType<ScrollerSprite>()) foreach (var sprite in InternalChildren.OfType<ScrollerSprite>())
sprite.Passing = passing; sprite.Passing = passing;