h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-27 15:43:21 +08:00
Code Issues Releases Wiki Activity

Move TODO comment to correct location

Browse Source
This commit is contained in:
Salman Ahmed 2021-06-11 11:46:29 +03:00
parent 8132852753
commit 2e01e61177
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
osu.Game/Skinning/RulesetSkinProvidingContainer.cs
View File

@ -56,6 +56,7 @@ namespace osu.Game.Skinning
SkinSources.Add(Ruleset.CreateLegacySkinProvider(skinManager.CurrentSkin.Value, Beatmap)); SkinSources.Add(Ruleset.CreateLegacySkinProvider(skinManager.CurrentSkin.Value, Beatmap));
// TODO: we also want to return a DefaultLegacySkin here if the current *beatmap* is providing any skinned elements.
if (skinManager.CurrentSkin.Value is LegacySkin) if (skinManager.CurrentSkin.Value is LegacySkin)
SkinSources.Add(Ruleset.CreateLegacySkinProvider(skinManager.DefaultLegacySkin, Beatmap)); SkinSources.Add(Ruleset.CreateLegacySkinProvider(skinManager.DefaultLegacySkin, Beatmap));

3
osu.Game/Skinning/SkinManager.cs
View File

@ -247,9 +247,6 @@ namespace osu.Game.Skinning
if (lookupFunction(CurrentSkin.Value) is T skinSourced) if (lookupFunction(CurrentSkin.Value) is T skinSourced)
return skinSourced; return skinSourced;
// TODO: we also want to return a DefaultLegacySkin here if the current *beatmap* is providing any skinned elements.
// When attempting to address this, we may want to move the full DefaultLegacySkin fallback logic to within Player itself (to better allow
// for beatmap skin visibility).
if (CurrentSkin.Value is LegacySkin && lookupFunction(DefaultLegacySkin) is T legacySourced) if (CurrentSkin.Value is LegacySkin && lookupFunction(DefaultLegacySkin) is T legacySourced)
return legacySourced; return legacySourced;