h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-22 06:29:54 +08:00
Code Issues Releases Wiki Activity

Merge pull request #36177 from peppy/debounce-seeks

Browse Source 
Fix editor seeks not being debounced enough
This commit is contained in:
Bartłomiej Dach
2025-12-31 08:15:35 +01:00
committed by GitHub
Unverified
parent 9f57be7410 853836a48b
commit 2d119f11ec
1 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/MarkerPart.cs
+15 -7
View File
@@ -63,16 +63,24 @@ namespace osu.Game.Screens.Edit.Components.Timelines.Summary.Parts
/// <param name="instant">Whether the seek should be instant (drag end, mouse button press) or debounced (drag in progress).</param>
private void seekToPosition(Vector2 screenPosition, bool instant)
{
float markerPos = Math.Clamp(ToLocalSpace(screenPosition).X, 0, DrawWidth);
double seekDestination = markerPos / DrawWidth * editorClock.TrackLength;
marker.X = (float)seekDestination;
// Debounce seeks to ensure we only run one per update frame at most.
//
// Without this, we could end up seeking 1000+ times per second, leading to
// unexpected performance overheads as the editor tries to prepare for displaying
// each of the destinations.
Scheduler.AddOnce(data =>
{
float markerPos = Math.Clamp(ToLocalSpace(data.screenPosition).X, 0, DrawWidth);
double seekDestination = markerPos / DrawWidth * editorClock.TrackLength;
marker.X = (float)seekDestination;
if (editorClock.IsRunning && !instant && lastSeekTime != null && Time.Current - lastSeekTime < NowPlayingOverlay.TRACK_DRAG_SEEK_DEBOUNCE)
return;
if (editorClock.IsRunning && !data.instant && lastSeekTime != null && Time.Current - lastSeekTime < NowPlayingOverlay.TRACK_DRAG_SEEK_DEBOUNCE)
return;
editorClock.Seek(seekDestination);
editorClock.Seek(seekDestination);
lastSeekTime = instant ? null : Time.Current;
lastSeekTime = data.instant ? null : Time.Current;
}, (screenPosition, instant));
}
protected override void Update()